| Message ID | 20220504205411.1510667-2-bjorn.andersson@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] ARM: dts: qcom: Add LPG node to pm8941 | expand |
On 4.05.2022 22:54, Bjorn Andersson wrote: > Both Castor and Honami has RGB LEDs driven by the PM8941 LPG, define > these. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > --- > .../dts/qcom-msm8974-sony-xperia-rhine.dtsi | 30 +++++++++++++++++++ > ...-msm8974pro-sony-xperia-shinano-castor.dts | 30 +++++++++++++++++++ > 2 files changed, 60 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi > index 1d21de46f85c..9891d0d40945 100644 > --- a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi > +++ b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi > @@ -3,6 +3,7 @@ > #include "qcom-pm8841.dtsi" > #include "qcom-pm8941.dtsi" > #include <dt-bindings/input/input.h> > +#include <dt-bindings/leds/common.h> > #include <dt-bindings/pinctrl/qcom,pmic-gpio.h> > > / { > @@ -172,6 +173,35 @@ gpio_keys_pin_a: gpio-keys-active { > }; > }; > > +&pm8941_lpg { > + status = "okay"; > + > + qcom,power-source = <1>; > + > + rgb-led { > + color = <LED_COLOR_ID_RGB>; > + function = LED_FUNCTION_STATUS; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + led@1 { > + reg = <7>; Hi, please sync regs and unit addresses (and sort them while at it). Konrad > + color = <LED_COLOR_ID_RED>; > + }; > + > + led@2 { > + reg = <6>; > + color = <LED_COLOR_ID_GREEN>; > + }; > + > + led@3 { > + reg = <5>; > + color = <LED_COLOR_ID_BLUE>; > + }; > + }; > +}; > + > &pm8941_wled { > status = "okay"; > > diff --git a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts > index 9bd8faea61a5..da1593192306 100644 > --- a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts > +++ b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts > @@ -3,6 +3,7 @@ > #include "qcom-pm8841.dtsi" > #include "qcom-pm8941.dtsi" > #include <dt-bindings/input/input.h> > +#include <dt-bindings/leds/common.h> > #include <dt-bindings/pinctrl/qcom,pmic-gpio.h> > > / { > @@ -288,6 +289,35 @@ lcd_dcdc_en_pin_a: lcd-dcdc-en-active { > > }; > > +&pm8941_lpg { > + status = "okay"; > + > + qcom,power-source = <1>; > + > + rgb-led { > + color = <LED_COLOR_ID_RGB>; > + function = LED_FUNCTION_STATUS; > + > + #address-cells = <1>; > + #size-cells = <0>; > + > + led@1 { > + reg = <7>; > + color = <LED_COLOR_ID_RED>; > + }; > + > + led@2 { > + reg = <6>; > + color = <LED_COLOR_ID_GREEN>; > + }; > + > + led@3 { > + reg = <5>; > + color = <LED_COLOR_ID_BLUE>; > + }; > + }; > +}; > + > &rpm_requests { > pm8941-regulators { > compatible = "qcom,rpm-pm8941-regulators"; >
diff --git a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi index 1d21de46f85c..9891d0d40945 100644 --- a/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi +++ b/arch/arm/boot/dts/qcom-msm8974-sony-xperia-rhine.dtsi @@ -3,6 +3,7 @@ #include "qcom-pm8841.dtsi" #include "qcom-pm8941.dtsi" #include <dt-bindings/input/input.h> +#include <dt-bindings/leds/common.h> #include <dt-bindings/pinctrl/qcom,pmic-gpio.h> / { @@ -172,6 +173,35 @@ gpio_keys_pin_a: gpio-keys-active { }; }; +&pm8941_lpg { + status = "okay"; + + qcom,power-source = <1>; + + rgb-led { + color = <LED_COLOR_ID_RGB>; + function = LED_FUNCTION_STATUS; + + #address-cells = <1>; + #size-cells = <0>; + + led@1 { + reg = <7>; + color = <LED_COLOR_ID_RED>; + }; + + led@2 { + reg = <6>; + color = <LED_COLOR_ID_GREEN>; + }; + + led@3 { + reg = <5>; + color = <LED_COLOR_ID_BLUE>; + }; + }; +}; + &pm8941_wled { status = "okay"; diff --git a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts index 9bd8faea61a5..da1593192306 100644 --- a/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts +++ b/arch/arm/boot/dts/qcom-msm8974pro-sony-xperia-shinano-castor.dts @@ -3,6 +3,7 @@ #include "qcom-pm8841.dtsi" #include "qcom-pm8941.dtsi" #include <dt-bindings/input/input.h> +#include <dt-bindings/leds/common.h> #include <dt-bindings/pinctrl/qcom,pmic-gpio.h> / { @@ -288,6 +289,35 @@ lcd_dcdc_en_pin_a: lcd-dcdc-en-active { }; +&pm8941_lpg { + status = "okay"; + + qcom,power-source = <1>; + + rgb-led { + color = <LED_COLOR_ID_RGB>; + function = LED_FUNCTION_STATUS; + + #address-cells = <1>; + #size-cells = <0>; + + led@1 { + reg = <7>; + color = <LED_COLOR_ID_RED>; + }; + + led@2 { + reg = <6>; + color = <LED_COLOR_ID_GREEN>; + }; + + led@3 { + reg = <5>; + color = <LED_COLOR_ID_BLUE>; + }; + }; +}; + &rpm_requests { pm8941-regulators { compatible = "qcom,rpm-pm8941-regulators";
Both Castor and Honami has RGB LEDs driven by the PM8941 LPG, define these. Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> --- .../dts/qcom-msm8974-sony-xperia-rhine.dtsi | 30 +++++++++++++++++++ ...-msm8974pro-sony-xperia-shinano-castor.dts | 30 +++++++++++++++++++ 2 files changed, 60 insertions(+)