| Message ID | 20220512031259.56459-1-linmq006@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: highbank: Fix refcount leak in highbank_init | expand |
On Thu, 12 May 2022 07:12:58 +0400 Miaoqian Lin <linmq006@gmail.com> wrote: Hi, > of_find_compatible_node() returns a node pointer with refcount > incremented, we should use of_node_put() on it when done. > Add missing of_node_put() to avoid refcount leak. > > Fixes: 220e6cf7b793 ("ARM: add Highbank core platform support") > Signed-off-by: Miaoqian Lin <linmq006@gmail.com> That is basically the same patch as this one: https://lore.kernel.org/linux-arm-kernel/20220408094817.2494756-1-lv.ruyi@zte.com.cn/ Arnd, Olof, can you please take the older one through the soc tree? Maybe adding the Fixes tag from this one? Thanks, Andre > --- > arch/arm/mach-highbank/highbank.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/mach-highbank/highbank.c b/arch/arm/mach-highbank/highbank.c > index db607955a7e4..af9488854fe3 100644 > --- a/arch/arm/mach-highbank/highbank.c > +++ b/arch/arm/mach-highbank/highbank.c > @@ -142,6 +142,7 @@ static void __init highbank_init(void) > np = of_find_compatible_node(NULL, NULL, "calxeda,hb-sregs"); > sregs_base = of_iomap(np, 0); > WARN_ON(!sregs_base); > + of_node_put(np); > > pm_power_off = highbank_power_off; > highbank_pm_init();
diff --git a/arch/arm/mach-highbank/highbank.c b/arch/arm/mach-highbank/highbank.c index db607955a7e4..af9488854fe3 100644 --- a/arch/arm/mach-highbank/highbank.c +++ b/arch/arm/mach-highbank/highbank.c @@ -142,6 +142,7 @@ static void __init highbank_init(void) np = of_find_compatible_node(NULL, NULL, "calxeda,hb-sregs"); sregs_base = of_iomap(np, 0); WARN_ON(!sregs_base); + of_node_put(np); pm_power_off = highbank_power_off; highbank_pm_init();
of_find_compatible_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when done. Add missing of_node_put() to avoid refcount leak. Fixes: 220e6cf7b793 ("ARM: add Highbank core platform support") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- arch/arm/mach-highbank/highbank.c | 1 + 1 file changed, 1 insertion(+)