| Message ID | 20220511052740.46903-1-linmq006@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ed46731d8e86c8d65f5fc717671e1f1f6c3146d2 |
| Headers | show |
| Series | ASoC: imx-hdmi: Fix refcount leak in imx_hdmi_probe | expand |
On Wed, 11 May 2022 09:27:40 +0400, Miaoqian Lin wrote: > of_find_device_by_node() takes reference, we should use put_device() > to release it. when devm_kzalloc() fails, it doesn't have a > put_device(), it will cause refcount leak. > Add missing put_device() to fix this. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: imx-hdmi: Fix refcount leak in imx_hdmi_probe commit: ed46731d8e86c8d65f5fc717671e1f1f6c3146d2 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/fsl/imx-hdmi.c b/sound/soc/fsl/imx-hdmi.c index 929f69b758af..ec149dc73938 100644 --- a/sound/soc/fsl/imx-hdmi.c +++ b/sound/soc/fsl/imx-hdmi.c @@ -126,6 +126,7 @@ static int imx_hdmi_probe(struct platform_device *pdev) data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL); if (!data) { ret = -ENOMEM; + put_device(&cpu_pdev->dev); goto fail; }
of_find_device_by_node() takes reference, we should use put_device() to release it. when devm_kzalloc() fails, it doesn't have a put_device(), it will cause refcount leak. Add missing put_device() to fix this. Fixes: 6a5f850aa83a ("ASoC: fsl: Add imx-hdmi machine driver") Fixes: f670b274f7f6 ("ASoC: imx-hdmi: add put_device() after of_find_device_by_node()") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- sound/soc/fsl/imx-hdmi.c | 1 + 1 file changed, 1 insertion(+)