| Message ID | 20220512125000.8340-1-oneukum@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iguanair: no superfluous usb_unlink_urb() | expand |
On Thu, May 12, 2022 at 02:50:00PM +0200, Oliver Neukum wrote: > Unlinking yourself while the completion handler > is running is a NOP. Drop it. Applied, thanks! Sean > > Signed-off-by: Oliver Neukum <oneukum@suse.com> > --- > drivers/media/rc/iguanair.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/media/rc/iguanair.c b/drivers/media/rc/iguanair.c > index c9cb8277723f..276bf3c8a8cb 100644 > --- a/drivers/media/rc/iguanair.c > +++ b/drivers/media/rc/iguanair.c > @@ -149,10 +149,8 @@ static void iguanair_rx(struct urb *urb) > return; > > ir = urb->context; > - if (!ir) { > - usb_unlink_urb(urb); > + if (!ir) > return; > - } > > switch (urb->status) { > case 0: > @@ -161,7 +159,6 @@ static void iguanair_rx(struct urb *urb) > case -ECONNRESET: > case -ENOENT: > case -ESHUTDOWN: > - usb_unlink_urb(urb); > return; > case -EPIPE: > default: > -- > 2.35.3
diff --git a/drivers/media/rc/iguanair.c b/drivers/media/rc/iguanair.c index c9cb8277723f..276bf3c8a8cb 100644 --- a/drivers/media/rc/iguanair.c +++ b/drivers/media/rc/iguanair.c @@ -149,10 +149,8 @@ static void iguanair_rx(struct urb *urb) return; ir = urb->context; - if (!ir) { - usb_unlink_urb(urb); + if (!ir) return; - } switch (urb->status) { case 0: @@ -161,7 +159,6 @@ static void iguanair_rx(struct urb *urb) case -ECONNRESET: case -ENOENT: case -ESHUTDOWN: - usb_unlink_urb(urb); return; case -EPIPE: default:
Unlinking yourself while the completion handler is running is a NOP. Drop it. Signed-off-by: Oliver Neukum <oneukum@suse.com> --- drivers/media/rc/iguanair.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)