| Message ID | 20220513095722.v2.2.I9804fcd5d6c8552ab25f598dd7a3ea71b15b55f0@changeid (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | None | expand |
On Fri, May 13, 2022 at 09:59:18AM -0700, Douglas Anderson wrote: > This copy-pastes compatibles from sc7180-based boards from the device > trees to the yaml file so that `make dtbs_check` will be happy. > > NOTES: > - I make no attempt to try to share an "item" for all sc7180 based > Chromebooks. Because of the revision matching scheme used by the > Chromebook bootloader, at times we need a different number of > revisions listed. > - Some of the odd entries in here (like google,homestar-rev23 or the > fact that "Google Lazor Limozeen without Touchscreen" changed from > sku5 to sku6) are not typos but simply reflect reality. > - Many revisions of boards here never actually went to consumers, but > they are still in use within various companies that were involved in > Chromebook development. Since Chromebooks are developed with an > "upstream first" methodology, having these revisions supported with > upstream Linux is important. Making it easy for Chromebooks to be > developed with an "upstream first" methodology is valuable to the > upstream community because it improves the quality of upstream and > gets Chromebooks supported with vanilla upstream faster. > > This patch also adds a link to the Chromebook boot flow documentation > to explain that Chromebooks don't use the scheme described for the > Qualcomm bootloader. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
On 13/05/2022 18:59, Douglas Anderson wrote: > This copy-pastes compatibles from sc7180-based boards from the device > trees to the yaml file so that `make dtbs_check` will be happy. > > NOTES: > - I make no attempt to try to share an "item" for all sc7180 based > Chromebooks. Because of the revision matching scheme used by the > Chromebook bootloader, at times we need a different number of > revisions listed. > - Some of the odd entries in here (like google,homestar-rev23 or the > fact that "Google Lazor Limozeen without Touchscreen" changed from > sku5 to sku6) are not typos but simply reflect reality. > - Many revisions of boards here never actually went to consumers, but > they are still in use within various companies that were involved in > Chromebook development. Since Chromebooks are developed with an > "upstream first" methodology, having these revisions supported with > upstream Linux is important. Making it easy for Chromebooks to be > developed with an "upstream first" methodology is valuable to the > upstream community because it improves the quality of upstream and > gets Chromebooks supported with vanilla upstream faster. > > This patch also adds a link to the Chromebook boot flow documentation > to explain that Chromebooks don't use the scheme described for the > Qualcomm bootloader. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > The link added here will (obviously) not function until the > documentation patch makes it to mainline. Presumably folks who want to > read it in the meantime can find it pretty easily. If there's a better > way to link this then please let me know. > > Changes in v2: > - Add link to doc about how Chromebook devicetrees work. > - Use a "description" instead of a comment for each item. > - Use the marketing name instead of the code name where possible. > > .../devicetree/bindings/arm/qcom.yaml | 187 +++++++++++++++++- > 1 file changed, 186 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index 5c06d1bfc046..8ec0805f4996 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -90,6 +90,11 @@ description: | > A dragonboard board v0.1 of subtype 1 with an apq8074 SoC version 2, made in > foundry 2. > > + There are many devices in the list below that run the standard ChromeOS > + bootloader setup and use the open source depthcharge bootloader to boot the > + OS. These devices do not use the scheme described above. For details, see: > + https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/chromebook-boot-flow.rst Absolute path within Linux repo, please, so "Documentation/devicetree/chromebook-boot-flow.rst" (assuming that will be the final location). There are tools which check them for validity. Actually this change should be rather part of that other commit... Best regards, Krzysztof
Hi, On Mon, May 16, 2022 at 12:01 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 13/05/2022 18:59, Douglas Anderson wrote: > > This copy-pastes compatibles from sc7180-based boards from the device > > trees to the yaml file so that `make dtbs_check` will be happy. > > > > NOTES: > > - I make no attempt to try to share an "item" for all sc7180 based > > Chromebooks. Because of the revision matching scheme used by the > > Chromebook bootloader, at times we need a different number of > > revisions listed. > > - Some of the odd entries in here (like google,homestar-rev23 or the > > fact that "Google Lazor Limozeen without Touchscreen" changed from > > sku5 to sku6) are not typos but simply reflect reality. > > - Many revisions of boards here never actually went to consumers, but > > they are still in use within various companies that were involved in > > Chromebook development. Since Chromebooks are developed with an > > "upstream first" methodology, having these revisions supported with > > upstream Linux is important. Making it easy for Chromebooks to be > > developed with an "upstream first" methodology is valuable to the > > upstream community because it improves the quality of upstream and > > gets Chromebooks supported with vanilla upstream faster. > > > > This patch also adds a link to the Chromebook boot flow documentation > > to explain that Chromebooks don't use the scheme described for the > > Qualcomm bootloader. > > > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > --- > > The link added here will (obviously) not function until the > > documentation patch makes it to mainline. Presumably folks who want to > > read it in the meantime can find it pretty easily. If there's a better > > way to link this then please let me know. > > > > Changes in v2: > > - Add link to doc about how Chromebook devicetrees work. > > - Use a "description" instead of a comment for each item. > > - Use the marketing name instead of the code name where possible. > > > > .../devicetree/bindings/arm/qcom.yaml | 187 +++++++++++++++++- > > 1 file changed, 186 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > > index 5c06d1bfc046..8ec0805f4996 100644 > > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > > @@ -90,6 +90,11 @@ description: | > > A dragonboard board v0.1 of subtype 1 with an apq8074 SoC version 2, made in > > foundry 2. > > > > + There are many devices in the list below that run the standard ChromeOS > > + bootloader setup and use the open source depthcharge bootloader to boot the > > + OS. These devices do not use the scheme described above. For details, see: > > + https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/chromebook-boot-flow.rst > > Absolute path within Linux repo, please, so > "Documentation/devicetree/chromebook-boot-flow.rst" (assuming that will > be the final location). There are tools which check them for validity. Got it, thanks! > Actually this change should be rather part of that other commit... I'm not sure I understand. Which of these are you suggesting? 1. You want me to squash the two commits into one, so we add the generic doc in the same patch as the one adding sc7180 Chromebooks. 2. You want the generic doc to come first in the series and it just adds the little blurb into "Documentation/devicetree/bindings/arm/qcom.yaml" even though Chromebooks aren't actually added until a later commit in the series. 3. You want to add the sc7180 Chromebooks first in the series with no documentation and then later add in the generic documentation and the blurb into "Documentation/devicetree/bindings/arm/qcom.yaml". I'm also interested to know if you think the generic documentation patch should land through the Qualcomm tree. I think it would absolutely have to if I take your suggestion, right? Thanks! -Doug
On 16/05/2022 17:01, Doug Anderson wrote: > > >> Actually this change should be rather part of that other commit... > > I'm not sure I understand. Which of these are you suggesting? > > 1. You want me to squash the two commits into one, so we add the > generic doc in the same patch as the one adding sc7180 Chromebooks. > > 2. You want the generic doc to come first in the series and it just > adds the little blurb into > "Documentation/devicetree/bindings/arm/qcom.yaml" even though > Chromebooks aren't actually added until a later commit in the series. > > 3. You want to add the sc7180 Chromebooks first in the series with no > documentation and then later add in the generic documentation and the > blurb into "Documentation/devicetree/bindings/arm/qcom.yaml". Sorry for being unclear, I propose the third option. I mean, the hunk referencing "chromebook-boot-flow.rst" should be rather added by the patch adding that document. > I'm also interested to know if you think the generic documentation > patch should land through the Qualcomm tree. I think it would > absolutely have to if I take your suggestion, right? Yes, in that case would be a 5th patch in the set here, so I think everything would go via Qcom SoC. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index 5c06d1bfc046..8ec0805f4996 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -90,6 +90,11 @@ description: | A dragonboard board v0.1 of subtype 1 with an apq8074 SoC version 2, made in foundry 2. + There are many devices in the list below that run the standard ChromeOS + bootloader setup and use the open source depthcharge bootloader to boot the + OS. These devices do not use the scheme described above. For details, see: + https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/chromebook-boot-flow.rst + properties: $nodename: const: "/" @@ -214,11 +219,191 @@ properties: - qcom,ipq8074-hk10-c2 - const: qcom,ipq8074 - - items: + - description: Qualcomm Technologies, Inc. SC7180 IDP + items: - enum: - qcom,sc7180-idp - const: qcom,sc7180 + - description: HP Chromebook x2 11c (rev1 - 2) + items: + - const: google,coachz-rev1 + - const: google,coachz-rev2 + - const: qcom,sc7180 + + - description: HP Chromebook x2 11c (newest rev) + items: + - const: google,coachz + - const: qcom,sc7180 + + - description: HP Chromebook x2 11c with LTE (rev1 - 2) + items: + - const: google,coachz-rev1-sku0 + - const: google,coachz-rev2-sku0 + - const: qcom,sc7180 + + - description: HP Chromebook x2 11c with LTE (newest rev) + items: + - const: google,coachz-sku0 + - const: qcom,sc7180 + + - description: Lenovo Chromebook Duet 5 13 (rev2) + items: + - const: google,homestar-rev2 + - const: google,homestar-rev23 + - const: qcom,sc7180 + + - description: Lenovo Chromebook Duet 5 13 (rev3) + items: + - const: google,homestar-rev3 + - const: qcom,sc7180 + + - description: Lenovo Chromebook Duet 5 13 (newest rev) + items: + - const: google,homestar + - const: qcom,sc7180 + + - description: Acer Chromebook Spin 513 (rev0) + items: + - const: google,lazor-rev0 + - const: qcom,sc7180 + + - description: Acer Chromebook Spin 513 (rev1 - 2) + items: + - const: google,lazor-rev1 + - const: google,lazor-rev2 + - const: qcom,sc7180 + + - description: Acer Chromebook Spin 513 (rev3 - 8) + items: + - const: google,lazor-rev3 + - const: google,lazor-rev4 + - const: google,lazor-rev5 + - const: google,lazor-rev6 + - const: google,lazor-rev7 + - const: google,lazor-rev8 + - const: qcom,sc7180 + + - description: Acer Chromebook Spin 513 (newest rev) + items: + - const: google,lazor + - const: qcom,sc7180 + + - description: Acer Chromebook Spin 513 with KB Backlight (rev1 - 2) + items: + - const: google,lazor-rev1-sku2 + - const: google,lazor-rev2-sku2 + - const: qcom,sc7180 + + - description: Acer Chromebook Spin 513 with KB Backlight (rev3 - 8) + items: + - const: google,lazor-rev3-sku2 + - const: google,lazor-rev4-sku2 + - const: google,lazor-rev5-sku2 + - const: google,lazor-rev6-sku2 + - const: google,lazor-rev7-sku2 + - const: google,lazor-rev8-sku2 + - const: qcom,sc7180 + + - description: Acer Chromebook Spin 513 with KB Backlight (newest rev) + items: + - const: google,lazor-sku2 + - const: qcom,sc7180 + + - description: Acer Chromebook Spin 513 with LTE (rev1 - 2) + items: + - const: google,lazor-rev1-sku0 + - const: google,lazor-rev2-sku0 + - const: qcom,sc7180 + + - description: Acer Chromebook Spin 513 with LTE (rev3 - 8) + items: + - const: google,lazor-rev3-sku0 + - const: google,lazor-rev4-sku0 + - const: google,lazor-rev5-sku0 + - const: google,lazor-rev6-sku0 + - const: google,lazor-rev7-sku0 + - const: google,lazor-rev8-sku0 + - const: qcom,sc7180 + + - description: Acer Chromebook Spin 513 with LTE (newest rev) + items: + - const: google,lazor-sku0 + - const: qcom,sc7180 + + - description: Acer Chromebook 511 (rev4 - rev8) + items: + - const: google,lazor-rev4-sku4 + - const: google,lazor-rev5-sku4 + - const: google,lazor-rev6-sku4 + - const: google,lazor-rev7-sku4 + - const: google,lazor-rev8-sku4 + - const: qcom,sc7180 + + - description: Acer Chromebook 511 (newest rev) + items: + - const: google,lazor-sku4 + - const: qcom,sc7180 + + - description: Acer Chromebook 511 without Touchscreen (rev4) + items: + - const: google,lazor-rev4-sku5 + - const: qcom,sc7180 + + - description: Acer Chromebook 511 without Touchscreen (rev5 - rev8) + items: + - const: google,lazor-rev5-sku5 + - const: google,lazor-rev5-sku6 + - const: google,lazor-rev6-sku6 + - const: google,lazor-rev7-sku6 + - const: google,lazor-rev8-sku6 + - const: qcom,sc7180 + + - description: Acer Chromebook 511 without Touchscreen (newest rev) + items: + - const: google,lazor-sku6 + - const: qcom,sc7180 + + - description: Sharp Dynabook Chromebook C1 (rev1) + items: + - const: google,pompom-rev1 + - const: qcom,sc7180 + + - description: Sharp Dynabook Chromebook C1 (rev2) + items: + - const: google,pompom-rev2 + - const: qcom,sc7180 + + - description: Sharp Dynabook Chromebook C1 (newest rev) + items: + - const: google,pompom + - const: qcom,sc7180 + + - description: Sharp Dynabook Chromebook C1 with LTE (rev1) + items: + - const: google,pompom-rev1-sku0 + - const: qcom,sc7180 + + - description: Sharp Dynabook Chromebook C1 with LTE (rev2) + items: + - const: google,pompom-rev2-sku0 + - const: qcom,sc7180 + + - description: Sharp Dynabook Chromebook C1 with LTE (newest rev) + items: + - const: google,pompom-sku0 + - const: qcom,sc7180 + + - description: Google Trogdor (newest rev) + items: + - const: google,trogdor + - const: qcom,sc7180 + + - description: Google Trogdor with LTE (newest rev) + items: + - const: google,trogdor-sku0 + - const: qcom,sc7180 + - items: - enum: - qcom,sc7280-crd
This copy-pastes compatibles from sc7180-based boards from the device trees to the yaml file so that `make dtbs_check` will be happy. NOTES: - I make no attempt to try to share an "item" for all sc7180 based Chromebooks. Because of the revision matching scheme used by the Chromebook bootloader, at times we need a different number of revisions listed. - Some of the odd entries in here (like google,homestar-rev23 or the fact that "Google Lazor Limozeen without Touchscreen" changed from sku5 to sku6) are not typos but simply reflect reality. - Many revisions of boards here never actually went to consumers, but they are still in use within various companies that were involved in Chromebook development. Since Chromebooks are developed with an "upstream first" methodology, having these revisions supported with upstream Linux is important. Making it easy for Chromebooks to be developed with an "upstream first" methodology is valuable to the upstream community because it improves the quality of upstream and gets Chromebooks supported with vanilla upstream faster. This patch also adds a link to the Chromebook boot flow documentation to explain that Chromebooks don't use the scheme described for the Qualcomm bootloader. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- The link added here will (obviously) not function until the documentation patch makes it to mainline. Presumably folks who want to read it in the meantime can find it pretty easily. If there's a better way to link this then please let me know. Changes in v2: - Add link to doc about how Chromebook devicetrees work. - Use a "description" instead of a comment for each item. - Use the marketing name instead of the code name where possible. .../devicetree/bindings/arm/qcom.yaml | 187 +++++++++++++++++- 1 file changed, 186 insertions(+), 1 deletion(-)