| Message ID | 20220513095722.v2.4.Ie8713bc0377672ed8dd71189e66fc0b77226fb85@changeid (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5069fe941f76c9f37abc98636a7db33a5ac72840 |
| Headers | show |
| Series | None | expand |
On Fri, May 13, 2022 at 09:59:20AM -0700, Douglas Anderson wrote: > This adds board bindings for boards that are downstream but not quite > upstream yet. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> I didn't follow the discussion about the odd sku ids (-sku1537, -sku1536, -sku1024, ...), but they match what is in the downstream tree, so it seems alright :) Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Hi, On Fri, May 13, 2022 at 1:37 PM Matthias Kaehlcke <mka@chromium.org> wrote: > > On Fri, May 13, 2022 at 09:59:20AM -0700, Douglas Anderson wrote: > > This adds board bindings for boards that are downstream but not quite > > upstream yet. > > > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > I didn't follow the discussion about the odd sku ids (-sku1537, > -sku1536, -sku1024, ...), but they match what is in the > downstream tree, so it seems alright :) It makes more sense in hex. hex(1536) = 0x600. Basically on these boards there are two sets of GPIO strappings, the normal SKU strappings and the panel strappings. Depthcharge combines them. You end up with an ugly decimal number, but it's not the end of the world. -Doug
On 13/05/2022 18:59, Douglas Anderson wrote: > This adds board bindings for boards that are downstream but not quite > upstream yet. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > Changes in v2: > - Use a "description" instead of a comment for each item. > - Use the marketing name instead of the code name where possible. These should be published with the patch adding their upstream DTS/DTSI. There is no point to list all possible boards in the world from any downstream source. For upstream there is no particular benefit for such bindings, for downstream you also said there is no. Best regards, Krzysztof
Hi, On Mon, May 16, 2022 at 12:05 AM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 13/05/2022 18:59, Douglas Anderson wrote: > > This adds board bindings for boards that are downstream but not quite > > upstream yet. > > > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > --- > > > > Changes in v2: > > - Use a "description" instead of a comment for each item. > > - Use the marketing name instead of the code name where possible. > > These should be published with the patch adding their upstream DTS/DTSI. > There is no point to list all possible boards in the world from any > downstream source. For upstream there is no particular benefit for such > bindings, for downstream you also said there is no. Joe has been working on upstreaming these boards: https://lore.kernel.org/r/20220510154406.v5.1.Id769ddc5dbf570ccb511db96da59f97d08f75a9c@changeid/ I think there is little chance that they won't go upstream at this point. However, we're at a time in the merge window where it will be several weeks before anything can land. If Joe were to include this patch as part of his series I suspect it would be much more confusing because it would add an unnecessary dependency between my series and his and make it harder for Bjorn to apply it later. Keeping the patch with my series means that the series can be applied more easily. How about: I'll add a link to his latest posting in my next version. Then, in the future (after these bindings patches have landed) then future boards can go together with their bindings. -DOug
On 16/05/2022 17:16, Doug Anderson wrote: > Hi, > > On Mon, May 16, 2022 at 12:05 AM Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org> wrote: >> >> On 13/05/2022 18:59, Douglas Anderson wrote: >>> This adds board bindings for boards that are downstream but not quite >>> upstream yet. >>> >>> Signed-off-by: Douglas Anderson <dianders@chromium.org> >>> --- >>> >>> Changes in v2: >>> - Use a "description" instead of a comment for each item. >>> - Use the marketing name instead of the code name where possible. >> >> These should be published with the patch adding their upstream DTS/DTSI. >> There is no point to list all possible boards in the world from any >> downstream source. For upstream there is no particular benefit for such >> bindings, for downstream you also said there is no. > > Joe has been working on upstreaming these boards: > > https://lore.kernel.org/r/20220510154406.v5.1.Id769ddc5dbf570ccb511db96da59f97d08f75a9c@changeid/ > > I think there is little chance that they won't go upstream at this > point. However, we're at a time in the merge window where it will be > several weeks before anything can land. If Joe were to include this > patch as part of his series I suspect it would be much more confusing > because it would add an unnecessary dependency between my series and > his and make it harder for Bjorn to apply it later. Keeping the patch > with my series means that the series can be applied more easily. > > How about: I'll add a link to his latest posting in my next version. > Then, in the future (after these bindings patches have landed) then > future boards can go together with their bindings. Sure, sounds good. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index c76ea703c2e6..6d1d44b48289 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -263,6 +263,16 @@ properties: - const: google,homestar - const: qcom,sc7180 + - description: Google Kingoftown (rev0) + items: + - const: google,kingoftown-rev0 + - const: qcom,sc7180 + + - description: Google Kingoftown (newest rev) + items: + - const: google,kingoftown + - const: qcom,sc7180 + - description: Acer Chromebook Spin 513 (rev0) items: - const: google,lazor-rev0 @@ -364,6 +374,48 @@ properties: - const: google,lazor-sku6 - const: qcom,sc7180 + - description: Google Mrbland with AUO panel (rev0) + items: + - const: google,mrbland-rev0-sku0 + - const: qcom,sc7180 + + - description: Google Mrbland with AUO panel (newest rev) + items: + - const: google,mrbland-sku1536 + - const: qcom,sc7180 + + - description: Google Mrbland with BOE panel (rev0) + items: + - const: google,mrbland-rev0-sku16 + - const: qcom,sc7180 + + - description: Google Mrbland with BOE panel (newest rev) + items: + - const: google,mrbland-sku1024 + - const: google,mrbland-sku768 + - const: qcom,sc7180 + + - description: Google Pazquel with Parade (newest rev) + items: + - const: google,pazquel-sku5 + - const: qcom,sc7180 + + - description: Google Pazquel with TI (newest rev) + items: + - const: google,pazquel-sku1 + - const: qcom,sc7180 + + - description: Google Pazquel with LTE and Parade (newest rev) + items: + - const: google,pazquel-sku4 + - const: qcom,sc7180 + + - description: Google Pazquel with LTE and TI (newest rev) + items: + - const: google,pazquel-sku0 + - const: google,pazquel-sku2 + - const: qcom,sc7180 + - description: Sharp Dynabook Chromebook C1 (rev1) items: - const: google,pompom-rev1 @@ -394,6 +446,16 @@ properties: - const: google,pompom-sku0 - const: qcom,sc7180 + - description: Google Quackingstick (newest rev) + items: + - const: google,quackingstick-sku1537 + - const: qcom,sc7180 + + - description: Google Quackingstick with LTE (newest rev) + items: + - const: google,quackingstick-sku1536 + - const: qcom,sc7180 + - description: Google Trogdor (newest rev) items: - const: google,trogdor @@ -404,6 +466,36 @@ properties: - const: google,trogdor-sku0 - const: qcom,sc7180 + - description: Lenovo IdeaPad Chromebook Duet 3 with BOE panel (rev0) + items: + - const: google,wormdingler-rev0-sku16 + - const: qcom,sc7180 + + - description: Lenovo IdeaPad Chromebook Duet 3 with BOE panel (newest rev) + items: + - const: google,wormdingler-sku1024 + - const: qcom,sc7180 + + - description: Lenovo IdeaPad Chromebook Duet 3 with BOE panel and rt5682s (newest rev) + items: + - const: google,wormdingler-sku1025 + - const: qcom,sc7180 + + - description: Lenovo IdeaPad Chromebook Duet 3 with INX panel (rev0) + items: + - const: google,wormdingler-rev0-sku0 + - const: qcom,sc7180 + + - description: Lenovo IdeaPad Chromebook Duet 3 with INX panel (newest rev) + items: + - const: google,wormdingler-sku0 + - const: qcom,sc7180 + + - description: Lenovo IdeaPad Chromebook Duet 3 with INX panel and rt5682s (newest rev) + items: + - const: google,wormdingler-sku1 + - const: qcom,sc7180 + - description: Qualcomm Technologies, Inc. sc7280 CRD platform (rev3 - 4) items: - const: qcom,sc7280-crd
This adds board bindings for boards that are downstream but not quite upstream yet. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- Changes in v2: - Use a "description" instead of a comment for each item. - Use the marketing name instead of the code name where possible. .../devicetree/bindings/arm/qcom.yaml | 92 +++++++++++++++++++ 1 file changed, 92 insertions(+)