| Message ID | 20220513221458.1192933-1-atishp@rivosinc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/intc: Pass correct hartid while updating mtimecmp | expand |
Reviewed-by: Frank Chang <frank.chang@sifive.com> On Sat, May 14, 2022 at 6:15 AM Atish Patra <atishp@rivosinc.com> wrote: > timecmp update function should be invoked with hartid for which > timecmp is being updated. The following patch passes the incorrect > hartid to the update function. > > Fixes: e2f01f3c2e13 ("hw/intc: Make RISC-V ACLINT mtime MMIO register > writable") > > Signed-off-by: Atish Patra <atishp@rivosinc.com> > --- > hw/intc/riscv_aclint.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/intc/riscv_aclint.c b/hw/intc/riscv_aclint.c > index 0412edc98257..e6bceceefdbc 100644 > --- a/hw/intc/riscv_aclint.c > +++ b/hw/intc/riscv_aclint.c > @@ -233,7 +233,8 @@ static void riscv_aclint_mtimer_write(void *opaque, > hwaddr addr, > continue; > } > riscv_aclint_mtimer_write_timecmp(mtimer, RISCV_CPU(cpu), > - i, env->timecmp); > + mtimer->hartid_base + i, > + env->timecmp); > } > return; > } > -- > 2.25.1 > >
On Sat, May 14, 2022 at 3:45 AM Atish Patra <atishp@rivosinc.com> wrote: > > timecmp update function should be invoked with hartid for which > timecmp is being updated. The following patch passes the incorrect > hartid to the update function. > > Fixes: e2f01f3c2e13 ("hw/intc: Make RISC-V ACLINT mtime MMIO register writable") > > Signed-off-by: Atish Patra <atishp@rivosinc.com> Looks good to me. Reviewed-by: Anup Patel <anup@brainfault.org> Regards, Anup > --- > hw/intc/riscv_aclint.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/intc/riscv_aclint.c b/hw/intc/riscv_aclint.c > index 0412edc98257..e6bceceefdbc 100644 > --- a/hw/intc/riscv_aclint.c > +++ b/hw/intc/riscv_aclint.c > @@ -233,7 +233,8 @@ static void riscv_aclint_mtimer_write(void *opaque, hwaddr addr, > continue; > } > riscv_aclint_mtimer_write_timecmp(mtimer, RISCV_CPU(cpu), > - i, env->timecmp); > + mtimer->hartid_base + i, > + env->timecmp); > } > return; > } > -- > 2.25.1 > >
On Sat, May 14, 2022 at 8:15 AM Atish Patra <atishp@rivosinc.com> wrote: > > timecmp update function should be invoked with hartid for which > timecmp is being updated. The following patch passes the incorrect > hartid to the update function. > > Fixes: e2f01f3c2e13 ("hw/intc: Make RISC-V ACLINT mtime MMIO register writable") > > Signed-off-by: Atish Patra <atishp@rivosinc.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > --- > hw/intc/riscv_aclint.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/intc/riscv_aclint.c b/hw/intc/riscv_aclint.c > index 0412edc98257..e6bceceefdbc 100644 > --- a/hw/intc/riscv_aclint.c > +++ b/hw/intc/riscv_aclint.c > @@ -233,7 +233,8 @@ static void riscv_aclint_mtimer_write(void *opaque, hwaddr addr, > continue; > } > riscv_aclint_mtimer_write_timecmp(mtimer, RISCV_CPU(cpu), > - i, env->timecmp); > + mtimer->hartid_base + i, > + env->timecmp); > } > return; > } > -- > 2.25.1 > >
On Sat, May 14, 2022 at 8:15 AM Atish Patra <atishp@rivosinc.com> wrote: > > timecmp update function should be invoked with hartid for which > timecmp is being updated. The following patch passes the incorrect > hartid to the update function. > > Fixes: e2f01f3c2e13 ("hw/intc: Make RISC-V ACLINT mtime MMIO register writable") > > Signed-off-by: Atish Patra <atishp@rivosinc.com> Thanks! Applied to riscv-to-apply.next Alistair > --- > hw/intc/riscv_aclint.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/intc/riscv_aclint.c b/hw/intc/riscv_aclint.c > index 0412edc98257..e6bceceefdbc 100644 > --- a/hw/intc/riscv_aclint.c > +++ b/hw/intc/riscv_aclint.c > @@ -233,7 +233,8 @@ static void riscv_aclint_mtimer_write(void *opaque, hwaddr addr, > continue; > } > riscv_aclint_mtimer_write_timecmp(mtimer, RISCV_CPU(cpu), > - i, env->timecmp); > + mtimer->hartid_base + i, > + env->timecmp); > } > return; > } > -- > 2.25.1 > >
diff --git a/hw/intc/riscv_aclint.c b/hw/intc/riscv_aclint.c index 0412edc98257..e6bceceefdbc 100644 --- a/hw/intc/riscv_aclint.c +++ b/hw/intc/riscv_aclint.c @@ -233,7 +233,8 @@ static void riscv_aclint_mtimer_write(void *opaque, hwaddr addr, continue; } riscv_aclint_mtimer_write_timecmp(mtimer, RISCV_CPU(cpu), - i, env->timecmp); + mtimer->hartid_base + i, + env->timecmp); } return; }
timecmp update function should be invoked with hartid for which timecmp is being updated. The following patch passes the incorrect hartid to the update function. Fixes: e2f01f3c2e13 ("hw/intc: Make RISC-V ACLINT mtime MMIO register writable") Signed-off-by: Atish Patra <atishp@rivosinc.com> --- hw/intc/riscv_aclint.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)