| Message ID | 20220429164325.1.I2a3b980ea051e59140227999f0f0ca16f1125768@changeid (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | device property: Fix recent breakage of fwnode_get_next_parent_dev() | expand |
On Fri, Apr 29, 2022 at 4:43 PM Douglas Anderson <dianders@chromium.org> wrote: > > Due to a subtle typo, instead of commit 87ffea09470d ("device > property: Introduce fwnode_for_each_parent_node()") being a no-op > change, it ended up causing the display on my sc7180-trogdor-lazor > device from coming up unless I added "fw_devlink=off" to my kernel > command line. Fix the typo. Thank you for the fix! Reviewed-by: Saravana Kannan <saravanak@google.com> -Saravana > > Fixes: 87ffea09470d ("device property: Introduce fwnode_for_each_parent_node()") > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > drivers/base/property.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/base/property.c b/drivers/base/property.c > index 36401cfe432c..52e85dcb20b5 100644 > --- a/drivers/base/property.c > +++ b/drivers/base/property.c > @@ -600,7 +600,7 @@ struct device *fwnode_get_next_parent_dev(struct fwnode_handle *fwnode) > struct device *dev; > > fwnode_for_each_parent_node(fwnode, parent) { > - dev = get_dev_from_fwnode(fwnode); > + dev = get_dev_from_fwnode(parent); > if (dev) { > fwnode_handle_put(parent); > return dev; > -- > 2.36.0.464.gb9c8b46e94-goog >
On Fri, Apr 29, 2022 at 04:43:47PM -0700, Douglas Anderson wrote: > Due to a subtle typo, instead of commit 87ffea09470d ("device > property: Introduce fwnode_for_each_parent_node()") being a no-op > change, it ended up causing the display on my sc7180-trogdor-lazor > device from coming up unless I added "fw_devlink=off" to my kernel > command line. Fix the typo. > > Fixes: 87ffea09470d ("device property: Introduce fwnode_for_each_parent_node()") > Signed-off-by: Douglas Anderson <dianders@chromium.org> Good catch, thanks! Reviewed-by: Sakari Ailus <sakari.ailus@linux.intel.com> > --- > > drivers/base/property.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/base/property.c b/drivers/base/property.c > index 36401cfe432c..52e85dcb20b5 100644 > --- a/drivers/base/property.c > +++ b/drivers/base/property.c > @@ -600,7 +600,7 @@ struct device *fwnode_get_next_parent_dev(struct fwnode_handle *fwnode) > struct device *dev; > > fwnode_for_each_parent_node(fwnode, parent) { > - dev = get_dev_from_fwnode(fwnode); > + dev = get_dev_from_fwnode(parent); > if (dev) { > fwnode_handle_put(parent); > return dev;
On Sat, Apr 30, 2022 at 3:00 PM Douglas Anderson <dianders@chromium.org> wrote: > > Due to a subtle typo, instead of commit 87ffea09470d ("device > property: Introduce fwnode_for_each_parent_node()") being a no-op > change, it ended up causing the display on my sc7180-trogdor-lazor > device from coming up unless I added "fw_devlink=off" to my kernel > command line. Fix the typo. Sorry and merci pour la fix! Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > Fixes: 87ffea09470d ("device property: Introduce fwnode_for_each_parent_node()") > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > drivers/base/property.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/base/property.c b/drivers/base/property.c > index 36401cfe432c..52e85dcb20b5 100644 > --- a/drivers/base/property.c > +++ b/drivers/base/property.c > @@ -600,7 +600,7 @@ struct device *fwnode_get_next_parent_dev(struct fwnode_handle *fwnode) > struct device *dev; > > fwnode_for_each_parent_node(fwnode, parent) { > - dev = get_dev_from_fwnode(fwnode); > + dev = get_dev_from_fwnode(parent); > if (dev) { > fwnode_handle_put(parent); > return dev; > -- > 2.36.0.464.gb9c8b46e94-goog >
On Sun, May 1, 2022 at 9:50 AM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Sat, Apr 30, 2022 at 3:00 PM Douglas Anderson <dianders@chromium.org> wrote: > > > > Due to a subtle typo, instead of commit 87ffea09470d ("device > > property: Introduce fwnode_for_each_parent_node()") being a no-op > > change, it ended up causing the display on my sc7180-trogdor-lazor > > device from coming up unless I added "fw_devlink=off" to my kernel > > command line. Fix the typo. > > Sorry and merci pour la fix! > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> Applied, thanks! > > Fixes: 87ffea09470d ("device property: Introduce fwnode_for_each_parent_node()") > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > > --- > > > > drivers/base/property.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/base/property.c b/drivers/base/property.c > > index 36401cfe432c..52e85dcb20b5 100644 > > --- a/drivers/base/property.c > > +++ b/drivers/base/property.c > > @@ -600,7 +600,7 @@ struct device *fwnode_get_next_parent_dev(struct fwnode_handle *fwnode) > > struct device *dev; > > > > fwnode_for_each_parent_node(fwnode, parent) { > > - dev = get_dev_from_fwnode(fwnode); > > + dev = get_dev_from_fwnode(parent); > > if (dev) { > > fwnode_handle_put(parent); > > return dev; > > -- > > 2.36.0.464.gb9c8b46e94-goog > > > > > -- > With Best Regards, > Andy Shevchenko
On Thu, May 5, 2022 at 5:21 AM Rafael J. Wysocki <rafael@kernel.org> wrote: > > On Sun, May 1, 2022 at 9:50 AM Andy Shevchenko > <andy.shevchenko@gmail.com> wrote: > > > > On Sat, Apr 30, 2022 at 3:00 PM Douglas Anderson <dianders@chromium.org> wrote: > > > > > > Due to a subtle typo, instead of commit 87ffea09470d ("device > > > property: Introduce fwnode_for_each_parent_node()") being a no-op > > > change, it ended up causing the display on my sc7180-trogdor-lazor > > > device from coming up unless I added "fw_devlink=off" to my kernel > > > command line. Fix the typo. > > > > Sorry and merci pour la fix! > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > > Applied, thanks! Has this been picked up by one of the driver-core branches yet? I was poking around that git repo and didn't see any commit with this title. This breaks fw_devlink in a severe manner, so I want to make sure it gets into 5.18. -Saravana -Saravana
On Fri, May 13, 2022 at 08:58:12PM -0700, Saravana Kannan wrote: > On Thu, May 5, 2022 at 5:21 AM Rafael J. Wysocki <rafael@kernel.org> wrote: > > > > On Sun, May 1, 2022 at 9:50 AM Andy Shevchenko > > <andy.shevchenko@gmail.com> wrote: > > > > > > On Sat, Apr 30, 2022 at 3:00 PM Douglas Anderson <dianders@chromium.org> wrote: > > > > > > > > Due to a subtle typo, instead of commit 87ffea09470d ("device > > > > property: Introduce fwnode_for_each_parent_node()") being a no-op > > > > change, it ended up causing the display on my sc7180-trogdor-lazor > > > > device from coming up unless I added "fw_devlink=off" to my kernel > > > > command line. Fix the typo. > > > > > > Sorry and merci pour la fix! > > > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > > > > Applied, thanks! > > Has this been picked up by one of the driver-core branches yet? I was > poking around that > git repo and didn't see any commit with this title. This breaks > fw_devlink in a severe manner, so I want to make sure it gets into > 5.18. Look in linux-next: 117ef574074d ("device property: Fix recent breakage of fwnode_get_next_parent_dev()") Rafael's tree is not my tree :) thanks, greg k-h
diff --git a/drivers/base/property.c b/drivers/base/property.c index 36401cfe432c..52e85dcb20b5 100644 --- a/drivers/base/property.c +++ b/drivers/base/property.c @@ -600,7 +600,7 @@ struct device *fwnode_get_next_parent_dev(struct fwnode_handle *fwnode) struct device *dev; fwnode_for_each_parent_node(fwnode, parent) { - dev = get_dev_from_fwnode(fwnode); + dev = get_dev_from_fwnode(parent); if (dev) { fwnode_handle_put(parent); return dev;
Due to a subtle typo, instead of commit 87ffea09470d ("device property: Introduce fwnode_for_each_parent_node()") being a no-op change, it ended up causing the display on my sc7180-trogdor-lazor device from coming up unless I added "fw_devlink=off" to my kernel command line. Fix the typo. Fixes: 87ffea09470d ("device property: Introduce fwnode_for_each_parent_node()") Signed-off-by: Douglas Anderson <dianders@chromium.org> --- drivers/base/property.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)