| Message ID | 20220509072405.1118019-1-lv.ruyi@zte.com.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | iio: adc: fix return error variable | expand |
On 5/9/22 09:24, cgel.zte@gmail.com wrote: > From: Lv Ruyi <lv.ruyi@zte.com.cn> > > Return irq instead of ret which always equals to zero here. > > Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver") > Reported-by: Zeal Robot <zealci@zte.com.cn> > Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn> > --- > drivers/iio/adc/xilinx-ams.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c > index a55396c1f8b2..a7687706012d 100644 > --- a/drivers/iio/adc/xilinx-ams.c > +++ b/drivers/iio/adc/xilinx-ams.c > @@ -1409,7 +1409,7 @@ static int ams_probe(struct platform_device *pdev) > > irq = platform_get_irq(pdev, 0); > if (irq < 0) > - return ret; > + return irq; > > ret = devm_request_irq(&pdev->dev, irq, &ams_irq, 0, "ams-irq", > indio_dev); Reviewed-by: Michal Simek <michal.simek@amd.com> Thanks, Michal
On Mon, 9 May 2022 09:34:57 +0200 Michal Simek <michal.simek@xilinx.com> wrote: > On 5/9/22 09:24, cgel.zte@gmail.com wrote: > > From: Lv Ruyi <lv.ruyi@zte.com.cn> Applied, with modified patch title. There are a lot of ADC drivers so you should include the name of the driver in the patch description. iio: adc: xilinx-ams: fix return error variable > > > > Return irq instead of ret which always equals to zero here. > > > > Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver") > > Reported-by: Zeal Robot <zealci@zte.com.cn> > > Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn> > > --- > > drivers/iio/adc/xilinx-ams.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c > > index a55396c1f8b2..a7687706012d 100644 > > --- a/drivers/iio/adc/xilinx-ams.c > > +++ b/drivers/iio/adc/xilinx-ams.c > > @@ -1409,7 +1409,7 @@ static int ams_probe(struct platform_device *pdev) > > > > irq = platform_get_irq(pdev, 0); > > if (irq < 0) > > - return ret; > > + return irq; > > > > ret = devm_request_irq(&pdev->dev, irq, &ams_irq, 0, "ams-irq", > > indio_dev); > > Reviewed-by: Michal Simek <michal.simek@amd.com> > > Thanks, > Michal
diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c index a55396c1f8b2..a7687706012d 100644 --- a/drivers/iio/adc/xilinx-ams.c +++ b/drivers/iio/adc/xilinx-ams.c @@ -1409,7 +1409,7 @@ static int ams_probe(struct platform_device *pdev) irq = platform_get_irq(pdev, 0); if (irq < 0) - return ret; + return irq; ret = devm_request_irq(&pdev->dev, irq, &ams_irq, 0, "ams-irq", indio_dev);