mbox series

[v2,0/7] platform/chrome: get rid of BUG_ON()

Message ID 20220513044143.1045728-1-tzungbi@kernel.org (mailing list archive)
Headers show
Series platform/chrome: get rid of BUG_ON() | expand

Message

Tzung-Bi Shih May 13, 2022, 4:41 a.m. UTC
The series gets rid of BUG_ON()s in drivers/platform/chrome/.  Most of them
can be replaced by returning proper return code.

The 2nd patch makes callers of cros_ec_prepare_tx() to take care of the
return code.

The 3rd patch turns cros_ec_prepare_tx() to return error code if any.

Changes from v1:
(https://patchwork.kernel.org/project/chrome-platform/cover/20220512083627.885338-1-tzungbi@kernel.org/)
- Split the original 6th patch into 2 smaller patches. 

Tzung-Bi Shih (7):
  platform/chrome: cros_ec_proto: drop unneeded BUG_ON() in
    prepare_packet()
  platform/chrome: correct cros_ec_prepare_tx() usage
  platform/chrome: cros_ec_proto: drop BUG_ON() in cros_ec_prepare_tx()
  platform/chrome: cros_ec_proto: drop BUG_ON() in
    cros_ec_get_host_event()
  platform/chrome: cros_ec_i2c: drop BUG_ON() in cros_ec_pkt_xfer_i2c()
  platform/chrome: cros_ec_spi: drop unneeded BUG_ON()
  platform/chrome: cros_ec_spi: drop BUG_ON() if `din` isn't large
    enough

 drivers/platform/chrome/cros_ec_i2c.c   | 12 ++++++++++--
 drivers/platform/chrome/cros_ec_ishtp.c |  4 +++-
 drivers/platform/chrome/cros_ec_lpc.c   |  2 ++
 drivers/platform/chrome/cros_ec_proto.c | 13 ++++++++-----
 drivers/platform/chrome/cros_ec_rpmsg.c |  2 ++
 drivers/platform/chrome/cros_ec_spi.c   | 15 ++++++++++-----
 6 files changed, 35 insertions(+), 13 deletions(-)

Comments

patchwork-bot+chrome-platform@kernel.org May 16, 2022, 2:10 a.m. UTC | #1
Hello:

This series was applied to chrome-platform/linux.git (for-kernelci)
by Tzung-Bi Shih <tzungbi@kernel.org>:

On Fri, 13 May 2022 12:41:36 +0800 you wrote:
> The series gets rid of BUG_ON()s in drivers/platform/chrome/.  Most of them
> can be replaced by returning proper return code.
> 
> The 2nd patch makes callers of cros_ec_prepare_tx() to take care of the
> return code.
> 
> The 3rd patch turns cros_ec_prepare_tx() to return error code if any.
> 
> [...]

Here is the summary with links:
  - [v2,1/7] platform/chrome: cros_ec_proto: drop unneeded BUG_ON() in prepare_packet()
    https://git.kernel.org/chrome-platform/c/42701e7c0cd2
  - [v2,2/7] platform/chrome: correct cros_ec_prepare_tx() usage
    https://git.kernel.org/chrome-platform/c/71d3ae7fb640
  - [v2,3/7] platform/chrome: cros_ec_proto: drop BUG_ON() in cros_ec_prepare_tx()
    https://git.kernel.org/chrome-platform/c/c2dcb1b06053
  - [v2,4/7] platform/chrome: cros_ec_proto: drop BUG_ON() in cros_ec_get_host_event()
    https://git.kernel.org/chrome-platform/c/20a264c97bc8
  - [v2,5/7] platform/chrome: cros_ec_i2c: drop BUG_ON() in cros_ec_pkt_xfer_i2c()
    https://git.kernel.org/chrome-platform/c/8bff946c4199
  - [v2,6/7] platform/chrome: cros_ec_spi: drop unneeded BUG_ON()
    https://git.kernel.org/chrome-platform/c/ddec8e9e90ce
  - [v2,7/7] platform/chrome: cros_ec_spi: drop BUG_ON() if `din` isn't large enough
    https://git.kernel.org/chrome-platform/c/bbd43a37ec7a

You are awesome, thank you!
patchwork-bot+chrome-platform@kernel.org May 18, 2022, 5:20 a.m. UTC | #2
Hello:

This series was applied to chrome-platform/linux.git (for-next)
by Tzung-Bi Shih <tzungbi@kernel.org>:

On Fri, 13 May 2022 12:41:36 +0800 you wrote:
> The series gets rid of BUG_ON()s in drivers/platform/chrome/.  Most of them
> can be replaced by returning proper return code.
> 
> The 2nd patch makes callers of cros_ec_prepare_tx() to take care of the
> return code.
> 
> The 3rd patch turns cros_ec_prepare_tx() to return error code if any.
> 
> [...]

Here is the summary with links:
  - [v2,1/7] platform/chrome: cros_ec_proto: drop unneeded BUG_ON() in prepare_packet()
    https://git.kernel.org/chrome-platform/c/42701e7c0cd2
  - [v2,2/7] platform/chrome: correct cros_ec_prepare_tx() usage
    https://git.kernel.org/chrome-platform/c/71d3ae7fb640
  - [v2,3/7] platform/chrome: cros_ec_proto: drop BUG_ON() in cros_ec_prepare_tx()
    https://git.kernel.org/chrome-platform/c/c2dcb1b06053
  - [v2,4/7] platform/chrome: cros_ec_proto: drop BUG_ON() in cros_ec_get_host_event()
    https://git.kernel.org/chrome-platform/c/20a264c97bc8
  - [v2,5/7] platform/chrome: cros_ec_i2c: drop BUG_ON() in cros_ec_pkt_xfer_i2c()
    https://git.kernel.org/chrome-platform/c/8bff946c4199
  - [v2,6/7] platform/chrome: cros_ec_spi: drop unneeded BUG_ON()
    https://git.kernel.org/chrome-platform/c/ddec8e9e90ce
  - [v2,7/7] platform/chrome: cros_ec_spi: drop BUG_ON() if `din` isn't large enough
    https://git.kernel.org/chrome-platform/c/bbd43a37ec7a

You are awesome, thank you!