diff mbox series

[2/2] Re-run BLC when gain change

Message ID 20220308033839.3773-2-arec.kao@intel.com (mailing list archive)
State New, archived
Headers show
Series [1/2] Add a V4L2 control to allow configuring BLC from userspace. | expand

Commit Message

Arec Kao March 8, 2022, 3:38 a.m. UTC
Changing the gain affects the black-level through the device;
the gain should therefore not be changed during a BLC procedure.
If the gain changes, then the BLC routine should be re-run
in some scenarios.

Signed-off-by: Arec Kao <arec.kao@intel.com>
---
 .../userspace-api/media/v4l/ext-ctrls-image-source.rst       | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Laurent Pinchart March 8, 2022, 12:13 p.m. UTC | #1
Hi Arec,

Thank you for the patch.

On Tue, Mar 08, 2022 at 11:38:39AM +0800, Arec Kao wrote:
> Changing the gain affects the black-level through the device;
> the gain should therefore not be changed during a BLC procedure.
> If the gain changes, then the BLC routine should be re-run
> in some scenarios.
> 
> Signed-off-by: Arec Kao <arec.kao@intel.com>
> ---
>  .../userspace-api/media/v4l/ext-ctrls-image-source.rst       | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-image-source.rst b/Documentation/userspace-api/media/v4l/ext-ctrls-image-source.rst
> index 71f23f131f97..5ee53ba76d46 100644
> --- a/Documentation/userspace-api/media/v4l/ext-ctrls-image-source.rst
> +++ b/Documentation/userspace-api/media/v4l/ext-ctrls-image-source.rst
> @@ -59,6 +59,11 @@ Image Source Control IDs
>      non-sensitive.
>      This control is required for automatic calibration of sensors/cameras.
>  
> +``V4L2_CID_BLC (integer)``
> +    Changing the gain affects the black-level through the device; the gain
> +    should therefore not be changed during a BLC procedure. If the gain
> +    changes, the BLC routine should be re-run in some scenarios.

This doesn't tell me what the control does.

> +
>  .. c:type:: v4l2_area
>  
>  .. flat-table:: struct v4l2_area
Sakari Ailus March 8, 2022, 12:48 p.m. UTC | #2
Hi Arec,

Thanks for the patch.

On Tue, Mar 08, 2022 at 11:38:39AM +0800, Arec Kao wrote:
> Changing the gain affects the black-level through the device;
> the gain should therefore not be changed during a BLC procedure.
> If the gain changes, then the BLC routine should be re-run
> in some scenarios.

Could you also explain what are the scenarios the BLC routine should be
re-run and how does the user space know this should be done? Could this be
done in the driver instead without involving the user space?
Tomasz Figa May 16, 2022, 9:15 a.m. UTC | #3
On Tue, Mar 8, 2022 at 9:48 PM Sakari Ailus
<sakari.ailus@linux.intel.com> wrote:
>
> Hi Arec,
>
> Thanks for the patch.
>
> On Tue, Mar 08, 2022 at 11:38:39AM +0800, Arec Kao wrote:
> > Changing the gain affects the black-level through the device;
> > the gain should therefore not be changed during a BLC procedure.
> > If the gain changes, then the BLC routine should be re-run
> > in some scenarios.
>
> Could you also explain what are the scenarios the BLC routine should be
> re-run and how does the user space know this should be done? Could this be
> done in the driver instead without involving the user space?

FWIW, this turned out to be a camera module design issue (the
investigation was running in parallel to the potential software fix),
so this patch series isn't needed anymore.

Best regards,
Tomasz
diff mbox series

Patch

diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-image-source.rst b/Documentation/userspace-api/media/v4l/ext-ctrls-image-source.rst
index 71f23f131f97..5ee53ba76d46 100644
--- a/Documentation/userspace-api/media/v4l/ext-ctrls-image-source.rst
+++ b/Documentation/userspace-api/media/v4l/ext-ctrls-image-source.rst
@@ -59,6 +59,11 @@  Image Source Control IDs
     non-sensitive.
     This control is required for automatic calibration of sensors/cameras.
 
+``V4L2_CID_BLC (integer)``
+    Changing the gain affects the black-level through the device; the gain
+    should therefore not be changed during a BLC procedure. If the gain
+    changes, the BLC routine should be re-run in some scenarios.
+
 .. c:type:: v4l2_area
 
 .. flat-table:: struct v4l2_area