| Message ID | 20220511130455.22028-1-anshuman.gupta@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915: Use drm_dbg for rpm logging | expand |
On Wed, 11 May 2022 06:04:54 -0700, Anshuman Gupta wrote: > > RPM suspend/resume also supported on gfx platforms which doesn't have > kms support and even on platforms without any connected display panel. > There is no good reason to log rpm suspend/resume debug message with > drm_dbg_kms() therefore changing it to drm_dbg(). Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com> > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> > --- > drivers/gpu/drm/i915/i915_driver.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c > index 90b0ce5051af..ed6028fd442d 100644 > --- a/drivers/gpu/drm/i915/i915_driver.c > +++ b/drivers/gpu/drm/i915/i915_driver.c > @@ -1549,7 +1549,7 @@ static int intel_runtime_suspend(struct device *kdev) > if (drm_WARN_ON_ONCE(&dev_priv->drm, !HAS_RUNTIME_PM(dev_priv))) > return -ENODEV; > > - drm_dbg_kms(&dev_priv->drm, "Suspending device\n"); > + drm_dbg(&dev_priv->drm, "Suspending device\n"); > > disable_rpm_wakeref_asserts(rpm); > > @@ -1625,7 +1625,7 @@ static int intel_runtime_suspend(struct device *kdev) > if (!IS_VALLEYVIEW(dev_priv) && !IS_CHERRYVIEW(dev_priv)) > intel_hpd_poll_enable(dev_priv); > > - drm_dbg_kms(&dev_priv->drm, "Device suspended\n"); > + drm_dbg(&dev_priv->drm, "Device suspended\n"); > return 0; > } > > @@ -1639,7 +1639,7 @@ static int intel_runtime_resume(struct device *kdev) > if (drm_WARN_ON_ONCE(&dev_priv->drm, !HAS_RUNTIME_PM(dev_priv))) > return -ENODEV; > > - drm_dbg_kms(&dev_priv->drm, "Resuming device\n"); > + drm_dbg(&dev_priv->drm, "Resuming device\n"); > > drm_WARN_ON_ONCE(&dev_priv->drm, atomic_read(&rpm->wakeref_count)); > disable_rpm_wakeref_asserts(rpm); > @@ -1683,7 +1683,7 @@ static int intel_runtime_resume(struct device *kdev) > drm_err(&dev_priv->drm, > "Runtime resume failed, disabling it (%d)\n", ret); > else > - drm_dbg_kms(&dev_priv->drm, "Device resumed\n"); > + drm_dbg(&dev_priv->drm, "Device resumed\n"); > > return ret; > } > -- > 2.26.2 >
> -----Original Message----- > From: Dixit, Ashutosh <ashutosh.dixit@intel.com> > Sent: Thursday, May 12, 2022 9:47 AM > To: Gupta, Anshuman <anshuman.gupta@intel.com> > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915: Use drm_dbg for rpm logging > > On Wed, 11 May 2022 06:04:54 -0700, Anshuman Gupta wrote: > > > > RPM suspend/resume also supported on gfx platforms which doesn't have > > kms support and even on platforms without any connected display panel. > > There is no good reason to log rpm suspend/resume debug message with > > drm_dbg_kms() therefore changing it to drm_dbg(). > > Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com> Thanks for review pushed to drm-intel-next. Br, Anshuman. > > > Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> > > --- > > drivers/gpu/drm/i915/i915_driver.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_driver.c > > b/drivers/gpu/drm/i915/i915_driver.c > > index 90b0ce5051af..ed6028fd442d 100644 > > --- a/drivers/gpu/drm/i915/i915_driver.c > > +++ b/drivers/gpu/drm/i915/i915_driver.c > > @@ -1549,7 +1549,7 @@ static int intel_runtime_suspend(struct device > *kdev) > > if (drm_WARN_ON_ONCE(&dev_priv->drm, > !HAS_RUNTIME_PM(dev_priv))) > > return -ENODEV; > > > > - drm_dbg_kms(&dev_priv->drm, "Suspending device\n"); > > + drm_dbg(&dev_priv->drm, "Suspending device\n"); > > > > disable_rpm_wakeref_asserts(rpm); > > > > @@ -1625,7 +1625,7 @@ static int intel_runtime_suspend(struct device > *kdev) > > if (!IS_VALLEYVIEW(dev_priv) && !IS_CHERRYVIEW(dev_priv)) > > intel_hpd_poll_enable(dev_priv); > > > > - drm_dbg_kms(&dev_priv->drm, "Device suspended\n"); > > + drm_dbg(&dev_priv->drm, "Device suspended\n"); > > return 0; > > } > > > > @@ -1639,7 +1639,7 @@ static int intel_runtime_resume(struct device *kdev) > > if (drm_WARN_ON_ONCE(&dev_priv->drm, > !HAS_RUNTIME_PM(dev_priv))) > > return -ENODEV; > > > > - drm_dbg_kms(&dev_priv->drm, "Resuming device\n"); > > + drm_dbg(&dev_priv->drm, "Resuming device\n"); > > > > drm_WARN_ON_ONCE(&dev_priv->drm, atomic_read(&rpm- > >wakeref_count)); > > disable_rpm_wakeref_asserts(rpm); > > @@ -1683,7 +1683,7 @@ static int intel_runtime_resume(struct device *kdev) > > drm_err(&dev_priv->drm, > > "Runtime resume failed, disabling it (%d)\n", ret); > > else > > - drm_dbg_kms(&dev_priv->drm, "Device resumed\n"); > > + drm_dbg(&dev_priv->drm, "Device resumed\n"); > > > > return ret; > > } > > -- > > 2.26.2 > >
diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c index 90b0ce5051af..ed6028fd442d 100644 --- a/drivers/gpu/drm/i915/i915_driver.c +++ b/drivers/gpu/drm/i915/i915_driver.c @@ -1549,7 +1549,7 @@ static int intel_runtime_suspend(struct device *kdev) if (drm_WARN_ON_ONCE(&dev_priv->drm, !HAS_RUNTIME_PM(dev_priv))) return -ENODEV; - drm_dbg_kms(&dev_priv->drm, "Suspending device\n"); + drm_dbg(&dev_priv->drm, "Suspending device\n"); disable_rpm_wakeref_asserts(rpm); @@ -1625,7 +1625,7 @@ static int intel_runtime_suspend(struct device *kdev) if (!IS_VALLEYVIEW(dev_priv) && !IS_CHERRYVIEW(dev_priv)) intel_hpd_poll_enable(dev_priv); - drm_dbg_kms(&dev_priv->drm, "Device suspended\n"); + drm_dbg(&dev_priv->drm, "Device suspended\n"); return 0; } @@ -1639,7 +1639,7 @@ static int intel_runtime_resume(struct device *kdev) if (drm_WARN_ON_ONCE(&dev_priv->drm, !HAS_RUNTIME_PM(dev_priv))) return -ENODEV; - drm_dbg_kms(&dev_priv->drm, "Resuming device\n"); + drm_dbg(&dev_priv->drm, "Resuming device\n"); drm_WARN_ON_ONCE(&dev_priv->drm, atomic_read(&rpm->wakeref_count)); disable_rpm_wakeref_asserts(rpm); @@ -1683,7 +1683,7 @@ static int intel_runtime_resume(struct device *kdev) drm_err(&dev_priv->drm, "Runtime resume failed, disabling it (%d)\n", ret); else - drm_dbg_kms(&dev_priv->drm, "Device resumed\n"); + drm_dbg(&dev_priv->drm, "Device resumed\n"); return ret; }
RPM suspend/resume also supported on gfx platforms which doesn't have kms support and even on platforms without any connected display panel. There is no good reason to log rpm suspend/resume debug message with drm_dbg_kms() therefore changing it to drm_dbg(). Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com> --- drivers/gpu/drm/i915/i915_driver.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)