diff mbox series

[1/2] dt-bindings: remoteproc: pru: Update bindings for K3 AM62x SoCs

Message ID 20220427083509.14458-2-kishon@ti.com (mailing list archive)
State Superseded
Headers show
Series remoteproc: pru: Enable PRU cores on K3 AM62x SoCs | expand

Commit Message

Kishon Vijay Abraham I April 27, 2022, 8:35 a.m. UTC
Update the PRU remoteproc bindings for the PRU cores on AM62x SoCs.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski April 28, 2022, 6:18 a.m. UTC | #1
On 27/04/2022 10:35, Kishon Vijay Abraham I wrote:
> Update the PRU remoteproc bindings for the PRU cores on AM62x SoCs.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
> index d7c3a78e37e6..e351550b012c 100644
> --- a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
> @@ -47,6 +47,7 @@ properties:
>        - ti,j721e-pru    # for PRUs in K3 J721E SoC family
>        - ti,j721e-rtu    # for RTUs in K3 J721E SoC family
>        - ti,j721e-tx-pru # for Tx_PRUs in K3 J721E SoC family
> +      - ti,am625-pru    # for PRUs in K3 AM62x SoC family

Looks like out of order.


Best regards,
Krzysztof
Kishon Vijay Abraham I May 16, 2022, 12:35 p.m. UTC | #2
Hi Krzysztof,

On 28/04/22 11:48, Krzysztof Kozlowski wrote:
> On 27/04/2022 10:35, Kishon Vijay Abraham I wrote:
>> Update the PRU remoteproc bindings for the PRU cores on AM62x SoCs.
>>
>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
>> ---
>>  Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
>> index d7c3a78e37e6..e351550b012c 100644
>> --- a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
>> +++ b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
>> @@ -47,6 +47,7 @@ properties:
>>        - ti,j721e-pru    # for PRUs in K3 J721E SoC family
>>        - ti,j721e-rtu    # for RTUs in K3 J721E SoC family
>>        - ti,j721e-tx-pru # for Tx_PRUs in K3 J721E SoC family
>> +      - ti,am625-pru    # for PRUs in K3 AM62x SoC family
> 
> Looks like out of order.

yes, this is out of sync with the existing format binding. I'll send a
patch fixing it.

Thanks,
Kishon
Krzysztof Kozlowski May 16, 2022, 3:17 p.m. UTC | #3
On 16/05/2022 14:35, Kishon Vijay Abraham I wrote:
> Hi Krzysztof,
> 
> On 28/04/22 11:48, Krzysztof Kozlowski wrote:
>> On 27/04/2022 10:35, Kishon Vijay Abraham I wrote:
>>> Update the PRU remoteproc bindings for the PRU cores on AM62x SoCs.
>>>
>>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
>>> ---
>>>  Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
>>> index d7c3a78e37e6..e351550b012c 100644
>>> --- a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
>>> +++ b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
>>> @@ -47,6 +47,7 @@ properties:
>>>        - ti,j721e-pru    # for PRUs in K3 J721E SoC family
>>>        - ti,j721e-rtu    # for RTUs in K3 J721E SoC family
>>>        - ti,j721e-tx-pru # for Tx_PRUs in K3 J721E SoC family
>>> +      - ti,am625-pru    # for PRUs in K3 AM62x SoC family
>>
>> Looks like out of order.
> 
> yes, this is out of sync with the existing format binding. I'll send a
> patch fixing it.

I meant, you introduce it out-of-order. So this patch should be modified
and new compatible added in some better place.


Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
index d7c3a78e37e6..e351550b012c 100644
--- a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
@@ -47,6 +47,7 @@  properties:
       - ti,j721e-pru    # for PRUs in K3 J721E SoC family
       - ti,j721e-rtu    # for RTUs in K3 J721E SoC family
       - ti,j721e-tx-pru # for Tx_PRUs in K3 J721E SoC family
+      - ti,am625-pru    # for PRUs in K3 AM62x SoC family
 
   reg:
     items: