| Message ID | 20220517125447.19535-1-oneukum@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | au0828: allow higher speeds | expand |
On Tue, May 17, 2022 at 02:54:47PM +0200, Oliver Neukum wrote: > This should be taken as a minimum speed. > Did you find this by testing or by reviewing the code? What does this bug look like to the user? Presumably there is a redit page webpage where someone discovered the bug and instead of reporting it to us they just told everyone to set the module parameter disable_usb_speed_check=1? regards, dan carpenter
On 17.05.22 15:03, Dan Carpenter wrote: > On Tue, May 17, 2022 at 02:54:47PM +0200, Oliver Neukum wrote: >> This should be taken as a minimum speed. >> > Did you find this by testing or by reviewing the code? What does this Review. > bug look like to the user? The device will refuse to work if you connect it via a USB 3.0 hub to XHCI > Presumably there is a redit page webpage where someone discovered the > bug and instead of reporting it to us they just told everyone to set the > module parameter disable_usb_speed_check=1? > Now, that you mention it, it isn't on reddit, but yes, someone's blog. Regards Oliver
On Tue, May 17, 2022 at 03:15:08PM +0200, Oliver Neukum wrote: > > > On 17.05.22 15:03, Dan Carpenter wrote: > > On Tue, May 17, 2022 at 02:54:47PM +0200, Oliver Neukum wrote: > >> This should be taken as a minimum speed. > >> > > Did you find this by testing or by reviewing the code? What does this > Review. > > bug look like to the user? > The device will refuse to work if you connect it via a USB 3.0 hub > to XHCI Please add that to the commit message. It really does help. regards, dan carpenter
diff --git a/drivers/media/usb/au0828/au0828-core.c b/drivers/media/usb/au0828/au0828-core.c index caefac07af92..963ed0630121 100644 --- a/drivers/media/usb/au0828/au0828-core.c +++ b/drivers/media/usb/au0828/au0828-core.c @@ -669,7 +669,7 @@ static int au0828_usb_probe(struct usb_interface *interface, * video stream wouldn't likely work, since 12 Mbps is generally * not enough even for most Digital TV streams. */ - if (usbdev->speed != USB_SPEED_HIGH && disable_usb_speed_check == 0) { + if (usbdev->speed < USB_SPEED_HIGH && disable_usb_speed_check == 0) { pr_err("au0828: Device initialization failed.\n"); pr_err("au0828: Device must be connected to a high-speed USB 2.0 port.\n"); return -ENODEV;
This should be taken as a minimum speed. Signed-off-by: Oliver Neukum <oneukum@suse.com> --- drivers/media/usb/au0828/au0828-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)