mbox series

[00/13,V2] fstests: fixes and more fixes...

Message ID 20220517070111.1381936-1-david@fromorbit.com (mailing list archive)
Headers show
Series fstests: fixes and more fixes... | expand

Message

Dave Chinner May 17, 2022, 7 a.m. UTC
Hi folks,

This is a rollup of the two patch series I sent yesterday titled:

[PATCH 0/3] fstests: test updates for XFS 5.19 kernel mods
[PATCH 0/3] fstests: more fixes...

I've fixed some patches, added documentation for those changes,
and added a bunch of patches to remove deprecated/broken tests that
should ahve been removed long ago.

I do not know if patches 9-11 will make it through vger this time -
they didn't as a single patch. They are titled:

[PATCH 09/12] xfs/018: remove deprecated test
[PATCH 10/12] xfs/081: remove deprecated test
[PATCH 11/12] xfs/082: remove deprecated test

and is thould be pretty obvious what they do from the title....

As for:

[PATCH 04/12] fstests: fix group list generation for whacky test

I've updated it to use $VALID_TEST_NAME so that it doesn't miss
names like xfs/191-input_validation as can be seen here:

$ sudo MOUNT_OPTIONS= ./check -b -s xfs -n -g mkfs
SECTION       -- xfs
FSTYP         -- xfs (debug)
PLATFORM      -- Linux/x86_64 test2 5.18.0-rc7-dgc+ #1245 SMP PREEMPT_DYNAMIC Mon May 16 11:51:16 AEST 2022
MKFS_OPTIONS  -- -f -m rmapbt=1 /dev/vdb
MOUNT_OPTIONS -- -o context=system_u:object_r:root_t:s0 /dev/vdb /mnt/scratch

generic/405
shared/032
xfs/019
xfs/029
xfs/031
xfs/096
xfs/178
xfs/191-input-validation
xfs/260
xfs/279
xfs/284
xfs/292
xfs/419
xfs/500
xfs/504
xfs/522
xfs/523
xfs/524
xfs/525
xfs/526
xfs/543

And I've document the use of _begin_fstests by the build
infrastructure and the constraints that introduces into it's
definition in the README file section that documents how to define
test groups for a given test. That's all in:

[PATCH 05/12] README: document _begin_fstests better

These fixes address all the known internal fstests problems with the
new group list generation code. I still don't know why Darrick had
deprecated tests run inappropriately or marked as failed - I can't
reproduce anything like what he described and he gave me no details
of how to reproduce what he saw.

Cheers,

Dave.

Comments

Dave Chinner May 17, 2022, 7:49 a.m. UTC | #1
On Tue, May 17, 2022 at 05:00:59PM +1000, Dave Chinner wrote:
> Hi folks,
> 
> This is a rollup of the two patch series I sent yesterday titled:
> 
> [PATCH 0/3] fstests: test updates for XFS 5.19 kernel mods
> [PATCH 0/3] fstests: more fixes...
> 
> I've fixed some patches, added documentation for those changes,
> and added a bunch of patches to remove deprecated/broken tests that
> should ahve been removed long ago.
> 
> I do not know if patches 9-11 will make it through vger this time -
> they didn't as a single patch. They are titled:
> 
> [PATCH 09/12] xfs/018: remove deprecated test
> [PATCH 10/12] xfs/081: remove deprecated test
> [PATCH 11/12] xfs/082: remove deprecated test
> 
> and is thould be pretty obvious what they do from the title....

Ok, it appears as though even separated vger still won't let a
single one of them through

Zorro, all these patches are 'git rm' commands

git rm tests/xfs/018*
git commit
git rm tests/xfs/081*
git commit
git rm tests/xfs/082*
git commit

I'm happy for you to just run them yourself, or do you want me to
send a pull request for them?

/me realises he hasn't updated his kernel.org fstests tree for 4
years....

Cheers,

Dave.
Zorro Lang May 17, 2022, 8:24 a.m. UTC | #2
On Tue, May 17, 2022 at 05:49:10PM +1000, Dave Chinner wrote:
> On Tue, May 17, 2022 at 05:00:59PM +1000, Dave Chinner wrote:
> > Hi folks,
> > 
> > This is a rollup of the two patch series I sent yesterday titled:
> > 
> > [PATCH 0/3] fstests: test updates for XFS 5.19 kernel mods
> > [PATCH 0/3] fstests: more fixes...
> > 
> > I've fixed some patches, added documentation for those changes,
> > and added a bunch of patches to remove deprecated/broken tests that
> > should ahve been removed long ago.
> > 
> > I do not know if patches 9-11 will make it through vger this time -
> > they didn't as a single patch. They are titled:

No, they didn't.

> > 
> > [PATCH 09/12] xfs/018: remove deprecated test
> > [PATCH 10/12] xfs/081: remove deprecated test
> > [PATCH 11/12] xfs/082: remove deprecated test
> > 
> > and is thould be pretty obvious what they do from the title....
> 
> Ok, it appears as though even separated vger still won't let a
> single one of them through
> 
> Zorro, all these patches are 'git rm' commands
> 
> git rm tests/xfs/018*
> git commit
> git rm tests/xfs/081*
> git commit
> git rm tests/xfs/082*
> git commit
> 
> I'm happy for you to just run them yourself, or do you want me to
> send a pull request for them?

Sure, I don't run this 3 cases either. As they're xfs specific cases, so if both
of you and Darrick agree to remove them entirely, I'm glad to help that :)

And how about remove them in single one commit/patch? Likes:
---
[PATCH] fstests: remove xfs deprecated test

Remove xfs/018, xfs/081 and xfs/082 entirely, as they're deprecated
and obsolete for long time.
---

Thanks,
Zorro

> 
> /me realises he hasn't updated his kernel.org fstests tree for 4
> years....
> 
> Cheers,
> 
> Dave.
> -- 
> Dave Chinner
> david@fromorbit.com
>
Dave Chinner May 17, 2022, 9:39 p.m. UTC | #3
On Tue, May 17, 2022 at 04:24:09PM +0800, Zorro Lang wrote:
> On Tue, May 17, 2022 at 05:49:10PM +1000, Dave Chinner wrote:
> > On Tue, May 17, 2022 at 05:00:59PM +1000, Dave Chinner wrote:
> > > Hi folks,
> > > 
> > > This is a rollup of the two patch series I sent yesterday titled:
> > > 
> > > [PATCH 0/3] fstests: test updates for XFS 5.19 kernel mods
> > > [PATCH 0/3] fstests: more fixes...
> > > 
> > > I've fixed some patches, added documentation for those changes,
> > > and added a bunch of patches to remove deprecated/broken tests that
> > > should ahve been removed long ago.
> > > 
> > > I do not know if patches 9-11 will make it through vger this time -
> > > they didn't as a single patch. They are titled:
> 
> No, they didn't.
> 
> > > 
> > > [PATCH 09/12] xfs/018: remove deprecated test
> > > [PATCH 10/12] xfs/081: remove deprecated test
> > > [PATCH 11/12] xfs/082: remove deprecated test
> > > 
> > > and is thould be pretty obvious what they do from the title....
> > 
> > Ok, it appears as though even separated vger still won't let a
> > single one of them through
> > 
> > Zorro, all these patches are 'git rm' commands
> > 
> > git rm tests/xfs/018*
> > git commit
> > git rm tests/xfs/081*
> > git commit
> > git rm tests/xfs/082*
> > git commit
> > 
> > I'm happy for you to just run them yourself, or do you want me to
> > send a pull request for them?
> 
> Sure, I don't run this 3 cases either. As they're xfs specific cases, so if both
> of you and Darrick agree to remove them entirely, I'm glad to help that :)
> 
> And how about remove them in single one commit/patch? Likes:
> ---
> [PATCH] fstests: remove xfs deprecated test
> 
> Remove xfs/018, xfs/081 and xfs/082 entirely, as they're deprecated
> and obsolete for long time.
> ---

Fine by me. That's exactly what the first patch I attempted to send
was.

Cheers,

Dave.