[net-next,v4,0/2] Broadcom PTP PHY support

Message

Jonathan Lemon May 6, 2022, 10:42 p.m. UTC

This adds PTP support for the Broadcom PHY BCM54210E (and the
specific variant BCM54213PE that the rpi-5.15 branch uses).

This has only been tested on the RPI CM4, which has one port.

There are other Broadcom chips which may benefit from using the
same framework here, although with different register sets.

v3->v4:
 Squash bcm-phy-lib.h and broadcom.c changes into one patch
 Reorder so the main patch shows up first.

v2->v3:
 Rearrange patches so they apply in order
 Use ERR_CAST

v1->v2:
 Squash Kconfig into main patch
 Move config checks into bcm-phy-lib.h
 Fix delta_ns calculations in adjtime
 Uppercase mode selector macros
 Only use NSE_INIT when necessary
 Remove the inserted Broadcom RX timestamp from the PTP packet
 Add perout (chip generated) and fsync out (timer generated)
 Remove PHY_ID_BCM54213PE special casing (needed for rpi tree)

Thanks to Lasse Johnsen <[e-mail]> for pointing out
that the chip's periodic output generation isn't sync'd to any
time base.

Jonathan Lemon (2):
  net: phy: broadcom: Add PTP support for some Broadcom PHYs.
  net: phy: broadcom: Add Broadcom PTP hooks to bcm-phy-lib

 drivers/net/phy/Kconfig       |  10 +
 drivers/net/phy/Makefile      |   1 +
 drivers/net/phy/bcm-phy-lib.h |  14 +
 drivers/net/phy/bcm-phy-ptp.c | 869 ++++++++++++++++++++++++++++++++++
 drivers/net/phy/broadcom.c    |  23 +-
 5 files changed, 913 insertions(+), 4 deletions(-)
 create mode 100644 drivers/net/phy/bcm-phy-ptp.c

Comments

Florian Fainelli May 18, 2022, 8:14 p.m. UTC | #1

On 5/6/2022 3:42 PM, Jonathan Lemon wrote:
> This adds PTP support for the Broadcom PHY BCM54210E (and the
> specific variant BCM54213PE that the rpi-5.15 branch uses).
> 
> This has only been tested on the RPI CM4, which has one port.
> 
> There are other Broadcom chips which may benefit from using the
> same framework here, although with different register sets.

Jonathan, any chance you could repost this before net-next closes? Thanks

Jonathan Lemon May 18, 2022, 8:50 p.m. UTC | #2

On 18 May 2022, at 13:14, Florian Fainelli wrote:

> On 5/6/2022 3:42 PM, Jonathan Lemon wrote:
>> This adds PTP support for the Broadcom PHY BCM54210E (and the
>> specific variant BCM54213PE that the rpi-5.15 branch uses).
>>
>> This has only been tested on the RPI CM4, which has one port.
>>
>> There are other Broadcom chips which may benefit from using the
>> same framework here, although with different register sets.
>
> Jonathan, any chance you could repost this before net-next closes? Thanks

Sure, let me rebuild today and submit.
—
Jonathan