| Message ID | 20220508185313.2222956-1-colin.foster@in-advantage.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | add support for VSC7512 control over SPI | expand |
Hi Colin, On Sun, May 08, 2022 at 11:52:57AM -0700, Colin Foster wrote: > The patch set in general is to add support for the VSC7512, and > eventually the VSC7511, VSC7513 and VSC7514 devices controlled over > SPI. The driver is believed to be fully functional for the internal > phy ports (0-3) on the VSC7512. It is not yet functional for SGMII, > QSGMII, and SerDes ports. > > I have mentioned previously: > The hardware setup I'm using for development is a beaglebone black, with > jumpers from SPI0 to the microchip VSC7512 dev board. The microchip dev > board has been modified to not boot from flash, but wait for SPI. An > ethernet cable is connected from the beaglebone ethernet to port 0 of > the dev board. > > The relevant sections of the device tree I'm using for the VSC7512 is > below. Notably the SGPIO LEDs follow link status and speed from network > triggers. > > In order to make this work, I have modified the cpsw driver, and now the > cpsw_new driver, to allow for frames over 1500 bytes. Otherwise the > tagging protocol will not work between the beaglebone and the VSC7512. I > plan to eventually try to get those changes in mainline, but I don't > want to get distracted from my initial goal. I also had to change > bonecommon.dtsi to avoid using VLAN 0. This ti,dual-emac-pvid thing is a really odd thing to put in the device tree. But what's the problem with VLAN 0 anyway? > > I believe much of the MFD sections are very near feature-complete, > whereas the switch section will require ongoing work to enable > additional ports / features. This could lead to a couple potential > scenarios: > > The first being patches 1-8 being split into a separate patch set, while > patches 9-16 remain in the RFC state. This would offer the pinctrl / > sgpio / mdio controller functionality, but no switch control until it is > ready. > > The second would assume the current state of the switch driver is > acceptable (or at least very near so) and the current patch set gets an > official PATCH set (with minor changes as necessary - e.g. squashing > patch 16 into 14). That might be ambitious. > > The third would be to keep this patch set in RFC until switch > functionality is more complete. I'd understand if this was the desired > path... but it would mean me having to bug more reviewers. Considering that the merge window is approaching, I'd say get the non-DSA stuff accepted until then, then repost the DSA stuff in ~3 weeks from now as non-RFC, once v5.18 is cut and the development for v5.20 (or whatever the number will be) begins. > / { > vscleds { > compatible = "gpio-leds"; > vscled@0 { > label = "port0led"; > gpios = <&sgpio_out1 0 0 GPIO_ACTIVE_LOW>; > default-state = "off"; > linux,default-trigger = "ocelot-miim0.2.auto-mii:00:link"; > }; > vscled@1 { > label = "port0led1"; > gpios = <&sgpio_out1 0 1 GPIO_ACTIVE_LOW>; > default-state = "off"; > linux,default-trigger = "ocelot-miim0.2.auto-mii:00:1Gbps"; > }; > [ ... ] > }; > }; > > &spi0 { > #address-cells = <1>; > #size-cells = <0>; > status = "okay"; > > ocelot-chip@0 { > compatible = "mscc,vsc7512_mfd_spi"; Can you use hyphens instead of underscores in this compatible string? > spi-max-frequency = <2500000>; > reg = <0>; > > ethernet-switch@0 { I don't think the switch node should have any address? > compatible = "mscc,vsc7512-ext-switch"; > ports { > #address-cells = <1>; > #size-cells = <0>; > > port@0 { > reg = <0>; > label = "cpu"; > status = "okay"; > ethernet = <&mac_sw>; > phy-handle = <&sw_phy0>; > phy-mode = "internal"; > }; > > port@1 { > reg = <1>; > label = "swp1"; > status = "okay"; > phy-handle = <&sw_phy1>; > phy-mode = "internal"; > }; > }; > }; > > mdio0: mdio0@0 { This is going to be interesting. Some drivers with multiple MDIO buses create an "mdios" container with #address-cells = <1> and put the MDIO bus nodes under that. Others create an "mdio" node and an "mdio0" node (and no address for either of them). The problem with the latter approach is that Documentation/devicetree/bindings/net/mdio.yaml does not accept the "mdio0"/"mdio1" node name for an MDIO bus. > compatible = "mscc,ocelot-miim"; > #address-cells = <1>; > #size-cells = <0>; > > sw_phy0: ethernet-phy@0 { > reg = <0x0>; > }; > > sw_phy1: ethernet-phy@1 { > reg = <0x1>; > }; > > sw_phy2: ethernet-phy@2 { > reg = <0x2>; > }; > > sw_phy3: ethernet-phy@3 { > reg = <0x3>; > }; > }; > > mdio1: mdio1@1 { > compatible = "mscc,ocelot-miim"; > pinctrl-names = "default"; > pinctrl-0 = <&miim1>; > #address-cells = <1>; > #size-cells = <0>; > > sw_phy4: ethernet-phy@4 { > reg = <0x4>; > }; > > sw_phy5: ethernet-phy@5 { > reg = <0x5>; > }; > > sw_phy6: ethernet-phy@6 { > reg = <0x6>; > }; > > sw_phy7: ethernet-phy@7 { > reg = <0x7>; > }; > }; > > gpio: pinctrl@0 { Similar thing with the address. All these @0 addresses actually conflict with each other. > compatible = "mscc,ocelot-pinctrl"; > gpio-controller; > #gpio_cells = <2>; > gpio-ranges = <&gpio 0 0 22>; > > led_shift_reg_pins: led-shift-reg-pins { > pins = "GPIO_0", "GPIO_1", "GPIO_2", "GPIO_3"; > function = "sg0"; > }; > > miim1: miim1 { > pins = "GPIO_14", "GPIO_15"; > function = "miim"; > }; > }; > > sgpio: sgpio { And mixing nodes with addresses with nodes without addresses is broken too. > compatible = "mscc,ocelot-sgpio"; > #address-cells = <1>; > #size-cells = <0>; > bus-frequency=<12500000>; > clocks = <&ocelot_clock>; > microchip,sgpio-port-ranges = <0 15>; > pinctrl-names = "default"; > pinctrl-0 = <&led_shift_reg_pins>; > > sgpio_in0: sgpio@0 { > compatible = "microchip,sparx5-sgpio-bank"; > reg = <0>; > gpio-controller; > #gpio-cells = <3>; > ngpios = <64>; > }; > > sgpio_out1: sgpio@1 { > compatible = "microchip,sparx5-sgpio-bank"; > reg = <1>; > gpio-controller; > #gpio-cells = <3>; > ngpios = <64>; > }; > }; > }; > }; > > And I'll include the relevant dmesg prints - I don't love the "invalid > resource" prints, as they seem to be misleading. They're a byproduct of > looking for IO resources before falling back to REG. > > [ 0.000000] Booting Linux on physical CPU 0x0 > [ 0.000000] Linux version 5.18.0-rc5-01295-g47053e327c52 (X@X) (arm-linux-gnueabi-gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0, GNU ld (GNU Binutils for Ubuntu) 2.34) #630 SMP PREEMPT Sun May 8 10:56:51 PDT 2022 > ... > [ 2.829319] pinctrl-ocelot ocelot-pinctrl.0.auto: DMA mask not set Why does this get printed, if you put a dump_stack() in of_dma_configure_id()? > [ 2.835718] pinctrl-ocelot ocelot-pinctrl.0.auto: invalid resource > [ 2.842717] gpiochip_find_base: found new base at 2026 > [ 2.842774] gpio gpiochip4: (ocelot-gpio): created GPIO range 0->21 ==> ocelot-pinctrl.0.auto PIN 0->21 > [ 2.845693] gpio gpiochip4: (ocelot-gpio): added GPIO chardev (254:4) > [ 2.845828] gpio gpiochip4: registered GPIOs 2026 to 2047 on ocelot-gpio > [ 2.845855] pinctrl-ocelot ocelot-pinctrl.0.auto: driver registered > [ 2.855925] pinctrl-microchip-sgpio ocelot-sgpio.1.auto: DMA mask not set > [ 2.863089] pinctrl-microchip-sgpio ocelot-sgpio.1.auto: invalid resource > [ 2.870801] gpiochip_find_base: found new base at 1962 > [ 2.871528] gpio_stub_drv gpiochip5: (ocelot-sgpio.1.auto-input): added GPIO chardev (254:5) > [ 2.871666] gpio_stub_drv gpiochip5: registered GPIOs 1962 to 2025 on ocelot-sgpio.1.auto-input > [ 2.872364] gpiochip_find_base: found new base at 1898 > [ 2.873244] gpio_stub_drv gpiochip6: (ocelot-sgpio.1.auto-output): added GPIO chardev (254:6) > [ 2.873354] gpio_stub_drv gpiochip6: registered GPIOs 1898 to 1961 on ocelot-sgpio.1.auto-output > [ 2.881148] mscc-miim ocelot-miim0.2.auto: DMA mask not set > [ 2.886929] mscc-miim ocelot-miim0.2.auto: invalid resource > [ 2.893738] mdio_bus ocelot-miim0.2.auto-mii: GPIO lookup for consumer reset > [ 2.893769] mdio_bus ocelot-miim0.2.auto-mii: using device tree for GPIO lookup > [ 2.893802] of_get_named_gpiod_flags: can't parse 'reset-gpios' property of node '/ocp/interconnect@48000000/segment@0/target-module@30000/spi@0/ocelot-chip@0/mdio0[0]' > [ 2.893898] of_get_named_gpiod_flags: can't parse 'reset-gpio' property of node '/ocp/interconnect@48000000/segment@0/target-module@30000/spi@0/ocelot-chip@0/mdio0[0]' > [ 2.893996] mdio_bus ocelot-miim0.2.auto-mii: using lookup tables for GPIO lookup > [ 2.894012] mdio_bus ocelot-miim0.2.auto-mii: No GPIO consumer reset found > [ 3.395738] mdio_bus ocelot-miim0.2.auto-mii:00: GPIO lookup for consumer reset > [ 3.395777] mdio_bus ocelot-miim0.2.auto-mii:00: using device tree for GPIO lookup > [ 3.395840] of_get_named_gpiod_flags: can't parse 'reset-gpios' property of node '/ocp/interconnect@48000000/segment@0/target-module@30000/spi@0/ocelot-chip@0/mdio0/ethernet-phy@0[0]' > [ 3.395959] of_get_named_gpiod_flags: can't parse 'reset-gpio' property of node '/ocp/interconnect@48000000/segment@0/target-module@30000/spi@0/ocelot-chip@0/mdio0/ethernet-phy@0[0]' > [ 3.396069] mdio_bus ocelot-miim0.2.auto-mii:00: using lookup tables for GPIO lookup > [ 3.396086] mdio_bus ocelot-miim0.2.auto-mii:00: No GPIO consumer reset found > ... > [ 3.449187] ocelot-ext-switch ocelot-ext-switch.4.auto: DMA mask not set > [ 5.336880] ocelot-ext-switch ocelot-ext-switch.4.auto: PHY [ocelot-miim0.2.auto-mii:00] driver [Generic PHY] (irq=POLL) > [ 5.349087] ocelot-ext-switch ocelot-ext-switch.4.auto: configuring for phy/internal link mode > [ 5.363619] ocelot-ext-switch ocelot-ext-switch.4.auto swp1 (uninitialized): PHY [ocelot-miim0.2.auto-mii:01] driver [Generic PHY] (irq=POLL) > [ 5.381396] ocelot-ext-switch ocelot-ext-switch.4.auto swp2 (uninitialized): PHY [ocelot-miim0.2.auto-mii:02] driver [Generic PHY] (irq=POLL) > [ 5.398525] ocelot-ext-switch ocelot-ext-switch.4.auto swp3 (uninitialized): PHY [ocelot-miim0.2.auto-mii:03] driver [Generic PHY] (irq=POLL) Do the PHYs not have a specific driver? > [ 5.422048] device eth0 entered promiscuous mode > [ 5.426785] DSA: tree 0 setup > ... > [ 7.450067] ocelot-ext-switch ocelot-ext-switch.4.auto: Link is Up - 100Mbps/Full - flow control off > [ 21.556395] cpsw-switch 4a100000.switch: starting ndev. mode: dual_mac > [ 21.648564] SMSC LAN8710/LAN8720 4a101000.mdio:00: attached PHY driver (mii_bus:phy_addr=4a101000.mdio:00, irq=POLL) > [ 21.667970] 8021q: adding VLAN 0 to HW filter on device eth0 > [ 21.705360] ocelot-ext-switch ocelot-ext-switch.4.auto swp1: configuring for phy/internal link mode > [ 22.018230] ocelot-ext-switch ocelot-ext-switch.4.auto: Link is Down > [ 23.771740] cpsw-switch 4a100000.switch eth0: Link is Up - 100Mbps/Full - flow control off > [ 24.090929] ocelot-ext-switch ocelot-ext-switch.4.auto: Link is Up - 100Mbps/Full - flow control off > [ 25.853021] ocelot-ext-switch ocelot-ext-switch.4.auto swp1: Link is Up - 1Gbps/Full - flow control rx/tx > > > RFC history: > v1 (accidentally named vN) > * Initial architecture. Not functional > * General concepts laid out > > v2 > * Near functional. No CPU port communication, but control over all > external ports > * Cleaned up regmap implementation from v1 > > v3 > * Functional > * Shared MDIO transactions routed through mdio-mscc-miim > * CPU / NPI port enabled by way of vsc7512_enable_npi_port / > felix->info->enable_npi_port > * NPI port tagging functional - Requires a CPU port driver that supports > frames of 1520 bytes. Verified with a patch to the cpsw driver > > v4 > * Functional > * Device tree fixes > * Add hooks for pinctrl-ocelot - some functionality by way of sysfs > * Add hooks for pinctrl-microsemi-sgpio - not yet fully functional > * Remove lynx_pcs interface for a generic phylink_pcs. The goal here > is to have an ocelot_pcs that will work for each configuration of > every port. > > v5 > * Restructured to MFD > * Several commits were split out, submitted, and accepted > * pinctrl-ocelot believed to be fully functional (requires commits > from the linux-pinctrl tree) > * External MDIO bus believed to be fully functional > > v6 > * Applied several suggestions from the last RFC from Lee Jones. I > hope I didn't miss anything. > * Clean up MFD core - SPI interaction. They no longer use callbacks. > * regmaps get registered to the child device, and don't attempt to > get shared. It seems if a regmap is to be shared, that should be > solved with syscon, not dev or mfd. > > v7 > * Applied as much as I could from Lee and Vladimir's suggestions. As > always, the feedback is greatly appreciated! > * Remove "ocelot_spi" container complication > * Move internal MDIO bus from ocelot_ext to MFD, with a devicetree > change to match > * Add initial HSIO support > * Switch to IORESOURCE_REG for resource definitions > > v8 > * Applied another round of suggestions from Lee and Vladimir > * Utilize regmap bus reads, which speeds bulk transfers up by an bus -> bulk? > order of magnitude > * Add two additional patches to utilize phylink_generic_validate > * Changed GPL V2 to GPL in licenses where applicable (checkpatch) > * Remove initial hsio/serdes changes from the RFC > > > Colin Foster (16): > pinctrl: ocelot: allow pinctrl-ocelot to be loaded as a module > pinctrl: microchip-sgpio: allow sgpio driver to be used as a module > net: ocelot: add interface to get regmaps when exernally controlled > net: mdio: mscc-miim: add ability to be used in a non-mmio > configuration > pinctrl: ocelot: add ability to be used in a non-mmio configuration > pinctrl: microchip-sgpio: add ability to be used in a non-mmio > configuration > resource: add define macro for register address resources > mfd: ocelot: add support for the vsc7512 chip via spi > net: mscc: ocelot: expose ocelot wm functions > net: dsa: felix: add configurable device quirks > net: mscc: ocelot: expose regfield definition to be used by other > drivers > net: mscc: ocelot: expose stats layout definition to be used by other > drivers > net: mscc: ocelot: expose vcap_props structure > net: dsa: ocelot: add external ocelot switch control > net: dsa: felix: add phylink_get_caps capability > net: dsa: ocelot: utilize phylink_generic_validate > > drivers/mfd/Kconfig | 18 + > drivers/mfd/Makefile | 2 + > drivers/mfd/ocelot-core.c | 138 ++++++++ > drivers/mfd/ocelot-spi.c | 311 +++++++++++++++++ > drivers/mfd/ocelot.h | 34 ++ > drivers/net/dsa/ocelot/Kconfig | 14 + > drivers/net/dsa/ocelot/Makefile | 5 + > drivers/net/dsa/ocelot/felix.c | 29 +- > drivers/net/dsa/ocelot/felix.h | 3 + > drivers/net/dsa/ocelot/felix_vsc9959.c | 1 + > drivers/net/dsa/ocelot/ocelot_ext.c | 366 +++++++++++++++++++++ > drivers/net/dsa/ocelot/seville_vsc9953.c | 1 + > drivers/net/ethernet/mscc/ocelot_devlink.c | 31 ++ > drivers/net/ethernet/mscc/ocelot_vsc7514.c | 230 +------------ > drivers/net/ethernet/mscc/vsc7514_regs.c | 200 +++++++++++ > drivers/net/mdio/mdio-mscc-miim.c | 31 +- > drivers/pinctrl/Kconfig | 4 +- > drivers/pinctrl/pinctrl-microchip-sgpio.c | 26 +- > drivers/pinctrl/pinctrl-ocelot.c | 35 +- > include/linux/ioport.h | 5 + > include/soc/mscc/ocelot.h | 19 ++ > include/soc/mscc/vsc7514_regs.h | 6 + > 22 files changed, 1251 insertions(+), 258 deletions(-) > create mode 100644 drivers/mfd/ocelot-core.c > create mode 100644 drivers/mfd/ocelot-spi.c > create mode 100644 drivers/mfd/ocelot.h > create mode 100644 drivers/net/dsa/ocelot/ocelot_ext.c > > -- > 2.25.1 >
On Mon, May 09, 2022 at 05:13:05PM +0000, Vladimir Oltean wrote: > Hi Colin, > > On Sun, May 08, 2022 at 11:52:57AM -0700, Colin Foster wrote: > > The patch set in general is to add support for the VSC7512, and > > eventually the VSC7511, VSC7513 and VSC7514 devices controlled over > > SPI. The driver is believed to be fully functional for the internal > > phy ports (0-3) on the VSC7512. It is not yet functional for SGMII, > > QSGMII, and SerDes ports. > > > > I have mentioned previously: > > The hardware setup I'm using for development is a beaglebone black, with > > jumpers from SPI0 to the microchip VSC7512 dev board. The microchip dev > > board has been modified to not boot from flash, but wait for SPI. An > > ethernet cable is connected from the beaglebone ethernet to port 0 of > > the dev board. > > > > The relevant sections of the device tree I'm using for the VSC7512 is > > below. Notably the SGPIO LEDs follow link status and speed from network > > triggers. > > > > In order to make this work, I have modified the cpsw driver, and now the > > cpsw_new driver, to allow for frames over 1500 bytes. Otherwise the > > tagging protocol will not work between the beaglebone and the VSC7512. I > > plan to eventually try to get those changes in mainline, but I don't > > want to get distracted from my initial goal. I also had to change > > bonecommon.dtsi to avoid using VLAN 0. > > This ti,dual-emac-pvid thing is a really odd thing to put in the device > tree. But what's the problem with VLAN 0 anyway? Ahh, I see that was an exchange between me and Grygorii Strashko that wasn't public. Looking now, it might be VLAN 1... I'd see "failed to initialize vlan filtering" when I ran "ip link set dev swp1 master br0" because the default bridge vlan conflicted with slave_data->dual_emac_res_vlan = port_id; (drivers/net/ethernet/ti/cpsw_new.c, around line 1325) My initial attempt was to just change cpsw_port1 ti,dual-emac-pvid=<12>; but that didn't change the behavior. Maybe if I went back to it again, seeing as I'm much older and wiser than I was before, I could find the correct device tree solution... Ideally I think I should have the ability to not enable cpsw_port1 and be good. But I think the magic was really just to set slave_data->dual_emac_res_vlan = 10 + port_id; to avoid conflicts. This became an issue at 5.15, when cpsw_new was rolled in to the .dtsis I've been using. > > > > > I believe much of the MFD sections are very near feature-complete, > > whereas the switch section will require ongoing work to enable > > additional ports / features. This could lead to a couple potential > > scenarios: > > > > The first being patches 1-8 being split into a separate patch set, while > > patches 9-16 remain in the RFC state. This would offer the pinctrl / > > sgpio / mdio controller functionality, but no switch control until it is > > ready. > > > > The second would assume the current state of the switch driver is > > acceptable (or at least very near so) and the current patch set gets an > > official PATCH set (with minor changes as necessary - e.g. squashing > > patch 16 into 14). That might be ambitious. > > > > The third would be to keep this patch set in RFC until switch > > functionality is more complete. I'd understand if this was the desired > > path... but it would mean me having to bug more reviewers. > > Considering that the merge window is approaching, I'd say get the > non-DSA stuff accepted until then, then repost the DSA stuff in ~3 weeks > from now as non-RFC, once v5.18 is cut and the development for v5.20 > (or whatever the number will be) begins. That's the approach I'd prefer as well. > > > / { > > vscleds { > > compatible = "gpio-leds"; > > vscled@0 { > > label = "port0led"; > > gpios = <&sgpio_out1 0 0 GPIO_ACTIVE_LOW>; > > default-state = "off"; > > linux,default-trigger = "ocelot-miim0.2.auto-mii:00:link"; > > }; > > vscled@1 { > > label = "port0led1"; > > gpios = <&sgpio_out1 0 1 GPIO_ACTIVE_LOW>; > > default-state = "off"; > > linux,default-trigger = "ocelot-miim0.2.auto-mii:00:1Gbps"; > > }; > > [ ... ] > > }; > > }; > > > > &spi0 { > > #address-cells = <1>; > > #size-cells = <0>; > > status = "okay"; > > > > ocelot-chip@0 { > > compatible = "mscc,vsc7512_mfd_spi"; > > Can you use hyphens instead of underscores in this compatible string? > > > spi-max-frequency = <2500000>; > > reg = <0>; > > > > ethernet-switch@0 { > > I don't think the switch node should have any address? > > > compatible = "mscc,vsc7512-ext-switch"; > > ports { > > #address-cells = <1>; > > #size-cells = <0>; > > > > port@0 { > > reg = <0>; > > label = "cpu"; > > status = "okay"; > > ethernet = <&mac_sw>; > > phy-handle = <&sw_phy0>; > > phy-mode = "internal"; > > }; > > > > port@1 { > > reg = <1>; > > label = "swp1"; > > status = "okay"; > > phy-handle = <&sw_phy1>; > > phy-mode = "internal"; > > }; > > }; > > }; > > > > mdio0: mdio0@0 { > > This is going to be interesting. Some drivers with multiple MDIO buses > create an "mdios" container with #address-cells = <1> and put the MDIO > bus nodes under that. Others create an "mdio" node and an "mdio0" node > (and no address for either of them). > > The problem with the latter approach is that > Documentation/devicetree/bindings/net/mdio.yaml does not accept the > "mdio0"/"mdio1" node name for an MDIO bus. Hmm... That'll be interesting indeed. The 7514 (arch/mips/boot/dts/mscc/ocelot.dtsi) is where I undoubtedly started. Is there an issue with the 7514, or is it just an issue with my implementation, which should be: mdio0: mdio@0 { instead of mdio0@0? > > > compatible = "mscc,ocelot-miim"; > > #address-cells = <1>; > > #size-cells = <0>; > > > > sw_phy0: ethernet-phy@0 { > > reg = <0x0>; > > }; > > > > sw_phy1: ethernet-phy@1 { > > reg = <0x1>; > > }; > > > > sw_phy2: ethernet-phy@2 { > > reg = <0x2>; > > }; > > > > sw_phy3: ethernet-phy@3 { > > reg = <0x3>; > > }; > > }; > > > > mdio1: mdio1@1 { > > compatible = "mscc,ocelot-miim"; > > pinctrl-names = "default"; > > pinctrl-0 = <&miim1>; > > #address-cells = <1>; > > #size-cells = <0>; > > > > sw_phy4: ethernet-phy@4 { > > reg = <0x4>; > > }; > > > > sw_phy5: ethernet-phy@5 { > > reg = <0x5>; > > }; > > > > sw_phy6: ethernet-phy@6 { > > reg = <0x6>; > > }; > > > > sw_phy7: ethernet-phy@7 { > > reg = <0x7>; > > }; > > }; > > > > gpio: pinctrl@0 { > > Similar thing with the address. All these @0 addresses actually conflict > with each other. > > > compatible = "mscc,ocelot-pinctrl"; > > gpio-controller; > > #gpio_cells = <2>; > > gpio-ranges = <&gpio 0 0 22>; > > > > led_shift_reg_pins: led-shift-reg-pins { > > pins = "GPIO_0", "GPIO_1", "GPIO_2", "GPIO_3"; > > function = "sg0"; > > }; > > > > miim1: miim1 { > > pins = "GPIO_14", "GPIO_15"; > > function = "miim"; > > }; > > }; > > > > sgpio: sgpio { > > And mixing nodes with addresses with nodes without addresses is broken too. > > > compatible = "mscc,ocelot-sgpio"; > > #address-cells = <1>; > > #size-cells = <0>; > > bus-frequency=<12500000>; > > clocks = <&ocelot_clock>; > > microchip,sgpio-port-ranges = <0 15>; > > pinctrl-names = "default"; > > pinctrl-0 = <&led_shift_reg_pins>; > > > > sgpio_in0: sgpio@0 { > > compatible = "microchip,sparx5-sgpio-bank"; > > reg = <0>; > > gpio-controller; > > #gpio-cells = <3>; > > ngpios = <64>; > > }; > > > > sgpio_out1: sgpio@1 { > > compatible = "microchip,sparx5-sgpio-bank"; > > reg = <1>; > > gpio-controller; > > #gpio-cells = <3>; > > ngpios = <64>; > > }; > > }; > > }; > > }; > > > > And I'll include the relevant dmesg prints - I don't love the "invalid > > resource" prints, as they seem to be misleading. They're a byproduct of > > looking for IO resources before falling back to REG. > > > > [ 0.000000] Booting Linux on physical CPU 0x0 > > [ 0.000000] Linux version 5.18.0-rc5-01295-g47053e327c52 (X@X) (arm-linux-gnueabi-gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0, GNU ld (GNU Binutils for Ubuntu) 2.34) #630 SMP PREEMPT Sun May 8 10:56:51 PDT 2022 > > ... > > [ 2.829319] pinctrl-ocelot ocelot-pinctrl.0.auto: DMA mask not set > > Why does this get printed, if you put a dump_stack() in of_dma_configure_id()? I'll run that tonight. > > > [ 2.835718] pinctrl-ocelot ocelot-pinctrl.0.auto: invalid resource > > [ 2.842717] gpiochip_find_base: found new base at 2026 > > [ 2.842774] gpio gpiochip4: (ocelot-gpio): created GPIO range 0->21 ==> ocelot-pinctrl.0.auto PIN 0->21 > > [ 2.845693] gpio gpiochip4: (ocelot-gpio): added GPIO chardev (254:4) > > [ 2.845828] gpio gpiochip4: registered GPIOs 2026 to 2047 on ocelot-gpio > > [ 2.845855] pinctrl-ocelot ocelot-pinctrl.0.auto: driver registered > > [ 2.855925] pinctrl-microchip-sgpio ocelot-sgpio.1.auto: DMA mask not set > > [ 2.863089] pinctrl-microchip-sgpio ocelot-sgpio.1.auto: invalid resource > > [ 2.870801] gpiochip_find_base: found new base at 1962 > > [ 2.871528] gpio_stub_drv gpiochip5: (ocelot-sgpio.1.auto-input): added GPIO chardev (254:5) > > [ 2.871666] gpio_stub_drv gpiochip5: registered GPIOs 1962 to 2025 on ocelot-sgpio.1.auto-input > > [ 2.872364] gpiochip_find_base: found new base at 1898 > > [ 2.873244] gpio_stub_drv gpiochip6: (ocelot-sgpio.1.auto-output): added GPIO chardev (254:6) > > [ 2.873354] gpio_stub_drv gpiochip6: registered GPIOs 1898 to 1961 on ocelot-sgpio.1.auto-output > > [ 2.881148] mscc-miim ocelot-miim0.2.auto: DMA mask not set > > [ 2.886929] mscc-miim ocelot-miim0.2.auto: invalid resource > > [ 2.893738] mdio_bus ocelot-miim0.2.auto-mii: GPIO lookup for consumer reset > > [ 2.893769] mdio_bus ocelot-miim0.2.auto-mii: using device tree for GPIO lookup > > [ 2.893802] of_get_named_gpiod_flags: can't parse 'reset-gpios' property of node '/ocp/interconnect@48000000/segment@0/target-module@30000/spi@0/ocelot-chip@0/mdio0[0]' > > [ 2.893898] of_get_named_gpiod_flags: can't parse 'reset-gpio' property of node '/ocp/interconnect@48000000/segment@0/target-module@30000/spi@0/ocelot-chip@0/mdio0[0]' > > [ 2.893996] mdio_bus ocelot-miim0.2.auto-mii: using lookup tables for GPIO lookup > > [ 2.894012] mdio_bus ocelot-miim0.2.auto-mii: No GPIO consumer reset found > > [ 3.395738] mdio_bus ocelot-miim0.2.auto-mii:00: GPIO lookup for consumer reset > > [ 3.395777] mdio_bus ocelot-miim0.2.auto-mii:00: using device tree for GPIO lookup > > [ 3.395840] of_get_named_gpiod_flags: can't parse 'reset-gpios' property of node '/ocp/interconnect@48000000/segment@0/target-module@30000/spi@0/ocelot-chip@0/mdio0/ethernet-phy@0[0]' > > [ 3.395959] of_get_named_gpiod_flags: can't parse 'reset-gpio' property of node '/ocp/interconnect@48000000/segment@0/target-module@30000/spi@0/ocelot-chip@0/mdio0/ethernet-phy@0[0]' > > [ 3.396069] mdio_bus ocelot-miim0.2.auto-mii:00: using lookup tables for GPIO lookup > > [ 3.396086] mdio_bus ocelot-miim0.2.auto-mii:00: No GPIO consumer reset found > > ... > > [ 3.449187] ocelot-ext-switch ocelot-ext-switch.4.auto: DMA mask not set > > [ 5.336880] ocelot-ext-switch ocelot-ext-switch.4.auto: PHY [ocelot-miim0.2.auto-mii:00] driver [Generic PHY] (irq=POLL) > > [ 5.349087] ocelot-ext-switch ocelot-ext-switch.4.auto: configuring for phy/internal link mode > > [ 5.363619] ocelot-ext-switch ocelot-ext-switch.4.auto swp1 (uninitialized): PHY [ocelot-miim0.2.auto-mii:01] driver [Generic PHY] (irq=POLL) > > [ 5.381396] ocelot-ext-switch ocelot-ext-switch.4.auto swp2 (uninitialized): PHY [ocelot-miim0.2.auto-mii:02] driver [Generic PHY] (irq=POLL) > > [ 5.398525] ocelot-ext-switch ocelot-ext-switch.4.auto swp3 (uninitialized): PHY [ocelot-miim0.2.auto-mii:03] driver [Generic PHY] (irq=POLL) > > Do the PHYs not have a specific driver? When I have the other four ports defined, those correctly find the vsc85xx driver, perform serdes calibration, etc. (assuming I have that phy support compiled in) The internal phys I believe have always just been using a generic driver. > > > [ 5.422048] device eth0 entered promiscuous mode > > [ 5.426785] DSA: tree 0 setup > > ... > > [ 7.450067] ocelot-ext-switch ocelot-ext-switch.4.auto: Link is Up - 100Mbps/Full - flow control off > > [ 21.556395] cpsw-switch 4a100000.switch: starting ndev. mode: dual_mac > > [ 21.648564] SMSC LAN8710/LAN8720 4a101000.mdio:00: attached PHY driver (mii_bus:phy_addr=4a101000.mdio:00, irq=POLL) > > [ 21.667970] 8021q: adding VLAN 0 to HW filter on device eth0 > > [ 21.705360] ocelot-ext-switch ocelot-ext-switch.4.auto swp1: configuring for phy/internal link mode > > [ 22.018230] ocelot-ext-switch ocelot-ext-switch.4.auto: Link is Down > > [ 23.771740] cpsw-switch 4a100000.switch eth0: Link is Up - 100Mbps/Full - flow control off > > [ 24.090929] ocelot-ext-switch ocelot-ext-switch.4.auto: Link is Up - 100Mbps/Full - flow control off > > [ 25.853021] ocelot-ext-switch ocelot-ext-switch.4.auto swp1: Link is Up - 1Gbps/Full - flow control rx/tx > > > > > > RFC history: > > v1 (accidentally named vN) > > * Initial architecture. Not functional > > * General concepts laid out > > > > v2 > > * Near functional. No CPU port communication, but control over all > > external ports > > * Cleaned up regmap implementation from v1 > > > > v3 > > * Functional > > * Shared MDIO transactions routed through mdio-mscc-miim > > * CPU / NPI port enabled by way of vsc7512_enable_npi_port / > > felix->info->enable_npi_port > > * NPI port tagging functional - Requires a CPU port driver that supports > > frames of 1520 bytes. Verified with a patch to the cpsw driver > > > > v4 > > * Functional > > * Device tree fixes > > * Add hooks for pinctrl-ocelot - some functionality by way of sysfs > > * Add hooks for pinctrl-microsemi-sgpio - not yet fully functional > > * Remove lynx_pcs interface for a generic phylink_pcs. The goal here > > is to have an ocelot_pcs that will work for each configuration of > > every port. > > > > v5 > > * Restructured to MFD > > * Several commits were split out, submitted, and accepted > > * pinctrl-ocelot believed to be fully functional (requires commits > > from the linux-pinctrl tree) > > * External MDIO bus believed to be fully functional > > > > v6 > > * Applied several suggestions from the last RFC from Lee Jones. I > > hope I didn't miss anything. > > * Clean up MFD core - SPI interaction. They no longer use callbacks. > > * regmaps get registered to the child device, and don't attempt to > > get shared. It seems if a regmap is to be shared, that should be > > solved with syscon, not dev or mfd. > > > > v7 > > * Applied as much as I could from Lee and Vladimir's suggestions. As > > always, the feedback is greatly appreciated! > > * Remove "ocelot_spi" container complication > > * Move internal MDIO bus from ocelot_ext to MFD, with a devicetree > > change to match > > * Add initial HSIO support > > * Switch to IORESOURCE_REG for resource definitions > > > > v8 > > * Applied another round of suggestions from Lee and Vladimir > > * Utilize regmap bus reads, which speeds bulk transfers up by an > > bus -> bulk? Either is probably valid. Here I'm referencing struct regmap_bus, so _regmap_bus_read allows the utilization of bulk transfers for stats. > > > order of magnitude > > * Add two additional patches to utilize phylink_generic_validate > > * Changed GPL V2 to GPL in licenses where applicable (checkpatch) > > * Remove initial hsio/serdes changes from the RFC > > > > > > Colin Foster (16): > > pinctrl: ocelot: allow pinctrl-ocelot to be loaded as a module > > pinctrl: microchip-sgpio: allow sgpio driver to be used as a module > > net: ocelot: add interface to get regmaps when exernally controlled > > net: mdio: mscc-miim: add ability to be used in a non-mmio > > configuration > > pinctrl: ocelot: add ability to be used in a non-mmio configuration > > pinctrl: microchip-sgpio: add ability to be used in a non-mmio > > configuration > > resource: add define macro for register address resources > > mfd: ocelot: add support for the vsc7512 chip via spi > > net: mscc: ocelot: expose ocelot wm functions > > net: dsa: felix: add configurable device quirks > > net: mscc: ocelot: expose regfield definition to be used by other > > drivers > > net: mscc: ocelot: expose stats layout definition to be used by other > > drivers > > net: mscc: ocelot: expose vcap_props structure > > net: dsa: ocelot: add external ocelot switch control > > net: dsa: felix: add phylink_get_caps capability > > net: dsa: ocelot: utilize phylink_generic_validate > > > > drivers/mfd/Kconfig | 18 + > > drivers/mfd/Makefile | 2 + > > drivers/mfd/ocelot-core.c | 138 ++++++++ > > drivers/mfd/ocelot-spi.c | 311 +++++++++++++++++ > > drivers/mfd/ocelot.h | 34 ++ > > drivers/net/dsa/ocelot/Kconfig | 14 + > > drivers/net/dsa/ocelot/Makefile | 5 + > > drivers/net/dsa/ocelot/felix.c | 29 +- > > drivers/net/dsa/ocelot/felix.h | 3 + > > drivers/net/dsa/ocelot/felix_vsc9959.c | 1 + > > drivers/net/dsa/ocelot/ocelot_ext.c | 366 +++++++++++++++++++++ > > drivers/net/dsa/ocelot/seville_vsc9953.c | 1 + > > drivers/net/ethernet/mscc/ocelot_devlink.c | 31 ++ > > drivers/net/ethernet/mscc/ocelot_vsc7514.c | 230 +------------ > > drivers/net/ethernet/mscc/vsc7514_regs.c | 200 +++++++++++ > > drivers/net/mdio/mdio-mscc-miim.c | 31 +- > > drivers/pinctrl/Kconfig | 4 +- > > drivers/pinctrl/pinctrl-microchip-sgpio.c | 26 +- > > drivers/pinctrl/pinctrl-ocelot.c | 35 +- > > include/linux/ioport.h | 5 + > > include/soc/mscc/ocelot.h | 19 ++ > > include/soc/mscc/vsc7514_regs.h | 6 + > > 22 files changed, 1251 insertions(+), 258 deletions(-) > > create mode 100644 drivers/mfd/ocelot-core.c > > create mode 100644 drivers/mfd/ocelot-spi.c > > create mode 100644 drivers/mfd/ocelot.h > > create mode 100644 drivers/net/dsa/ocelot/ocelot_ext.c > > > > -- > > 2.25.1 > >
On Mon, May 09, 2022 at 05:13:05PM +0000, Vladimir Oltean wrote: > Hi Colin, > > On Sun, May 08, 2022 at 11:52:57AM -0700, Colin Foster wrote: > > Why does this get printed, if you put a dump_stack() in of_dma_configure_id()? Below. I'm one of the only users of IORESOURCE_REG, from what I can tell... Not sure if that's any consolation. > > > [ 2.835718] pinctrl-ocelot ocelot-pinctrl.0.auto: invalid resource > > [ 2.842717] gpiochip_find_base: found new base at 2026 > > [ 2.842774] gpio gpiochip4: (ocelot-gpio): created GPIO range 0->21 ==> ocelot-pinctrl.0.auto PIN 0->21 > > [ 2.845693] gpio gpiochip4: (ocelot-gpio): added GPIO chardev (254:4) > > [ 2.845828] gpio gpiochip4: registered GPIOs 2026 to 2047 on ocelot-gpio > > [ 2.845855] pinctrl-ocelot ocelot-pinctrl.0.auto: driver registered > > [ 2.855925] pinctrl-microchip-sgpio ocelot-sgpio.1.auto: DMA mask not set > > [ 2.863089] pinctrl-microchip-sgpio ocelot-sgpio.1.auto: invalid resource > > [ 2.870801] gpiochip_find_base: found new base at 1962 > > [ 2.871528] gpio_stub_drv gpiochip5: (ocelot-sgpio.1.auto-input): added GPIO chardev (254:5) > > [ 2.871666] gpio_stub_drv gpiochip5: registered GPIOs 1962 to 2025 on ocelot-sgpio.1.auto-input > > [ 2.872364] gpiochip_find_base: found new base at 1898 > > [ 2.873244] gpio_stub_drv gpiochip6: (ocelot-sgpio.1.auto-output): added GPIO chardev (254:6) > > [ 2.873354] gpio_stub_drv gpiochip6: registered GPIOs 1898 to 1961 on ocelot-sgpio.1.auto-output > > [ 2.881148] mscc-miim ocelot-miim0.2.auto: DMA mask not set [ 16.699517] CPU: 0 PID: 7 Comm: kworker/u2:0 Not tainted 5.18.0-rc5-01315-g0a0ea78e3a79-dirty #632 [ 16.708574] Hardware name: Generic AM33XX (Flattened Device Tree) [ 16.714704] Workqueue: events_unbound deferred_probe_work_func [ 16.720608] Backtrace: [ 16.723071] dump_backtrace from show_stack+0x20/0x24 [ 16.728179] r7:c31bcc10 r6:00000000 r5:c1647b38 r4:a0000013 [ 16.733863] show_stack from dump_stack_lvl+0x60/0x78 [ 16.738954] dump_stack_lvl from dump_stack+0x18/0x1c [ 16.744040] r7:c31bcc10 r6:c31bcc10 r5:c31bcc10 r4:00000000 [ 16.749724] dump_stack from of_dma_configure_id+0x48/0x314 [ 16.755335] of_dma_configure_id from platform_dma_configure+0x2c/0x38 [ 16.761911] r10:df9bf424 r9:df9bf424 r8:00000069 r7:c31bcc10 r6:c1bbac5c r5:c31bcc10 [ 16.769777] r4:00000000 [ 16.772320] platform_dma_configure from really_probe+0x78/0x298 platform_dma_configure gets called because... [ 16.778360] really_probe from __driver_probe_device+0x94/0xf4 [ 16.784230] r7:c31bcc10 r6:c31bcc10 r5:c1bbac5c r4:c31bcc10 [ 16.789913] __driver_probe_device from driver_probe_device+0x44/0xe0 [ 16.796391] r5:c1c51f28 r4:c1c51f24 [ 16.799980] driver_probe_device from __device_attach_driver+0x9c/0xc4 [ 16.806548] r9:df9bf424 r8:c1b9c728 r7:c1c51ef8 r6:c31bcc10 r5:e002191c r4:c1bbac5c [ 16.814326] __device_attach_driver from bus_for_each_drv+0x94/0xe4 [ 16.820635] r7:c1c51ef8 r6:c0a012e4 r5:e002191c r4:00000000 [ 16.826319] bus_for_each_drv from __device_attach+0x104/0x170 [ 16.832190] r6:00000001 r5:c31bcc54 r4:c31bcc10 [ 16.836827] __device_attach from device_initial_probe+0x1c/0x20 [ 16.842871] r6:c31bcc10 r5:c1b9ccd0 r4:c31bcc10 [ 16.847507] device_initial_probe from bus_probe_device+0x94/0x9c [ 16.853637] bus_probe_device from device_add+0x3ec/0x8b4 [ 16.859073] r7:c1c51ef8 r6:c31b9c00 r5:00000000 r4:c31bcc10 [ 16.864756] device_add from platform_device_add+0x100/0x210 [ 16.870455] r10:c1a21744 r9:c1a21724 r8:c31bcc10 r7:00000002 r6:c31bcc00 r5:c3201aa0 [ 16.878320] r4:00000002 [ 16.880864] platform_device_add from mfd_add_devices+0x308/0x62c platform_device_add sets up pdev->bus = &platform_bus_type; That assignment looks to date back to the before times... Now you have me curious. And a little scared :-) [ 16.887008] r10:00000000 r9:00000000 r8:00000000 r7:00000002 r6:c31bcc00 r5:c3201a40 [ 16.894875] r4:c12be398 r3:00000000 [ 16.898465] mfd_add_devices from devm_mfd_add_devices+0x80/0xc0 [ 16.904514] r10:df9be9bc r9:df9be9bc r8:00000005 r7:c12be2e8 r6:fffffffe r5:c31b9c00 [ 16.912381] r4:c31ecc40 [ 16.914924] devm_mfd_add_devices from ocelot_core_init+0x40/0x6c [ 16.921058] r8:00000065 r7:c31b9c00 r6:c31ec9c0 r5:00000000 r4:c31b9c00 [ 16.927790] ocelot_core_init from ocelot_spi_probe+0xf4/0x188 [ 16.933662] r5:00000000 r4:c31b9c00 [ 16.937251] ocelot_spi_probe from spi_probe+0x94/0xb8 [ 16.942434] r7:c31b9c00 r6:c1b9fc60 r5:c31b9c00 r4:00000000 [ 16.948118] spi_probe from really_probe+0x110/0x298 [ 16.953116] r7:c31b9c00 r6:c1b9fc70 r5:c31b9c00 r4:00000000 [ 16.958800] really_probe from __driver_probe_device+0x94/0xf4 [ 16.964669] r7:c31b9c00 r6:c31b9c00 r5:c1b9fc70 r4:c31b9c00 [ 16.970354] __driver_probe_device from driver_probe_device+0x44/0xe0 [ 16.976832] r5:c1c51f28 r4:c1c51f24 [ 16.980422] driver_probe_device from __device_attach_driver+0x9c/0xc4 [ 16.986991] r9:df9be9bc r8:c1b9c728 r7:c1c51ef8 r6:c31b9c00 r5:e0021bc4 r4:c1b9fc70 [ 16.994768] __device_attach_driver from bus_for_each_drv+0x94/0xe4 [ 17.001077] r7:c1c51ef8 r6:c0a012e4 r5:e0021bc4 r4:00000000 [ 17.006762] bus_for_each_drv from __device_attach+0x104/0x170 [ 17.012632] r6:00000001 r5:c31b9c44 r4:c31b9c00 [ 17.017269] __device_attach from device_initial_probe+0x1c/0x20 [ 17.023311] r6:c31b9c00 r5:c1bb0a50 r4:c31b9c00 [ 17.027948] device_initial_probe from bus_probe_device+0x94/0x9c [ 17.034077] bus_probe_device from device_add+0x3ec/0x8b4 [ 17.039513] r7:c1c51ef8 r6:c31b9800 r5:00000000 r4:c31b9c00 [ 17.045197] device_add from __spi_add_device+0x7c/0x10c [ 17.050550] r10:c1c53844 r9:c30ec810 r8:00000001 r7:c30ec810 r6:c31b9800 r5:c31b9c00 [ 17.058415] r4:00000000 [ 17.060959] __spi_add_device from spi_add_device+0x48/0x78 [ 17.066568] r7:00000000 r6:c31b9800 r5:c31b9c00 r4:c31b9a1c [ 17.072252] spi_add_device from of_register_spi_device+0x258/0x390 [ 17.078556] r5:df9be9a0 r4:c31b9c00 [ 17.082147] of_register_spi_device from spi_register_controller+0x26c/0x6d8 [ 17.089239] r8:c17105c0 r7:df9bea04 r6:df9be9a0 r5:00000000 r4:c31b9800 [ 17.095970] spi_register_controller from devm_spi_register_controller+0x24/0x60 [ 17.103412] r10:c1c53844 r9:c31e9584 r8:c31b9800 r7:c31b9800 r6:c30ec810 r5:c31b9800 [ 17.111278] r4:c31b9bc0 [ 17.113822] devm_spi_register_controller from omap2_mcspi_probe+0x4c8/0x574 [ 17.120924] r7:c31b9800 r6:00000000 r5:c30ec940 r4:c31b9bc0 [ 17.126608] omap2_mcspi_probe from platform_probe+0x6c/0xc8 [ 17.132308] r10:c1bf0f80 r9:c202f00d r8:00000065 r7:c30ec810 r6:c1bb1d00 r5:c30ec810 [ 17.140174] r4:00000000 [ 17.142717] platform_probe from really_probe+0x110/0x298 [ 17.148151] r7:c30ec810 r6:c1bb1d00 r5:c30ec810 r4:00000000 [ 17.153835] really_probe from __driver_probe_device+0x94/0xf4 [ 17.159704] r7:c30ec810 r6:c30ec810 r5:c1bb1d00 r4:c30ec810 [ 17.165387] __driver_probe_device from driver_probe_device+0x44/0xe0 [ 17.171865] r5:c1c51f28 r4:c1c51f24 [ 17.175455] driver_probe_device from __device_attach_driver+0x9c/0xc4 [ 17.182023] r9:c202f00d r8:c1b9ca1c r7:00000000 r6:c30ec810 r5:e0021e84 r4:c1bb1d00 [ 17.189800] __device_attach_driver from bus_for_each_drv+0x94/0xe4 [ 17.196108] r7:00000000 r6:c0a012e4 r5:e0021e84 r4:00000000 [ 17.201792] bus_for_each_drv from __device_attach+0x104/0x170 [ 17.207661] r6:00000001 r5:c30ec854 r4:c30ec810 [ 17.212299] __device_attach from device_initial_probe+0x1c/0x20 [ 17.218342] r6:c30ec810 r5:c1b9ccd0 r4:c30ec810 [ 17.222979] device_initial_probe from bus_probe_device+0x94/0x9c [ 17.229109] bus_probe_device from deferred_probe_work_func+0x8c/0xb8 [ 17.235594] r7:00000000 r6:c1b9ca30 r5:c1b9ca1c r4:c30ec810 [ 17.241277] deferred_probe_work_func from process_one_work+0x1e0/0x53c [ 17.247950] r9:c202f00d r8:00000000 r7:c202f000 r6:c2020a00 r5:c2156500 r4:c1b9ca5c [ 17.255728] process_one_work from worker_thread+0x238/0x4fc [ 17.261428] r10:c2020a00 r9:00000088 r8:c1a03d00 r7:c2020a1c r6:c2156518 r5:c2020a00 [ 17.269293] r4:c2156500 [ 17.271836] worker_thread from kthread+0x108/0x138 [ 17.276757] r10:00000000 r9:e0009e4c r8:c2160cc0 r7:c21a6a80 r6:c2156500 r5:c036aac8 [ 17.284624] r4:c2160900 [ 17.287168] kthread from ret_from_fork+0x14/0x2c [ 17.291904] Exception stack(0xe0021fb0 to 0xe0021ff8) [ 17.296982] 1fa0: 00000000 00000000 00000000 00000000 [ 17.305202] 1fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 17.313420] 1fe0: 00000000 00000000 00000000 00000000 00000013 00000000 [ 17.320069] r9:00000000 r8:00000000 r7:00000000 r6:00000000 r5:c037341c r4:c2160900 [ 17.328184] mscc-miim ocelot-miim0.2.auto: DMA mask not set
On Mon, May 09, 2022 at 07:57:48PM -0700, Colin Foster wrote: > On Mon, May 09, 2022 at 05:13:05PM +0000, Vladimir Oltean wrote: > > Hi Colin, > > > > On Sun, May 08, 2022 at 11:52:57AM -0700, Colin Foster wrote: > > > > Why does this get printed, if you put a dump_stack() in of_dma_configure_id()? > > Below. I'm one of the only users of IORESOURCE_REG, from what I can > tell... Not sure if that's any consolation. > > > > > > [ 2.835718] pinctrl-ocelot ocelot-pinctrl.0.auto: invalid resource > > > [ 2.842717] gpiochip_find_base: found new base at 2026 > > > [ 2.842774] gpio gpiochip4: (ocelot-gpio): created GPIO range 0->21 ==> ocelot-pinctrl.0.auto PIN 0->21 > > > [ 2.845693] gpio gpiochip4: (ocelot-gpio): added GPIO chardev (254:4) > > > [ 2.845828] gpio gpiochip4: registered GPIOs 2026 to 2047 on ocelot-gpio > > > [ 2.845855] pinctrl-ocelot ocelot-pinctrl.0.auto: driver registered > > > [ 2.855925] pinctrl-microchip-sgpio ocelot-sgpio.1.auto: DMA mask not set > > > [ 2.863089] pinctrl-microchip-sgpio ocelot-sgpio.1.auto: invalid resource > > > [ 2.870801] gpiochip_find_base: found new base at 1962 > > > [ 2.871528] gpio_stub_drv gpiochip5: (ocelot-sgpio.1.auto-input): added GPIO chardev (254:5) > > > [ 2.871666] gpio_stub_drv gpiochip5: registered GPIOs 1962 to 2025 on ocelot-sgpio.1.auto-input > > > [ 2.872364] gpiochip_find_base: found new base at 1898 > > > [ 2.873244] gpio_stub_drv gpiochip6: (ocelot-sgpio.1.auto-output): added GPIO chardev (254:6) > > > [ 2.873354] gpio_stub_drv gpiochip6: registered GPIOs 1898 to 1961 on ocelot-sgpio.1.auto-output > > > [ 2.881148] mscc-miim ocelot-miim0.2.auto: DMA mask not set > > [ 16.699517] CPU: 0 PID: 7 Comm: kworker/u2:0 Not tainted 5.18.0-rc5-01315-g0a0ea78e3a79-dirty #632 > [ 16.708574] Hardware name: Generic AM33XX (Flattened Device Tree) > [ 16.714704] Workqueue: events_unbound deferred_probe_work_func > [ 16.720608] Backtrace: > [ 16.755335] of_dma_configure_id from platform_dma_configure+0x2c/0x38 > [ 16.772320] platform_dma_configure from really_probe+0x78/0x298 > > platform_dma_configure gets called because... > > [ 16.778360] really_probe from __driver_probe_device+0x94/0xf4 > [ 16.789913] __driver_probe_device from driver_probe_device+0x44/0xe0 > [ 16.799980] driver_probe_device from __device_attach_driver+0x9c/0xc4 > [ 16.814326] __device_attach_driver from bus_for_each_drv+0x94/0xe4 > [ 16.826319] bus_for_each_drv from __device_attach+0x104/0x170 > [ 16.836827] __device_attach from device_initial_probe+0x1c/0x20 > [ 16.847507] device_initial_probe from bus_probe_device+0x94/0x9c > [ 16.853637] bus_probe_device from device_add+0x3ec/0x8b4 > [ 16.864756] device_add from platform_device_add+0x100/0x210 > [ 16.880864] platform_device_add from mfd_add_devices+0x308/0x62c > > platform_device_add sets up pdev->bus = &platform_bus_type; This part is clear. MFD cells are platform devices which have an of_node, so platform_dma_configure() calls of_dma_configure_id(). > That assignment looks to date back to the before times... Now you have > me curious. And a little scared :-) > > [ 16.898465] mfd_add_devices from devm_mfd_add_devices+0x80/0xc0 > [ 16.914924] devm_mfd_add_devices from ocelot_core_init+0x40/0x6c > [ 16.927790] ocelot_core_init from ocelot_spi_probe+0xf4/0x188 > [ 16.937251] ocelot_spi_probe from spi_probe+0x94/0xb8 > [ 16.948118] spi_probe from really_probe+0x110/0x298 > [ 16.958800] really_probe from __driver_probe_device+0x94/0xf4 > [ 16.970354] __driver_probe_device from driver_probe_device+0x44/0xe0 > [ 16.980422] driver_probe_device from __device_attach_driver+0x9c/0xc4 > [ 16.994768] __device_attach_driver from bus_for_each_drv+0x94/0xe4 > [ 17.006762] bus_for_each_drv from __device_attach+0x104/0x170 > [ 17.017269] __device_attach from device_initial_probe+0x1c/0x20 > [ 17.027948] device_initial_probe from bus_probe_device+0x94/0x9c > [ 17.034077] bus_probe_device from device_add+0x3ec/0x8b4 > [ 17.045197] device_add from __spi_add_device+0x7c/0x10c > [ 17.060959] __spi_add_device from spi_add_device+0x48/0x78 > [ 17.072252] spi_add_device from of_register_spi_device+0x258/0x390 > [ 17.082147] of_register_spi_device from spi_register_controller+0x26c/0x6d8 > [ 17.095970] spi_register_controller from devm_spi_register_controller+0x24/0x60 > [ 17.113822] devm_spi_register_controller from omap2_mcspi_probe+0x4c8/0x574 > [ 17.126608] omap2_mcspi_probe from platform_probe+0x6c/0xc8 > [ 17.142717] platform_probe from really_probe+0x110/0x298 > [ 17.153835] really_probe from __driver_probe_device+0x94/0xf4 > [ 17.165387] __driver_probe_device from driver_probe_device+0x44/0xe0 > [ 17.175455] driver_probe_device from __device_attach_driver+0x9c/0xc4 > [ 17.189800] __device_attach_driver from bus_for_each_drv+0x94/0xe4 > [ 17.201792] bus_for_each_drv from __device_attach+0x104/0x170 > [ 17.212299] __device_attach from device_initial_probe+0x1c/0x20 > [ 17.222979] device_initial_probe from bus_probe_device+0x94/0x9c > [ 17.229109] bus_probe_device from deferred_probe_work_func+0x8c/0xb8 > [ 17.241277] deferred_probe_work_func from process_one_work+0x1e0/0x53c > [ 17.255728] process_one_work from worker_thread+0x238/0x4fc > [ 17.271836] worker_thread from kthread+0x108/0x138 > [ 17.328184] mscc-miim ocelot-miim0.2.auto: DMA mask not set Unfortunately I don't have any hardware to test, but I think what happens is: mfd_add_device() { calls platform_device_alloc() calls setup_pdev_dma_masks() sets up the default pdev->dev.dma_mask pointer overwrites pdev->dev.dma_mask with parent->dma_mask; // your parent->dma_mask is NULL calls platform_device_add() ... calls of_dma_configure_id complains that pdev->dev.dma_mask is NULL (i.e. the bus hasn't bothered setting up a default DMA mask, which in fact it did) } I don't have enough background regarding the justification for commit b018e1361bad ("mfd: core: Copy DMA mask and params from parent"), but it might be detrimential in some cases? The warning is printed since the slightly unrelated commit 4d8bde883bfb ("OF: Don't set default coherent DMA mask").
On Mon, May 09, 2022 at 05:13:05PM +0000, Vladimir Oltean wrote: > Hi Colin, > > On Sun, May 08, 2022 at 11:52:57AM -0700, Colin Foster wrote: > > > > mdio0: mdio0@0 { > > This is going to be interesting. Some drivers with multiple MDIO buses > create an "mdios" container with #address-cells = <1> and put the MDIO > bus nodes under that. Others create an "mdio" node and an "mdio0" node > (and no address for either of them). > > The problem with the latter approach is that > Documentation/devicetree/bindings/net/mdio.yaml does not accept the > "mdio0"/"mdio1" node name for an MDIO bus. I'm starting this implementation. Yep - it is interesting. A quick grep for "mdios" only shows one hit: arch/arm64/boot/dts/freescale/fsl-lx2160a-bluebox3.dts While that has an mdios field (two, actually), each only has one mdio bus, and they all seem to get parsed / registered through sja1105_mdiobus_.*_register. Is this change correct (I have a feeling it isn't): ocelot-chip@0 { #address-cells = <1>; #size-cells = <0>; ... mdio0: mdio@0 { reg=<0>; ... }; mdio1: mdio@1 { reg = <1>; ... }; ... }; When I run this with MFD's (use,)of_reg, things work as I'd expect. But I don't directly have the option to use an "mdios" container here because MFD runs "for_each_child_of_node" doesn't dig into mdios->mdio0... > > > compatible = "mscc,ocelot-miim"; > > #address-cells = <1>; > > #size-cells = <0>; > > > > sw_phy0: ethernet-phy@0 { > > reg = <0x0>; > > }; > > > > sw_phy1: ethernet-phy@1 { > > reg = <0x1>; > > }; > > > > sw_phy2: ethernet-phy@2 { > > reg = <0x2>; > > }; > > > > sw_phy3: ethernet-phy@3 { > > reg = <0x3>; > > }; > > }; > > > > mdio1: mdio1@1 { > > compatible = "mscc,ocelot-miim"; > > pinctrl-names = "default"; > > pinctrl-0 = <&miim1>; > > #address-cells = <1>; > > #size-cells = <0>; > > > > sw_phy4: ethernet-phy@4 { > > reg = <0x4>; > > }; > > > > sw_phy5: ethernet-phy@5 { > > reg = <0x5>; > > }; > > > > sw_phy6: ethernet-phy@6 { > > reg = <0x6>; > > }; > > > > sw_phy7: ethernet-phy@7 { > > reg = <0x7>; > > }; > > }; > >
Hi Colin, On Sat, May 14, 2022 at 03:00:10PM -0700, Colin Foster wrote: > On Mon, May 09, 2022 at 05:13:05PM +0000, Vladimir Oltean wrote: > > Hi Colin, > > > > On Sun, May 08, 2022 at 11:52:57AM -0700, Colin Foster wrote: > > > > > > mdio0: mdio0@0 { > > > > This is going to be interesting. Some drivers with multiple MDIO buses > > create an "mdios" container with #address-cells = <1> and put the MDIO > > bus nodes under that. Others create an "mdio" node and an "mdio0" node > > (and no address for either of them). > > > > The problem with the latter approach is that > > Documentation/devicetree/bindings/net/mdio.yaml does not accept the > > "mdio0"/"mdio1" node name for an MDIO bus. > > I'm starting this implementation. Yep - it is interesting. > > A quick grep for "mdios" only shows one hit: > arch/arm64/boot/dts/freescale/fsl-lx2160a-bluebox3.dts > > While that has an mdios field (two, actually), each only has one mdio > bus, and they all seem to get parsed / registered through > sja1105_mdiobus_.*_register. > > > Is this change correct (I have a feeling it isn't): > > ocelot-chip@0 { > #address-cells = <1>; > #size-cells = <0>; > > ... > > mdio0: mdio@0 { > reg=<0>; > ... > }; > > mdio1: mdio@1 { > reg = <1>; > ... > }; > ... > }; > > When I run this with MFD's (use,)of_reg, things work as I'd expect. But > I don't directly have the option to use an "mdios" container here > because MFD runs "for_each_child_of_node" doesn't dig into > mdios->mdio0... Sorry for the delayed response. I think you can avoid creating an "mdios" container node, but you need to provide some "reg" values based on which the MDIO controllers can be distinguished. What is your convention for "reg" values of MFD cells? Maybe pass the base address/size of this device's regmap as the "reg", even if the driver itself won't use it?
Hi Vladimir, On Thu, May 19, 2022 at 02:44:41PM +0000, Vladimir Oltean wrote: > Hi Colin, > > On Sat, May 14, 2022 at 03:00:10PM -0700, Colin Foster wrote: > > On Mon, May 09, 2022 at 05:13:05PM +0000, Vladimir Oltean wrote: > > > Hi Colin, > > > > > > On Sun, May 08, 2022 at 11:52:57AM -0700, Colin Foster wrote: > > > > > > > > mdio0: mdio0@0 { > > > > > > This is going to be interesting. Some drivers with multiple MDIO buses > > > create an "mdios" container with #address-cells = <1> and put the MDIO > > > bus nodes under that. Others create an "mdio" node and an "mdio0" node > > > (and no address for either of them). > > > > > > The problem with the latter approach is that > > > Documentation/devicetree/bindings/net/mdio.yaml does not accept the > > > "mdio0"/"mdio1" node name for an MDIO bus. > > > > I'm starting this implementation. Yep - it is interesting. > > > > A quick grep for "mdios" only shows one hit: > > arch/arm64/boot/dts/freescale/fsl-lx2160a-bluebox3.dts > > > > While that has an mdios field (two, actually), each only has one mdio > > bus, and they all seem to get parsed / registered through > > sja1105_mdiobus_.*_register. > > > > > > Is this change correct (I have a feeling it isn't): > > > > ocelot-chip@0 { > > #address-cells = <1>; > > #size-cells = <0>; > > > > ... > > > > mdio0: mdio@0 { > > reg=<0>; > > ... > > }; > > > > mdio1: mdio@1 { > > reg = <1>; > > ... > > }; > > ... > > }; > > > > When I run this with MFD's (use,)of_reg, things work as I'd expect. But > > I don't directly have the option to use an "mdios" container here > > because MFD runs "for_each_child_of_node" doesn't dig into > > mdios->mdio0... > > Sorry for the delayed response. I think you can avoid creating an > "mdios" container node, but you need to provide some "reg" values based > on which the MDIO controllers can be distinguished. What is your convention > for "reg" values of MFD cells? Maybe pass the base address/size of this > device's regmap as the "reg", even if the driver itself won't use it? No worries. Everyone is busy. Right now it looks like this: }, { .name = "ocelot-miim0", .of_compatible = "mscc,ocelot-miim", .of_reg = 0, .use_of_reg = true, .num_resources = ARRAY_SIZE(vsc7512_miim0_resources), .resources = vsc7512_miim0_resources, }, { .name = "ocelot-miim1", .of_compatible = "mscc,ocelot-miim", .num_resources = ARRAY_SIZE(vsc7512_miim1_resources), .of_reg = 1, .use_of_reg = true, .resources = vsc7512_miim1_resources, }, { "0" and "1" being somewhat arbitrary... although they are named as such in the datasheet. So you're thinking it might look more like: .of_reg = vsc7512_miim0_resources[0].start, and the device tree would be: mdio0: mdio@0x7107009c { reg = <0x7107009c>; }; I could see that making sense. The main thing I don't like is applying the address-cells to every peripheral in the switch. It seems incorrect to have: switch { address-cells = <1>; mdio0: mdio@7107009c { reg = <0x7107009c>; }; gpio: pinctrl { /* No reg parameter */ }; }; That's what I currently have. To my surprise it actually doesn't throw any warnings, which I would've expected. I could see either 0/1 or the actual base addresses making sense. Whichever you'd suggest. I've got another day or two to button things up, so it looks like I missed the boat for this release. This should be ready to go on day 1 after the window.
On Thu, May 19, 2022 at 09:15:00AM -0700, Colin Foster wrote: > Hi Vladimir, > > On Thu, May 19, 2022 at 02:44:41PM +0000, Vladimir Oltean wrote: > > Hi Colin, > > > > On Sat, May 14, 2022 at 03:00:10PM -0700, Colin Foster wrote: > > > On Mon, May 09, 2022 at 05:13:05PM +0000, Vladimir Oltean wrote: > > > > Hi Colin, > > > > > > > > On Sun, May 08, 2022 at 11:52:57AM -0700, Colin Foster wrote: > > > > > > > > > > mdio0: mdio0@0 { > > > > > > > > This is going to be interesting. Some drivers with multiple MDIO buses > > > > create an "mdios" container with #address-cells = <1> and put the MDIO > > > > bus nodes under that. Others create an "mdio" node and an "mdio0" node > > > > (and no address for either of them). > > > > > > > > The problem with the latter approach is that > > > > Documentation/devicetree/bindings/net/mdio.yaml does not accept the > > > > "mdio0"/"mdio1" node name for an MDIO bus. > > > > > > I'm starting this implementation. Yep - it is interesting. > > > > > > A quick grep for "mdios" only shows one hit: > > > arch/arm64/boot/dts/freescale/fsl-lx2160a-bluebox3.dts > > > > > > While that has an mdios field (two, actually), each only has one mdio > > > bus, and they all seem to get parsed / registered through > > > sja1105_mdiobus_.*_register. > > > > > > > > > Is this change correct (I have a feeling it isn't): > > > > > > ocelot-chip@0 { > > > #address-cells = <1>; > > > #size-cells = <0>; > > > > > > ... > > > > > > mdio0: mdio@0 { > > > reg=<0>; > > > ... > > > }; > > > > > > mdio1: mdio@1 { > > > reg = <1>; > > > ... > > > }; > > > ... > > > }; > > > > > > When I run this with MFD's (use,)of_reg, things work as I'd expect. But > > > I don't directly have the option to use an "mdios" container here > > > because MFD runs "for_each_child_of_node" doesn't dig into > > > mdios->mdio0... > > > > Sorry for the delayed response. I think you can avoid creating an > > "mdios" container node, but you need to provide some "reg" values based > > on which the MDIO controllers can be distinguished. What is your convention > > for "reg" values of MFD cells? Maybe pass the base address/size of this > > device's regmap as the "reg", even if the driver itself won't use it? > > No worries. Everyone is busy. > > Right now it looks like this: > > }, { > .name = "ocelot-miim0", > .of_compatible = "mscc,ocelot-miim", > .of_reg = 0, > .use_of_reg = true, > .num_resources = ARRAY_SIZE(vsc7512_miim0_resources), > .resources = vsc7512_miim0_resources, > }, { > .name = "ocelot-miim1", > .of_compatible = "mscc,ocelot-miim", > .num_resources = ARRAY_SIZE(vsc7512_miim1_resources), > .of_reg = 1, > .use_of_reg = true, > .resources = vsc7512_miim1_resources, > }, { > > "0" and "1" being somewhat arbitrary... although they are named as such > in the datasheet. > > > So you're thinking it might look more like: > > .of_reg = vsc7512_miim0_resources[0].start, > > and the device tree would be: > > mdio0: mdio@0x7107009c { > reg = <0x7107009c>; > }; Yeah, this is what I was thinking. > I could see that making sense. The main thing I don't like is applying > the address-cells to every peripheral in the switch. It seems incorrect > to have: > > switch { > address-cells = <1>; > mdio0: mdio@7107009c { > reg = <0x7107009c>; > }; > gpio: pinctrl { > /* No reg parameter */ > }; > }; > > That's what I currently have. To my surprise it actually doesn't throw > any warnings, which I would've expected. I tried mangling some device trees and indeed it looks like dtc won't warn, but I still think it's invalid to mix node address conventions with the same #address-cells. Maybe if that wasn't the case things would be easier. > I could see either 0/1 or the actual base addresses making sense. > Whichever you'd suggest. The idea with putting the actual base addresses was that you could then do that for all cells, like the pinctrl node, too, and they'd have a coherent meaning. > I've got another day or two to button things up, so it looks like I > missed the boat for this release. This should be ready to go on day 1 > after the window.
The patch set in general is to add support for the VSC7512, and eventually the VSC7511, VSC7513 and VSC7514 devices controlled over SPI. The driver is believed to be fully functional for the internal phy ports (0-3) on the VSC7512. It is not yet functional for SGMII, QSGMII, and SerDes ports. I have mentioned previously: The hardware setup I'm using for development is a beaglebone black, with jumpers from SPI0 to the microchip VSC7512 dev board. The microchip dev board has been modified to not boot from flash, but wait for SPI. An ethernet cable is connected from the beaglebone ethernet to port 0 of the dev board. The relevant sections of the device tree I'm using for the VSC7512 is below. Notably the SGPIO LEDs follow link status and speed from network triggers. In order to make this work, I have modified the cpsw driver, and now the cpsw_new driver, to allow for frames over 1500 bytes. Otherwise the tagging protocol will not work between the beaglebone and the VSC7512. I plan to eventually try to get those changes in mainline, but I don't want to get distracted from my initial goal. I also had to change bonecommon.dtsi to avoid using VLAN 0. I believe much of the MFD sections are very near feature-complete, whereas the switch section will require ongoing work to enable additional ports / features. This could lead to a couple potential scenarios: The first being patches 1-8 being split into a separate patch set, while patches 9-16 remain in the RFC state. This would offer the pinctrl / sgpio / mdio controller functionality, but no switch control until it is ready. The second would assume the current state of the switch driver is acceptable (or at least very near so) and the current patch set gets an official PATCH set (with minor changes as necessary - e.g. squashing patch 16 into 14). That might be ambitious. The third would be to keep this patch set in RFC until switch functionality is more complete. I'd understand if this was the desired path... but it would mean me having to bug more reviewers. / { vscleds { compatible = "gpio-leds"; vscled@0 { label = "port0led"; gpios = <&sgpio_out1 0 0 GPIO_ACTIVE_LOW>; default-state = "off"; linux,default-trigger = "ocelot-miim0.2.auto-mii:00:link"; }; vscled@1 { label = "port0led1"; gpios = <&sgpio_out1 0 1 GPIO_ACTIVE_LOW>; default-state = "off"; linux,default-trigger = "ocelot-miim0.2.auto-mii:00:1Gbps"; }; [ ... ] }; }; &spi0 { #address-cells = <1>; #size-cells = <0>; status = "okay"; ocelot-chip@0 { compatible = "mscc,vsc7512_mfd_spi"; spi-max-frequency = <2500000>; reg = <0>; ethernet-switch@0 { compatible = "mscc,vsc7512-ext-switch"; ports { #address-cells = <1>; #size-cells = <0>; port@0 { reg = <0>; label = "cpu"; status = "okay"; ethernet = <&mac_sw>; phy-handle = <&sw_phy0>; phy-mode = "internal"; }; port@1 { reg = <1>; label = "swp1"; status = "okay"; phy-handle = <&sw_phy1>; phy-mode = "internal"; }; }; }; mdio0: mdio0@0 { compatible = "mscc,ocelot-miim"; #address-cells = <1>; #size-cells = <0>; sw_phy0: ethernet-phy@0 { reg = <0x0>; }; sw_phy1: ethernet-phy@1 { reg = <0x1>; }; sw_phy2: ethernet-phy@2 { reg = <0x2>; }; sw_phy3: ethernet-phy@3 { reg = <0x3>; }; }; mdio1: mdio1@1 { compatible = "mscc,ocelot-miim"; pinctrl-names = "default"; pinctrl-0 = <&miim1>; #address-cells = <1>; #size-cells = <0>; sw_phy4: ethernet-phy@4 { reg = <0x4>; }; sw_phy5: ethernet-phy@5 { reg = <0x5>; }; sw_phy6: ethernet-phy@6 { reg = <0x6>; }; sw_phy7: ethernet-phy@7 { reg = <0x7>; }; }; gpio: pinctrl@0 { compatible = "mscc,ocelot-pinctrl"; gpio-controller; #gpio_cells = <2>; gpio-ranges = <&gpio 0 0 22>; led_shift_reg_pins: led-shift-reg-pins { pins = "GPIO_0", "GPIO_1", "GPIO_2", "GPIO_3"; function = "sg0"; }; miim1: miim1 { pins = "GPIO_14", "GPIO_15"; function = "miim"; }; }; sgpio: sgpio { compatible = "mscc,ocelot-sgpio"; #address-cells = <1>; #size-cells = <0>; bus-frequency=<12500000>; clocks = <&ocelot_clock>; microchip,sgpio-port-ranges = <0 15>; pinctrl-names = "default"; pinctrl-0 = <&led_shift_reg_pins>; sgpio_in0: sgpio@0 { compatible = "microchip,sparx5-sgpio-bank"; reg = <0>; gpio-controller; #gpio-cells = <3>; ngpios = <64>; }; sgpio_out1: sgpio@1 { compatible = "microchip,sparx5-sgpio-bank"; reg = <1>; gpio-controller; #gpio-cells = <3>; ngpios = <64>; }; }; }; }; And I'll include the relevant dmesg prints - I don't love the "invalid resource" prints, as they seem to be misleading. They're a byproduct of looking for IO resources before falling back to REG. [ 0.000000] Booting Linux on physical CPU 0x0 [ 0.000000] Linux version 5.18.0-rc5-01295-g47053e327c52 (X@X) (arm-linux-gnueabi-gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0, GNU ld (GNU Binutils for Ubuntu) 2.34) #630 SMP PREEMPT Sun May 8 10:56:51 PDT 2022 ... [ 2.829319] pinctrl-ocelot ocelot-pinctrl.0.auto: DMA mask not set [ 2.835718] pinctrl-ocelot ocelot-pinctrl.0.auto: invalid resource [ 2.842717] gpiochip_find_base: found new base at 2026 [ 2.842774] gpio gpiochip4: (ocelot-gpio): created GPIO range 0->21 ==> ocelot-pinctrl.0.auto PIN 0->21 [ 2.845693] gpio gpiochip4: (ocelot-gpio): added GPIO chardev (254:4) [ 2.845828] gpio gpiochip4: registered GPIOs 2026 to 2047 on ocelot-gpio [ 2.845855] pinctrl-ocelot ocelot-pinctrl.0.auto: driver registered [ 2.855925] pinctrl-microchip-sgpio ocelot-sgpio.1.auto: DMA mask not set [ 2.863089] pinctrl-microchip-sgpio ocelot-sgpio.1.auto: invalid resource [ 2.870801] gpiochip_find_base: found new base at 1962 [ 2.871528] gpio_stub_drv gpiochip5: (ocelot-sgpio.1.auto-input): added GPIO chardev (254:5) [ 2.871666] gpio_stub_drv gpiochip5: registered GPIOs 1962 to 2025 on ocelot-sgpio.1.auto-input [ 2.872364] gpiochip_find_base: found new base at 1898 [ 2.873244] gpio_stub_drv gpiochip6: (ocelot-sgpio.1.auto-output): added GPIO chardev (254:6) [ 2.873354] gpio_stub_drv gpiochip6: registered GPIOs 1898 to 1961 on ocelot-sgpio.1.auto-output [ 2.881148] mscc-miim ocelot-miim0.2.auto: DMA mask not set [ 2.886929] mscc-miim ocelot-miim0.2.auto: invalid resource [ 2.893738] mdio_bus ocelot-miim0.2.auto-mii: GPIO lookup for consumer reset [ 2.893769] mdio_bus ocelot-miim0.2.auto-mii: using device tree for GPIO lookup [ 2.893802] of_get_named_gpiod_flags: can't parse 'reset-gpios' property of node '/ocp/interconnect@48000000/segment@0/target-module@30000/spi@0/ocelot-chip@0/mdio0[0]' [ 2.893898] of_get_named_gpiod_flags: can't parse 'reset-gpio' property of node '/ocp/interconnect@48000000/segment@0/target-module@30000/spi@0/ocelot-chip@0/mdio0[0]' [ 2.893996] mdio_bus ocelot-miim0.2.auto-mii: using lookup tables for GPIO lookup [ 2.894012] mdio_bus ocelot-miim0.2.auto-mii: No GPIO consumer reset found [ 3.395738] mdio_bus ocelot-miim0.2.auto-mii:00: GPIO lookup for consumer reset [ 3.395777] mdio_bus ocelot-miim0.2.auto-mii:00: using device tree for GPIO lookup [ 3.395840] of_get_named_gpiod_flags: can't parse 'reset-gpios' property of node '/ocp/interconnect@48000000/segment@0/target-module@30000/spi@0/ocelot-chip@0/mdio0/ethernet-phy@0[0]' [ 3.395959] of_get_named_gpiod_flags: can't parse 'reset-gpio' property of node '/ocp/interconnect@48000000/segment@0/target-module@30000/spi@0/ocelot-chip@0/mdio0/ethernet-phy@0[0]' [ 3.396069] mdio_bus ocelot-miim0.2.auto-mii:00: using lookup tables for GPIO lookup [ 3.396086] mdio_bus ocelot-miim0.2.auto-mii:00: No GPIO consumer reset found ... [ 3.449187] ocelot-ext-switch ocelot-ext-switch.4.auto: DMA mask not set [ 5.336880] ocelot-ext-switch ocelot-ext-switch.4.auto: PHY [ocelot-miim0.2.auto-mii:00] driver [Generic PHY] (irq=POLL) [ 5.349087] ocelot-ext-switch ocelot-ext-switch.4.auto: configuring for phy/internal link mode [ 5.363619] ocelot-ext-switch ocelot-ext-switch.4.auto swp1 (uninitialized): PHY [ocelot-miim0.2.auto-mii:01] driver [Generic PHY] (irq=POLL) [ 5.381396] ocelot-ext-switch ocelot-ext-switch.4.auto swp2 (uninitialized): PHY [ocelot-miim0.2.auto-mii:02] driver [Generic PHY] (irq=POLL) [ 5.398525] ocelot-ext-switch ocelot-ext-switch.4.auto swp3 (uninitialized): PHY [ocelot-miim0.2.auto-mii:03] driver [Generic PHY] (irq=POLL) [ 5.422048] device eth0 entered promiscuous mode [ 5.426785] DSA: tree 0 setup ... [ 7.450067] ocelot-ext-switch ocelot-ext-switch.4.auto: Link is Up - 100Mbps/Full - flow control off [ 21.556395] cpsw-switch 4a100000.switch: starting ndev. mode: dual_mac [ 21.648564] SMSC LAN8710/LAN8720 4a101000.mdio:00: attached PHY driver (mii_bus:phy_addr=4a101000.mdio:00, irq=POLL) [ 21.667970] 8021q: adding VLAN 0 to HW filter on device eth0 [ 21.705360] ocelot-ext-switch ocelot-ext-switch.4.auto swp1: configuring for phy/internal link mode [ 22.018230] ocelot-ext-switch ocelot-ext-switch.4.auto: Link is Down [ 23.771740] cpsw-switch 4a100000.switch eth0: Link is Up - 100Mbps/Full - flow control off [ 24.090929] ocelot-ext-switch ocelot-ext-switch.4.auto: Link is Up - 100Mbps/Full - flow control off [ 25.853021] ocelot-ext-switch ocelot-ext-switch.4.auto swp1: Link is Up - 1Gbps/Full - flow control rx/tx RFC history: v1 (accidentally named vN) * Initial architecture. Not functional * General concepts laid out v2 * Near functional. No CPU port communication, but control over all external ports * Cleaned up regmap implementation from v1 v3 * Functional * Shared MDIO transactions routed through mdio-mscc-miim * CPU / NPI port enabled by way of vsc7512_enable_npi_port / felix->info->enable_npi_port * NPI port tagging functional - Requires a CPU port driver that supports frames of 1520 bytes. Verified with a patch to the cpsw driver v4 * Functional * Device tree fixes * Add hooks for pinctrl-ocelot - some functionality by way of sysfs * Add hooks for pinctrl-microsemi-sgpio - not yet fully functional * Remove lynx_pcs interface for a generic phylink_pcs. The goal here is to have an ocelot_pcs that will work for each configuration of every port. v5 * Restructured to MFD * Several commits were split out, submitted, and accepted * pinctrl-ocelot believed to be fully functional (requires commits from the linux-pinctrl tree) * External MDIO bus believed to be fully functional v6 * Applied several suggestions from the last RFC from Lee Jones. I hope I didn't miss anything. * Clean up MFD core - SPI interaction. They no longer use callbacks. * regmaps get registered to the child device, and don't attempt to get shared. It seems if a regmap is to be shared, that should be solved with syscon, not dev or mfd. v7 * Applied as much as I could from Lee and Vladimir's suggestions. As always, the feedback is greatly appreciated! * Remove "ocelot_spi" container complication * Move internal MDIO bus from ocelot_ext to MFD, with a devicetree change to match * Add initial HSIO support * Switch to IORESOURCE_REG for resource definitions v8 * Applied another round of suggestions from Lee and Vladimir * Utilize regmap bus reads, which speeds bulk transfers up by an order of magnitude * Add two additional patches to utilize phylink_generic_validate * Changed GPL V2 to GPL in licenses where applicable (checkpatch) * Remove initial hsio/serdes changes from the RFC Colin Foster (16): pinctrl: ocelot: allow pinctrl-ocelot to be loaded as a module pinctrl: microchip-sgpio: allow sgpio driver to be used as a module net: ocelot: add interface to get regmaps when exernally controlled net: mdio: mscc-miim: add ability to be used in a non-mmio configuration pinctrl: ocelot: add ability to be used in a non-mmio configuration pinctrl: microchip-sgpio: add ability to be used in a non-mmio configuration resource: add define macro for register address resources mfd: ocelot: add support for the vsc7512 chip via spi net: mscc: ocelot: expose ocelot wm functions net: dsa: felix: add configurable device quirks net: mscc: ocelot: expose regfield definition to be used by other drivers net: mscc: ocelot: expose stats layout definition to be used by other drivers net: mscc: ocelot: expose vcap_props structure net: dsa: ocelot: add external ocelot switch control net: dsa: felix: add phylink_get_caps capability net: dsa: ocelot: utilize phylink_generic_validate drivers/mfd/Kconfig | 18 + drivers/mfd/Makefile | 2 + drivers/mfd/ocelot-core.c | 138 ++++++++ drivers/mfd/ocelot-spi.c | 311 +++++++++++++++++ drivers/mfd/ocelot.h | 34 ++ drivers/net/dsa/ocelot/Kconfig | 14 + drivers/net/dsa/ocelot/Makefile | 5 + drivers/net/dsa/ocelot/felix.c | 29 +- drivers/net/dsa/ocelot/felix.h | 3 + drivers/net/dsa/ocelot/felix_vsc9959.c | 1 + drivers/net/dsa/ocelot/ocelot_ext.c | 366 +++++++++++++++++++++ drivers/net/dsa/ocelot/seville_vsc9953.c | 1 + drivers/net/ethernet/mscc/ocelot_devlink.c | 31 ++ drivers/net/ethernet/mscc/ocelot_vsc7514.c | 230 +------------ drivers/net/ethernet/mscc/vsc7514_regs.c | 200 +++++++++++ drivers/net/mdio/mdio-mscc-miim.c | 31 +- drivers/pinctrl/Kconfig | 4 +- drivers/pinctrl/pinctrl-microchip-sgpio.c | 26 +- drivers/pinctrl/pinctrl-ocelot.c | 35 +- include/linux/ioport.h | 5 + include/soc/mscc/ocelot.h | 19 ++ include/soc/mscc/vsc7514_regs.h | 6 + 22 files changed, 1251 insertions(+), 258 deletions(-) create mode 100644 drivers/mfd/ocelot-core.c create mode 100644 drivers/mfd/ocelot-spi.c create mode 100644 drivers/mfd/ocelot.h create mode 100644 drivers/net/dsa/ocelot/ocelot_ext.c