| Message ID | YoZPQNFPTQI/6ZhP@kili (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0097e86c8ec5a68f20bc1ae19f5c21fb0e751f83 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: ethernet: mtk_eth_soc: fix error code in mtk_flow_offload_replace() | expand |
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Thu, 19 May 2022 17:08:00 +0300 you wrote: > Preserve the error code from mtk_foe_entry_commit(). Do not return > success. > > Fixes: c4f033d9e03e ("net: ethernet: mtk_eth_soc: rework hardware flow table management") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > The original code used to preserve the error code. I'm pretty sure > returning an error is the correct thing. I guess please double check > this patch. > > [...] Here is the summary with links: - [net-next] net: ethernet: mtk_eth_soc: fix error code in mtk_flow_offload_replace() https://git.kernel.org/netdev/net-next/c/0097e86c8ec5 You are awesome, thank you!
diff --git a/drivers/net/ethernet/mediatek/mtk_ppe_offload.c b/drivers/net/ethernet/mediatek/mtk_ppe_offload.c index 1fe31058b0f2..a641a44323a9 100644 --- a/drivers/net/ethernet/mediatek/mtk_ppe_offload.c +++ b/drivers/net/ethernet/mediatek/mtk_ppe_offload.c @@ -434,7 +434,8 @@ mtk_flow_offload_replace(struct mtk_eth *eth, struct flow_cls_offload *f) memcpy(&entry->data, &foe, sizeof(entry->data)); entry->wed_index = wed_index; - if (mtk_foe_entry_commit(eth->ppe, entry) < 0) + err = mtk_foe_entry_commit(eth->ppe, entry); + if (err < 0) goto free; err = rhashtable_insert_fast(ð->flow_table, &entry->node,
Preserve the error code from mtk_foe_entry_commit(). Do not return success. Fixes: c4f033d9e03e ("net: ethernet: mtk_eth_soc: rework hardware flow table management") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- The original code used to preserve the error code. I'm pretty sure returning an error is the correct thing. I guess please double check this patch. drivers/net/ethernet/mediatek/mtk_ppe_offload.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)