[v5,0/6] Implement byteswap and update references

Message

Lin Liu （刘林） May 23, 2022, 2:50 p.m. UTC

Lin Liu (6):
  xen: implement byteswap
  crypto/vmac: Simplify code with byteswap
  arm64/find_next_bit: Remove ext2_swab()
  xen: Switch to byteswap
  tools: Use new byteswap helper
  byteorder: Remove byteorder

 .../libs/guest/xg_dom_decompress_unsafe_xz.c  |   5 +
 .../guest/xg_dom_decompress_unsafe_zstd.c     |   3 +-
 xen/arch/arm/arm64/lib/find_next_bit.c        |  36 +---
 xen/arch/arm/include/asm/byteorder.h          |   6 +-
 xen/arch/x86/include/asm/byteorder.h          |  34 +---
 xen/common/device_tree.c                      |  44 ++---
 xen/common/libelf/libelf-private.h            |   6 +-
 xen/common/xz/private.h                       |   2 +-
 xen/crypto/vmac.c                             |  76 +-------
 xen/include/xen/byteorder.h                   |  56 ++++++
 xen/include/xen/byteorder/big_endian.h        | 102 ----------
 xen/include/xen/byteorder/generic.h           |  68 -------
 xen/include/xen/byteorder/little_endian.h     | 102 ----------
 xen/include/xen/byteorder/swab.h              | 183 ------------------
 xen/include/xen/byteswap.h                    |  52 +++++
 xen/include/xen/compiler.h                    |  20 ++
 xen/include/xen/unaligned.h                   |  12 +-
 17 files changed, 184 insertions(+), 623 deletions(-)
 create mode 100644 xen/include/xen/byteorder.h
 delete mode 100644 xen/include/xen/byteorder/big_endian.h
 delete mode 100644 xen/include/xen/byteorder/generic.h
 delete mode 100644 xen/include/xen/byteorder/little_endian.h
 delete mode 100644 xen/include/xen/byteorder/swab.h
 create mode 100644 xen/include/xen/byteswap.h

Comments

Julien Grall May 23, 2022, 2:53 p.m. UTC | #1

Hi,

On 23/05/2022 15:50, Lin Liu wrote:
> ext2 has nothing to do with this logic.

You have again not addressed my comment. If you don't understand my 
comment then please ask.

Cheers,

Lin Liu （刘林） May 24, 2022, 1:35 a.m. UTC | #2

>>Hi,

>>On 23/05/2022 15:50, Lin Liu wrote:
> >ext2 has nothing to do with this logic.

>You have again not addressed my comment. If you don't understand my comment then please ask.

>Cheers,

>--
>Julien Grall

Sorry I missed this one as I saw this patch already got an some tags,  I suppose your comment requires commit message update, 
Will update it if a newer version is required. 

Cheers,
Lin

Julien Grall May 25, 2022, 7:53 a.m. UTC | #3

Hi,

On 24/05/2022 02:35, Lin Liu （刘林） wrote:
> 
>>> Hi,
> 
>>> On 23/05/2022 15:50, Lin Liu wrote:
>>> ext2 has nothing to do with this logic.
> 
>> You have again not addressed my comment. If you don't understand my comment then please ask.
> 
>> Cheers,
> 
>> --
>> Julien Grall
> 
> Sorry I missed this one as I saw this patch already got an some tags,

For smaller changes, we tend to provide the Reviewed-by/Acked-by at the 
same time. The comments may then be addressed on commit (if the 
committer is happy with that) or you could handle them on a respin.

>  I suppose your comment requires commit message update,

Yes. I would like the first sentence to be dropped or reworked.

> Will update it if a newer version is required.

Thanks! I would have committed now but AFAIU it depends on previous patches.

Cheers,