[0/4] ceph: convert to netfs_direct_read_iter for DIO reads

Message

Jeff Layton May 18, 2022, 3:11 p.m. UTC

This patch series is based on top of David Howells' netfs-lib branch.

I previously sent an RFC set for this back in early April, but David has
revised his netfs-lib branch since then. This converts ceph to use the
new DIO read helper netfs_direct_read_iter instead of using our own
routine.

With this change we ought to be able to rip out a large swath of
ceph_direct_read_write, but I've decided to wait on that until the write
helpers are in place and we can just remove that function wholesale.

David, do you mind carrying these patches in your tree? Given that they
depend on your netfs-lib branch, it's probably simpler to do it that way
rather than have us base the ceph-client master branch on yours. If
conflicts crop up, we can revisit that approach though.

David Howells (1):
  ceph: Use the provided iterator in ceph_netfs_issue_op()

Jeff Layton (3):
  netfs: fix sense of DIO test on short read
  ceph: enhance dout messages in issue_read codepaths
  ceph: switch to netfs_direct_read_iter

 fs/ceph/addr.c | 55 +++++++++++++++++++++++++++++++++-----------------
 fs/ceph/file.c |  3 +--
 fs/netfs/io.c  |  2 +-
 3 files changed, 38 insertions(+), 22 deletions(-)

Comments

Xiubo Li May 24, 2022, 2:42 a.m. UTC | #1

On 5/18/22 11:11 PM, Jeff Layton wrote:
> This patch series is based on top of David Howells' netfs-lib branch.
>
> I previously sent an RFC set for this back in early April, but David has
> revised his netfs-lib branch since then. This converts ceph to use the
> new DIO read helper netfs_direct_read_iter instead of using our own
> routine.
>
> With this change we ought to be able to rip out a large swath of
> ceph_direct_read_write, but I've decided to wait on that until the write
> helpers are in place and we can just remove that function wholesale.
>
> David, do you mind carrying these patches in your tree? Given that they
> depend on your netfs-lib branch, it's probably simpler to do it that way
> rather than have us base the ceph-client master branch on yours. If
> conflicts crop up, we can revisit that approach though.
>
> David Howells (1):
>    ceph: Use the provided iterator in ceph_netfs_issue_op()
>
> Jeff Layton (3):
>    netfs: fix sense of DIO test on short read
>    ceph: enhance dout messages in issue_read codepaths
>    ceph: switch to netfs_direct_read_iter
>
>   fs/ceph/addr.c | 55 +++++++++++++++++++++++++++++++++-----------------
>   fs/ceph/file.c |  3 +--
>   fs/netfs/io.c  |  2 +-
>   3 files changed, 38 insertions(+), 22 deletions(-)
>
This series LGTM.

Reviewed-by: Xiubo Li <[e-mail]>