diff mbox series

scsi: ufs: ufshcd: delete unnecessary NULL check

Message ID YotFotj43TkB8Rid@kili (mailing list archive)
State Accepted
Headers show
Series scsi: ufs: ufshcd: delete unnecessary NULL check | expand

Commit Message

Dan Carpenter May 23, 2022, 8:28 a.m. UTC 
The "info" pointer points to somewhere in the middle of the "hba" struct.
It can't possibly be NULL.  Delete the NULL check.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 drivers/ufs/core/ufshcd.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comments

Martin K. Petersen May 24, 2022, 3:14 a.m. UTC | #1 
Dan,

> The "info" pointer points to somewhere in the middle of the "hba"
> struct.  It can't possibly be NULL.  Delete the NULL check.

Applied to 5.19/scsi-staging, thanks!
Martin K. Petersen May 24, 2022, 6:11 p.m. UTC | #2 
On Mon, 23 May 2022 11:28:18 +0300, Dan Carpenter wrote:

> The "info" pointer points to somewhere in the middle of the "hba" struct.
> It can't possibly be NULL.  Delete the NULL check.
> 
> 

Applied to 5.19/scsi-queue, thanks!

[1/1] scsi: ufs: ufshcd: delete unnecessary NULL check
      https://git.kernel.org/mkp/scsi/c/476e45923b5d
diff mbox series

Patch

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index efe67a381c32..01fb4bad86be 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -8445,10 +8445,7 @@  static int ufshcd_init_hba_vreg(struct ufs_hba *hba)
 {
 	struct ufs_vreg_info *info = &hba->vreg_info;
 
-	if (info)
-		return ufshcd_get_vreg(hba->dev, info->vdd_hba);
-
-	return 0;
+	return ufshcd_get_vreg(hba->dev, info->vdd_hba);
 }
 
 static int ufshcd_setup_clocks(struct ufs_hba *hba, bool on)