| Message ID | 20220518064417.47473-1-yangx.jy@fujitsu.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [blktests] srp/011: Avoid $dev becoming invalid during test | expand |
On 5/18/22 08:44, Xiao Yang wrote: > $dev will become invalid when log_out has been done > and fio doesn't run yet. In this case subsequent fio > throws the following error: > ------------------------------------- > From diff -u 011.out 011.out.bad > Configured SRP target driver > -Passed > > From 011.full: > fio: looks like your file system does not support direct=1/buffered=0 > fio: destination does not support O_DIRECT > run_fio exit code: 1 > ------------------------------------- > This issue happens randomly. > > Try to fix the issue by holding $dev before test. Reviewed-by: Bart Van Assche <bvanassche@acm.org>
On May 18, 2022 / 14:44, Xiao Yang wrote: > $dev will become invalid when log_out has been done > and fio doesn't run yet. In this case subsequent fio > throws the following error: > ------------------------------------- > From diff -u 011.out 011.out.bad > Configured SRP target driver > -Passed > > From 011.full: > fio: looks like your file system does not support direct=1/buffered=0 > fio: destination does not support O_DIRECT > run_fio exit code: 1 > ------------------------------------- > This issue happens randomly. > > Try to fix the issue by holding $dev before test. > > Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com> Looks good to me. Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
On May 18, 2022 / 14:44, Xiao Yang wrote: > $dev will become invalid when log_out has been done > and fio doesn't run yet. In this case subsequent fio > throws the following error: > ------------------------------------- > From diff -u 011.out 011.out.bad > Configured SRP target driver > -Passed > > From 011.full: > fio: looks like your file system does not support direct=1/buffered=0 > fio: destination does not support O_DIRECT > run_fio exit code: 1 > ------------------------------------- > This issue happens randomly. > > Try to fix the issue by holding $dev before test. > > Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com> Thanks, applied.
diff --git a/tests/srp/011 b/tests/srp/011 index 29b2c03..63ff332 100755 --- a/tests/srp/011 +++ b/tests/srp/011 @@ -12,6 +12,8 @@ test_disconnect_repeatedly() { use_blk_mq y y || return $? dev=$(get_bdev 0) || return $? + # Hold $dev + exec 3< "$dev" simulate_network_failure_loop "$dev" "$TIMEOUT" & run_fio --verify=md5 --rw=randwrite --bs=4K --loops=10000 \ --ioengine=libaio --iodepth=64 --iodepth_batch=32 \ @@ -22,6 +24,8 @@ test_disconnect_repeatedly() { >>"$FULL" fio_status=$? wait + # Release $dev + exec 3<&- log_in return $fio_status }
$dev will become invalid when log_out has been done and fio doesn't run yet. In this case subsequent fio throws the following error: ------------------------------------- From diff -u 011.out 011.out.bad Configured SRP target driver -Passed From 011.full: fio: looks like your file system does not support direct=1/buffered=0 fio: destination does not support O_DIRECT run_fio exit code: 1 ------------------------------------- This issue happens randomly. Try to fix the issue by holding $dev before test. Signed-off-by: Xiao Yang <yangx.jy@fujitsu.com> --- tests/srp/011 | 4 ++++ 1 file changed, 4 insertions(+)