| Message ID | 20220523122755.90638-1-lizhengyu3@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | iio: srf08: Remove redundant if statement | expand |
Acked-by: Andreas Klinger <ak@it-klinger.de> Li Zhengyu <lizhengyu3@huawei.com> schrieb am Mo, 23. Mai 20:27: > (!val) has been checked outside the loop, remove redundant (val &&) > from loop. > > Signed-off-by: Li Zhengyu <lizhengyu3@huawei.com> > --- > drivers/iio/proximity/srf08.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/proximity/srf08.c b/drivers/iio/proximity/srf08.c > index ac1ab7e89d4e..7ed11339c31e 100644 > --- a/drivers/iio/proximity/srf08.c > +++ b/drivers/iio/proximity/srf08.c > @@ -354,7 +354,7 @@ static ssize_t srf08_write_sensitivity(struct srf08_data *data, > return -EINVAL; > > for (i = 0; i < data->chip_info->num_sensitivity_avail; i++) > - if (val && (val == data->chip_info->sensitivity_avail[i])) { > + if (val == data->chip_info->sensitivity_avail[i]) { > regval = i; > break; > } > -- > 2.17.1 >
On Wed, 25 May 2022 08:33:38 +0200 Andreas Klinger <ak@it-klinger.de> wrote: > Acked-by: Andreas Klinger <ak@it-klinger.de> > > Li Zhengyu <lizhengyu3@huawei.com> schrieb am Mo, 23. Mai 20:27: > > (!val) has been checked outside the loop, remove redundant (val &&) > > from loop. > > > > Signed-off-by: Li Zhengyu <lizhengyu3@huawei.com> Hi Li Zhengyu, Applied to the togreg branch of iio.git which is initially pushed out as testing or 0-day to see if we missed anything. I'll push it out for linux-next to pick up once the merge window closes. Thanks, Jonathan > > --- > > drivers/iio/proximity/srf08.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/iio/proximity/srf08.c b/drivers/iio/proximity/srf08.c > > index ac1ab7e89d4e..7ed11339c31e 100644 > > --- a/drivers/iio/proximity/srf08.c > > +++ b/drivers/iio/proximity/srf08.c > > @@ -354,7 +354,7 @@ static ssize_t srf08_write_sensitivity(struct srf08_data *data, > > return -EINVAL; > > > > for (i = 0; i < data->chip_info->num_sensitivity_avail; i++) > > - if (val && (val == data->chip_info->sensitivity_avail[i])) { > > + if (val == data->chip_info->sensitivity_avail[i]) { > > regval = i; > > break; > > } > > -- > > 2.17.1 > > >
diff --git a/drivers/iio/proximity/srf08.c b/drivers/iio/proximity/srf08.c index ac1ab7e89d4e..7ed11339c31e 100644 --- a/drivers/iio/proximity/srf08.c +++ b/drivers/iio/proximity/srf08.c @@ -354,7 +354,7 @@ static ssize_t srf08_write_sensitivity(struct srf08_data *data, return -EINVAL; for (i = 0; i < data->chip_info->num_sensitivity_avail; i++) - if (val && (val == data->chip_info->sensitivity_avail[i])) { + if (val == data->chip_info->sensitivity_avail[i]) { regval = i; break; }
(!val) has been checked outside the loop, remove redundant (val &&) from loop. Signed-off-by: Li Zhengyu <lizhengyu3@huawei.com> --- drivers/iio/proximity/srf08.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)