diff mbox series

[1/2] dt-bindings: arm: rockchip: Add PinePhone Pro bindings

Message ID 20220529031705.278631-2-tom@tom-fitzhenry.me.uk (mailing list archive)
State New, archived
Headers show
Series Add support for Pine64 PinePhonePro Linux phone | expand

Commit Message

Tom Fitzhenry May 29, 2022, 3:17 a.m. UTC
Document board compatible names for Pine64 PinePhonePro.

https://wiki.pine64.org/wiki/PinePhone_Pro

Signed-off-by: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Krzysztof Kozlowski May 29, 2022, 2:23 p.m. UTC | #1
On 29/05/2022 05:17, Tom Fitzhenry wrote:
> Document board compatible names for Pine64 PinePhonePro.
> 
> https://wiki.pine64.org/wiki/PinePhone_Pro
> 
> Signed-off-by: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof
Pavel Machek June 15, 2022, 1:28 p.m. UTC | #2
Hi!

> Document board compatible names for Pine64 PinePhonePro.
> 
> https://wiki.pine64.org/wiki/PinePhone_Pro
> 
> Signed-off-by: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>

It makes sense to get this reviewed early, because Rob's ack is needed here, right?

> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -489,6 +489,11 @@ properties:
>            - const: pine64,pinenote
>            - const: rockchip,rk3566
>  
> +      - description: Pine64 PinePhonePro
> +        items:
> +          - const: pine64-pinephone-pro

This should be pine64,... right?

Best regards,
									Pavel
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index eece92f83a2d..e6a1b76f9c44 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -489,6 +489,11 @@  properties:
           - const: pine64,pinenote
           - const: rockchip,rk3566
 
+      - description: Pine64 PinePhonePro
+        items:
+          - const: pine64-pinephone-pro
+          - const: rockchip,rk3399
+
       - description: Pine64 Rock64
         items:
           - const: pine64,rock64