mbox series

[v4,0/4] KVM: s390: selftests: Provide TAP output in tests

Message ID 20220531101554.36844-1-thuth@redhat.com (mailing list archive)
Headers show
Series KVM: s390: selftests: Provide TAP output in tests | expand

Message

Thomas Huth May 31, 2022, 10:15 a.m. UTC
This patch series is motivated by Shuah's suggestion here:

 https://lore.kernel.org/kvm/d576d8f7-980f-3bc6-87ad-5a6ae45609b8@linuxfoundation.org/

Many s390x KVM selftests do not output any information about which
tests have been run, so it's hard to say whether a test binary
contains a certain sub-test or not. To improve this situation let's
add some TAP output via the kselftest.h interface to these tests,
so that it easier to understand what has been executed or not.

v4:
 - Rebased to include test_termination() now in the memop test
 - Reworked the extension capability check in the memop test

v3:
 - Added comments / fixed cosmetics according to Janosch's and
   Janis' reviews of the v2 series
 - Added Reviewed-by tags from the v2 series

v2:
 - Reworked the extension checking in the first patch
 - Make sure to always print the TAP 13 header in the second patch
 - Reworked the SKIP printing in the third patch

Thomas Huth (4):
  KVM: s390: selftests: Use TAP interface in the memop test
  KVM: s390: selftests: Use TAP interface in the sync_regs test
  KVM: s390: selftests: Use TAP interface in the tprot test
  KVM: s390: selftests: Use TAP interface in the reset test

 tools/testing/selftests/kvm/s390x/memop.c     | 95 +++++++++++++++----
 tools/testing/selftests/kvm/s390x/resets.c    | 38 ++++++--
 .../selftests/kvm/s390x/sync_regs_test.c      | 87 +++++++++++++----
 tools/testing/selftests/kvm/s390x/tprot.c     | 29 +++++-
 4 files changed, 197 insertions(+), 52 deletions(-)

Comments

Christian Borntraeger May 31, 2022, 11:29 a.m. UTC | #1
Am 31.05.22 um 12:15 schrieb Thomas Huth:
> This patch series is motivated by Shuah's suggestion here:
> 
>   https://lore.kernel.org/kvm/d576d8f7-980f-3bc6-87ad-5a6ae45609b8@linuxfoundation.org/
> 
> Many s390x KVM selftests do not output any information about which
> tests have been run, so it's hard to say whether a test binary
> contains a certain sub-test or not. To improve this situation let's
> add some TAP output via the kselftest.h interface to these tests,
> so that it easier to understand what has been executed or not.
> 
> v4:
>   - Rebased to include test_termination() now in the memop test
>   - Reworked the extension capability check in the memop test
> 
> v3:
>   - Added comments / fixed cosmetics according to Janosch's and
>     Janis' reviews of the v2 series
>   - Added Reviewed-by tags from the v2 series
> 
> v2:
>   - Reworked the extension checking in the first patch
>   - Make sure to always print the TAP 13 header in the second patch
>   - Reworked the SKIP printing in the third patch
> 
> Thomas Huth (4):
>    KVM: s390: selftests: Use TAP interface in the memop test
>    KVM: s390: selftests: Use TAP interface in the sync_regs test
>    KVM: s390: selftests: Use TAP interface in the tprot test
>    KVM: s390: selftests: Use TAP interface in the reset test
> 
>   tools/testing/selftests/kvm/s390x/memop.c     | 95 +++++++++++++++----
>   tools/testing/selftests/kvm/s390x/resets.c    | 38 ++++++--
>   .../selftests/kvm/s390x/sync_regs_test.c      | 87 +++++++++++++----
>   tools/testing/selftests/kvm/s390x/tprot.c     | 29 +++++-
>   4 files changed, 197 insertions(+), 52 deletions(-)
> 

Thanks applied and queued.