| Message ID | 20220531135026.238475-3-fparent@baylibre.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add support for MT8365 EVK board | expand |
On 31/05/2022 15:50, Fabien Parent wrote: > Add MediaTek SMI bindings for MT8365 SoC. > > Signed-off-by: Fabien Parent <fparent@baylibre.com> > --- > .../bindings/memory-controllers/mediatek,smi-common.yaml | 6 ++++++ > .../bindings/memory-controllers/mediatek,smi-larb.yaml | 6 ++++++ > 2 files changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml > index a98b359bf909..e1029ac99ab4 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml > +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml > @@ -46,6 +46,11 @@ properties: > - const: mediatek,mt7623-smi-common > - const: mediatek,mt2701-smi-common > > + - description: for mt8365 Skip description and: > + items: > + - const: mediatek,mt8365-smi-common This should be rather enum. I see existing code did that way, but this way makes it bloated. If new device compatible with mt8186 comes, should be added to this enum, not to new items. > + - const: mediatek,mt8186-smi-common > + > reg: > maxItems: 1 > > @@ -130,6 +135,7 @@ allOf: > - mediatek,mt8192-smi-common > - mediatek,mt8195-smi-common-vdo > - mediatek,mt8195-smi-common-vpp > + - mediatek,mt8365-smi-common > > then: > properties: > diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml > index c886681f62a7..815d87fc64a0 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml > +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml > @@ -32,6 +32,11 @@ properties: > - const: mediatek,mt7623-smi-larb > - const: mediatek,mt2701-smi-larb > > + - description: for mt8365 > + items: > + - const: mediatek,mt8365-smi-larb > + - const: mediatek,mt8186-smi-larb Ditto. > + > reg: > maxItems: 1 > > @@ -78,6 +83,7 @@ allOf: > - mediatek,mt8183-smi-larb > - mediatek,mt8186-smi-larb > - mediatek,mt8195-smi-larb > + - mediatek,mt8365-smi-larb > > then: > properties: Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml index a98b359bf909..e1029ac99ab4 100644 --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.yaml @@ -46,6 +46,11 @@ properties: - const: mediatek,mt7623-smi-common - const: mediatek,mt2701-smi-common + - description: for mt8365 + items: + - const: mediatek,mt8365-smi-common + - const: mediatek,mt8186-smi-common + reg: maxItems: 1 @@ -130,6 +135,7 @@ allOf: - mediatek,mt8192-smi-common - mediatek,mt8195-smi-common-vdo - mediatek,mt8195-smi-common-vpp + - mediatek,mt8365-smi-common then: properties: diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml index c886681f62a7..815d87fc64a0 100644 --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml @@ -32,6 +32,11 @@ properties: - const: mediatek,mt7623-smi-larb - const: mediatek,mt2701-smi-larb + - description: for mt8365 + items: + - const: mediatek,mt8365-smi-larb + - const: mediatek,mt8186-smi-larb + reg: maxItems: 1 @@ -78,6 +83,7 @@ allOf: - mediatek,mt8183-smi-larb - mediatek,mt8186-smi-larb - mediatek,mt8195-smi-larb + - mediatek,mt8365-smi-larb then: properties:
Add MediaTek SMI bindings for MT8365 SoC. Signed-off-by: Fabien Parent <fparent@baylibre.com> --- .../bindings/memory-controllers/mediatek,smi-common.yaml | 6 ++++++ .../bindings/memory-controllers/mediatek,smi-larb.yaml | 6 ++++++ 2 files changed, 12 insertions(+)