| Message ID | YpYFnbDxFl6tQ3Bn@kili (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 86360030cc5117596626bef1d937277cd2bebe05 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net/sched: act_api: fix error code in tcf_ct_flow_table_fill_tuple_ipv6() | expand |
On 2022/05/31 21:10, Dan Carpenter wrote: > The tcf_ct_flow_table_fill_tuple_ipv6() function is supposed to return > false on failure. It should not return negatives because that means > succes/true. > > Fixes: fcb6aa86532c ("act_ct: Support GRE offload") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Thank you! Acked-by: Toshiaki Makita <toshiaki.makita1@gmail.com>
Hello: This patch was applied to netdev/net.git (master) by Paolo Abeni <pabeni@redhat.com>: On Tue, 31 May 2022 15:10:05 +0300 you wrote: > The tcf_ct_flow_table_fill_tuple_ipv6() function is supposed to return > false on failure. It should not return negatives because that means > succes/true. > > Fixes: fcb6aa86532c ("act_ct: Support GRE offload") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > [...] Here is the summary with links: - [net] net/sched: act_api: fix error code in tcf_ct_flow_table_fill_tuple_ipv6() https://git.kernel.org/netdev/net/c/86360030cc51 You are awesome, thank you!
diff --git a/net/sched/act_ct.c b/net/sched/act_ct.c index 8af9d6e5ba61..e013253b10d1 100644 --- a/net/sched/act_ct.c +++ b/net/sched/act_ct.c @@ -548,7 +548,7 @@ tcf_ct_flow_table_fill_tuple_ipv6(struct sk_buff *skb, break; #endif default: - return -1; + return false; } if (ip6h->hop_limit <= 1)
The tcf_ct_flow_table_fill_tuple_ipv6() function is supposed to return false on failure. It should not return negatives because that means succes/true. Fixes: fcb6aa86532c ("act_ct: Support GRE offload") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- net/sched/act_ct.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)