| Message ID | 20220526000921.1581503-9-jsnow@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | tests, python: prepare to expand usage of test venv | expand |
On 5/26/22 02:09, John Snow wrote: > This is needed to be able to add a venv-building step to 'make check'; > the clang-user job in particular needs this to be able to run > check-unit. > > Signed-off-by: John Snow <jsnow@redhat.com> > --- > tests/docker/dockerfiles/debian10.docker | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/docker/dockerfiles/debian10.docker b/tests/docker/dockerfiles/debian10.docker > index b414af1b9f7..03be9230664 100644 > --- a/tests/docker/dockerfiles/debian10.docker > +++ b/tests/docker/dockerfiles/debian10.docker > @@ -34,4 +34,5 @@ RUN apt update && \ > python3 \ > python3-sphinx \ > python3-sphinx-rtd-theme \ > + python3-venv \ > $(apt-get -s build-dep --arch-only qemu | egrep ^Inst | fgrep '[all]' | cut -d\ -f2) Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
On 26/05/2022 02.09, John Snow wrote: > This is needed to be able to add a venv-building step to 'make check'; > the clang-user job in particular needs this to be able to run > check-unit. > > Signed-off-by: John Snow <jsnow@redhat.com> > --- > tests/docker/dockerfiles/debian10.docker | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/docker/dockerfiles/debian10.docker b/tests/docker/dockerfiles/debian10.docker > index b414af1b9f7..03be9230664 100644 > --- a/tests/docker/dockerfiles/debian10.docker > +++ b/tests/docker/dockerfiles/debian10.docker > @@ -34,4 +34,5 @@ RUN apt update && \ > python3 \ > python3-sphinx \ > python3-sphinx-rtd-theme \ > + python3-venv \ > $(apt-get -s build-dep --arch-only qemu | egrep ^Inst | fgrep '[all]' | cut -d\ -f2) Note that we'll (hopefully) drop the debian 10 container soon, since Debian 10 is EOL by the time we publish the next QEMU release. Thomas
On Mon, May 30, 2022 at 3:33 AM Thomas Huth <thuth@redhat.com> wrote: > > On 26/05/2022 02.09, John Snow wrote: > > This is needed to be able to add a venv-building step to 'make check'; > > the clang-user job in particular needs this to be able to run > > check-unit. > > > > Signed-off-by: John Snow <jsnow@redhat.com> > > --- > > tests/docker/dockerfiles/debian10.docker | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tests/docker/dockerfiles/debian10.docker b/tests/docker/dockerfiles/debian10.docker > > index b414af1b9f7..03be9230664 100644 > > --- a/tests/docker/dockerfiles/debian10.docker > > +++ b/tests/docker/dockerfiles/debian10.docker > > @@ -34,4 +34,5 @@ RUN apt update && \ > > python3 \ > > python3-sphinx \ > > python3-sphinx-rtd-theme \ > > + python3-venv \ > > $(apt-get -s build-dep --arch-only qemu | egrep ^Inst | fgrep '[all]' | cut -d\ -f2) > > Note that we'll (hopefully) drop the debian 10 container soon, since Debian > 10 is EOL by the time we publish the next QEMU release. > Noted -- do you think it'd be OK to sneak this change in first and have you move the requisite to the new container? :)
On 31/05/2022 20.28, John Snow wrote: > On Mon, May 30, 2022 at 3:33 AM Thomas Huth <thuth@redhat.com> wrote: >> >> On 26/05/2022 02.09, John Snow wrote: >>> This is needed to be able to add a venv-building step to 'make check'; >>> the clang-user job in particular needs this to be able to run >>> check-unit. >>> >>> Signed-off-by: John Snow <jsnow@redhat.com> >>> --- >>> tests/docker/dockerfiles/debian10.docker | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/tests/docker/dockerfiles/debian10.docker b/tests/docker/dockerfiles/debian10.docker >>> index b414af1b9f7..03be9230664 100644 >>> --- a/tests/docker/dockerfiles/debian10.docker >>> +++ b/tests/docker/dockerfiles/debian10.docker >>> @@ -34,4 +34,5 @@ RUN apt update && \ >>> python3 \ >>> python3-sphinx \ >>> python3-sphinx-rtd-theme \ >>> + python3-venv \ >>> $(apt-get -s build-dep --arch-only qemu | egrep ^Inst | fgrep '[all]' | cut -d\ -f2) >> >> Note that we'll (hopefully) drop the debian 10 container soon, since Debian >> 10 is EOL by the time we publish the next QEMU release. >> > > Noted -- do you think it'd be OK to sneak this change in first and > have you move the requisite to the new container? :) I don't mind - whatever comes first ... I just wanted to make you aware that there might be conflicts ;-) Thomas
On Wed, Jun 1, 2022, 3:29 AM Thomas Huth <thuth@redhat.com> wrote: > On 31/05/2022 20.28, John Snow wrote: > > On Mon, May 30, 2022 at 3:33 AM Thomas Huth <thuth@redhat.com> wrote: > >> > >> On 26/05/2022 02.09, John Snow wrote: > >>> This is needed to be able to add a venv-building step to 'make check'; > >>> the clang-user job in particular needs this to be able to run > >>> check-unit. > >>> > >>> Signed-off-by: John Snow <jsnow@redhat.com> > >>> --- > >>> tests/docker/dockerfiles/debian10.docker | 1 + > >>> 1 file changed, 1 insertion(+) > >>> > >>> diff --git a/tests/docker/dockerfiles/debian10.docker > b/tests/docker/dockerfiles/debian10.docker > >>> index b414af1b9f7..03be9230664 100644 > >>> --- a/tests/docker/dockerfiles/debian10.docker > >>> +++ b/tests/docker/dockerfiles/debian10.docker > >>> @@ -34,4 +34,5 @@ RUN apt update && \ > >>> python3 \ > >>> python3-sphinx \ > >>> python3-sphinx-rtd-theme \ > >>> + python3-venv \ > >>> $(apt-get -s build-dep --arch-only qemu | egrep ^Inst | > fgrep '[all]' | cut -d\ -f2) > >> > >> Note that we'll (hopefully) drop the debian 10 container soon, since > Debian > >> 10 is EOL by the time we publish the next QEMU release. > >> > > > > Noted -- do you think it'd be OK to sneak this change in first and > > have you move the requisite to the new container? :) > > I don't mind - whatever comes first ... I just wanted to make you aware > that > there might be conflicts ;-) > > Thomas > Yep, got it! No problem at all. Thanks ~~ >
diff --git a/tests/docker/dockerfiles/debian10.docker b/tests/docker/dockerfiles/debian10.docker index b414af1b9f7..03be9230664 100644 --- a/tests/docker/dockerfiles/debian10.docker +++ b/tests/docker/dockerfiles/debian10.docker @@ -34,4 +34,5 @@ RUN apt update && \ python3 \ python3-sphinx \ python3-sphinx-rtd-theme \ + python3-venv \ $(apt-get -s build-dep --arch-only qemu | egrep ^Inst | fgrep '[all]' | cut -d\ -f2)
This is needed to be able to add a venv-building step to 'make check'; the clang-user job in particular needs this to be able to run check-unit. Signed-off-by: John Snow <jsnow@redhat.com> --- tests/docker/dockerfiles/debian10.docker | 1 + 1 file changed, 1 insertion(+)