| Message ID | 20220527125633.GA5145@standask-GA-A55M-S2HP (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: interrupt-controller: Convert rda,8810pl-intc to YAML | expand |
On 27/05/2022 14:56, Stanislav Jakubek wrote: > Convert RDA Micro interrupt controller bindings to DT schema format. > > Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com> > --- > > Didn't know what to do about the interrupt sources listed in the original txt file, > so I've split them off into a separate file. Hope that's okay. Interrupt sources are not kept in header files. Additionally are you sure this is a property of the interrupt controller, not a property of SoC itself? I would assume that one interrupt controller implementation (e.g. GIC) can be used in different SoCs and the sources are every time different because they depend on the actual wiring... Best regards, Krzysztof
On Sun, May 29, 2022 at 04:05:12PM +0200, Krzysztof Kozlowski wrote: > On 27/05/2022 14:56, Stanislav Jakubek wrote: > > Convert RDA Micro interrupt controller bindings to DT schema format. > > > > Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com> > > --- > > > > Didn't know what to do about the interrupt sources listed in the original txt file, > > so I've split them off into a separate file. Hope that's okay. > > Interrupt sources are not kept in header files. Ok, should I move them somewhere else or is it fine to drop them? > Additionally are you > sure this is a property of the interrupt controller, not a property of > SoC itself? I would assume that one interrupt controller implementation > (e.g. GIC) can be used in different SoCs and the sources are every time > different because they depend on the actual wiring... > I honestly have no idea, I just wanted to make some YAML conversions. Maybe Mani could answer this? > > Best regards, > Krzysztof Thanks, Stanislav
On 03/06/2022 14:12, Stanislav Jakubek wrote: > On Sun, May 29, 2022 at 04:05:12PM +0200, Krzysztof Kozlowski wrote: >> On 27/05/2022 14:56, Stanislav Jakubek wrote: >>> Convert RDA Micro interrupt controller bindings to DT schema format. >>> >>> Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com> >>> --- >>> >>> Didn't know what to do about the interrupt sources listed in the original txt file, >>> so I've split them off into a separate file. Hope that's okay. >> >> Interrupt sources are not kept in header files. > > Ok, should I move them somewhere else or is it fine to drop them? Either drop them or, if they are meaningful, keep in description. I doubt that they are meaningful, but who knows... > >> Additionally are you >> sure this is a property of the interrupt controller, not a property of >> SoC itself? I would assume that one interrupt controller implementation >> (e.g. GIC) can be used in different SoCs and the sources are every time >> different because they depend on the actual wiring... >> > > I honestly have no idea, I just wanted to make some YAML conversions. > Maybe Mani could answer this? Best regards, Krzysztof
On Fri, Jun 03, 2022 at 02:12:58PM +0200, Stanislav Jakubek wrote: > On Sun, May 29, 2022 at 04:05:12PM +0200, Krzysztof Kozlowski wrote: > > On 27/05/2022 14:56, Stanislav Jakubek wrote: > > > Convert RDA Micro interrupt controller bindings to DT schema format. > > > > > > Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com> > > > --- > > > > > > Didn't know what to do about the interrupt sources listed in the original txt file, > > > so I've split them off into a separate file. Hope that's okay. > > > > Interrupt sources are not kept in header files. > > Ok, should I move them somewhere else or is it fine to drop them? > > > Additionally are you > > sure this is a property of the interrupt controller, not a property of > > SoC itself? I would assume that one interrupt controller implementation > > (e.g. GIC) can be used in different SoCs and the sources are every time > > different because they depend on the actual wiring... > > > > I honestly have no idea, I just wanted to make some YAML conversions. > Maybe Mani could answer this? > You can drop them. I didn't include it in a header file because it could vary between SoCs. So added here for documenting purposes. Thanks, Mani > > > > Best regards, > > Krzysztof > > > Thanks, > Stanislav
diff --git a/Documentation/devicetree/bindings/interrupt-controller/rda,8810pl-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/rda,8810pl-intc.txt deleted file mode 100644 index e0062aebf025..000000000000 --- a/Documentation/devicetree/bindings/interrupt-controller/rda,8810pl-intc.txt +++ /dev/null @@ -1,61 +0,0 @@ -RDA Micro RDA8810PL Interrupt Controller - -The interrupt controller in RDA8810PL SoC is a custom interrupt controller -which supports up to 32 interrupts. - -Required properties: - -- compatible: Should be "rda,8810pl-intc". -- reg: Specifies base physical address of the registers set. -- interrupt-controller: Identifies the node as an interrupt controller. -- #interrupt-cells: Specifies the number of cells needed to encode an - interrupt source. The value shall be 2. - -The interrupt sources are as follows: - -ID Name ------------- -0: PULSE_DUMMY -1: I2C -2: NAND_NFSC -3: SDMMC1 -4: SDMMC2 -5: SDMMC3 -6: SPI1 -7: SPI2 -8: SPI3 -9: UART1 -10: UART2 -11: UART3 -12: GPIO1 -13: GPIO2 -14: GPIO3 -15: KEYPAD -16: TIMER -17: TIMEROS -18: COMREG0 -19: COMREG1 -20: USB -21: DMC -22: DMA -23: CAMERA -24: GOUDA -25: GPU -26: VPU_JPG -27: VPU_HOST -28: VOC -29: AUIFC0 -30: AUIFC1 -31: L2CC - -Example: - apb@20800000 { - compatible = "simple-bus"; - ... - intc: interrupt-controller@0 { - compatible = "rda,8810pl-intc"; - reg = <0x0 0x1000>; - interrupt-controller; - #interrupt-cells = <2>; - }; - }; diff --git a/Documentation/devicetree/bindings/interrupt-controller/rda,8810pl-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/rda,8810pl-intc.yaml new file mode 100644 index 000000000000..96d6285d0087 --- /dev/null +++ b/Documentation/devicetree/bindings/interrupt-controller/rda,8810pl-intc.yaml @@ -0,0 +1,43 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/interrupt-controller/rda,8810pl-intc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: RDA Micro RDA8810PL interrupt controller + +maintainers: + - Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> + +allOf: + - $ref: /schemas/interrupt-controller.yaml# + +properties: + compatible: + const: rda,8810pl-intc + + reg: + maxItems: 1 + + interrupt-controller: true + + '#interrupt-cells': + const: 2 + +required: + - compatible + - reg + - interrupt-controller + - '#interrupt-cells' + +additionalProperties: false + +examples: + - | + intc: interrupt-controller@0 { + compatible = "rda,8810pl-intc"; + reg = <0x0 0x1000>; + interrupt-controller; + #interrupt-cells = <2>; + }; +... diff --git a/MAINTAINERS b/MAINTAINERS index f0a90b256b26..58a35519b7c4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2590,7 +2590,7 @@ L: linux-unisoc@lists.infradead.org (moderated for non-subscribers) S: Maintained F: Documentation/devicetree/bindings/arm/rda.yaml F: Documentation/devicetree/bindings/gpio/gpio-rda.yaml -F: Documentation/devicetree/bindings/interrupt-controller/rda,8810pl-intc.txt +F: Documentation/devicetree/bindings/interrupt-controller/rda,8810pl-intc.yaml F: Documentation/devicetree/bindings/serial/rda,8810pl-uart.yaml F: Documentation/devicetree/bindings/timer/rda,8810pl-timer.yaml F: arch/arm/boot/dts/rda8810pl-* diff --git a/include/dt-bindings/interrupt-controller/rda-ic.h b/include/dt-bindings/interrupt-controller/rda-ic.h new file mode 100644 index 000000000000..8d257cce4f9e --- /dev/null +++ b/include/dt-bindings/interrupt-controller/rda-ic.h @@ -0,0 +1,40 @@ +/* SPDX-License-Identifier: GPL-2.0-only OR MIT */ +#ifndef _DT_BINDINGS_INTERRUPT_CONTROLLER_RDA_IC_H +#define _DT_BINDINGS_INTERRUPT_CONTROLLER_RDA_IC_H + +#include <dt-bindings/interrupt-controller/irq.h> + +#define RDA_IC_PULSE_DUMMY 0 +#define RDA_IC_I2C 1 +#define RDA_IC_NAND_NFSC 2 +#define RDA_IC_SDMMC1 3 +#define RDA_IC_SDMMC2 4 +#define RDA_IC_SDMMC3 5 +#define RDA_IC_SPI1 6 +#define RDA_IC_SPI2 7 +#define RDA_IC_SPI3 8 +#define RDA_IC_UART1 9 +#define RDA_IC_UART2 10 +#define RDA_IC_UART3 11 +#define RDA_IC_GPIO1 12 +#define RDA_IC_GPIO2 13 +#define RDA_IC_GPIO3 14 +#define RDA_IC_KEYPAD 15 +#define RDA_IC_TIMER 16 +#define RDA_IC_TIMEROS 17 +#define RDA_IC_COMREG0 18 +#define RDA_IC_COMREG1 19 +#define RDA_IC_USB 20 +#define RDA_IC_DMC 21 +#define RDA_IC_DMA 22 +#define RDA_IC_CAMERA 23 +#define RDA_IC_GOUDA 24 +#define RDA_IC_GPU 25 +#define RDA_IC_VPU_JPG 26 +#define RDA_IC_VPU_HOST 27 +#define RDA_IC_VOC 28 +#define RDA_IC_AUIFC0 29 +#define RDA_IC_AUIFC1 30 +#define RDA_IC_L2CC 31 + +#endif
Convert RDA Micro interrupt controller bindings to DT schema format. Signed-off-by: Stanislav Jakubek <stano.jakubek@gmail.com> --- Didn't know what to do about the interrupt sources listed in the original txt file, so I've split them off into a separate file. Hope that's okay. .../interrupt-controller/rda,8810pl-intc.txt | 61 ------------------- .../interrupt-controller/rda,8810pl-intc.yaml | 43 +++++++++++++ MAINTAINERS | 2 +- .../dt-bindings/interrupt-controller/rda-ic.h | 40 ++++++++++++ 4 files changed, 84 insertions(+), 62 deletions(-) delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/rda,8810pl-intc.txt create mode 100644 Documentation/devicetree/bindings/interrupt-controller/rda,8810pl-intc.yaml create mode 100644 include/dt-bindings/interrupt-controller/rda-ic.h