| Message ID | 20220606141051.285823-2-tzungbi@kernel.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | platform/chrome: Kunit tests and refactor for cros_ec_query_all() | expand |
On Mon, Jun 6, 2022 at 7:12 AM Tzung-Bi Shih <tzungbi@kernel.org> wrote: > > Fix compile errors when including cros_ec_commands.h solely. > > 1. > cros_ec_commands.h:587:9: error: unknown type name 'uint8_t' > 587 | uint8_t flags; > | ^~~~~~~ > > 2. > cros_ec_commands.h:1105:43: error: implicit declaration of function 'BIT' > 1105 | EC_COMMS_STATUS_PROCESSING = BIT(0), > | ^~~ > > Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org> Reviewed-by: Guenter Roeck <groeck@chromium.org> > --- > include/linux/platform_data/cros_ec_commands.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/platform_data/cros_ec_commands.h b/include/linux/platform_data/cros_ec_commands.h > index 8cfa8cfca77e..a5b749a85707 100644 > --- a/include/linux/platform_data/cros_ec_commands.h > +++ b/include/linux/platform_data/cros_ec_commands.h > @@ -13,8 +13,8 @@ > #ifndef __CROS_EC_COMMANDS_H > #define __CROS_EC_COMMANDS_H > > - > - > +#include <linux/bits.h> > +#include <linux/types.h> > > #define BUILD_ASSERT(_cond) > > -- > 2.36.1.255.ge46751e96f-goog >
diff --git a/include/linux/platform_data/cros_ec_commands.h b/include/linux/platform_data/cros_ec_commands.h index 8cfa8cfca77e..a5b749a85707 100644 --- a/include/linux/platform_data/cros_ec_commands.h +++ b/include/linux/platform_data/cros_ec_commands.h @@ -13,8 +13,8 @@ #ifndef __CROS_EC_COMMANDS_H #define __CROS_EC_COMMANDS_H - - +#include <linux/bits.h> +#include <linux/types.h> #define BUILD_ASSERT(_cond)
Fix compile errors when including cros_ec_commands.h solely. 1. cros_ec_commands.h:587:9: error: unknown type name 'uint8_t' 587 | uint8_t flags; | ^~~~~~~ 2. cros_ec_commands.h:1105:43: error: implicit declaration of function 'BIT' 1105 | EC_COMMS_STATUS_PROCESSING = BIT(0), | ^~~ Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org> --- include/linux/platform_data/cros_ec_commands.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)