| Message ID | 20220606154441.20848-1-lukma@denx.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/3] ASoC: wm8940: Remove warning when no plat data | expand |
On Mon, Jun 06, 2022 at 05:44:39PM +0200, Lukasz Majewski wrote: > The lack of platform data in the contemporary Linux > shall not be the reason to display warnings to the > kernel logs. > > Signed-off-by: Lukasz Majewski <lukma@denx.de> Given that the device requires configuration and doesn't appear to have any other firmware interface support that's rather a strong statement...
Hi Mark, > On Mon, Jun 06, 2022 at 05:44:39PM +0200, Lukasz Majewski wrote: > > The lack of platform data in the contemporary Linux > > shall not be the reason to display warnings to the > > kernel logs. > > > > Signed-off-by: Lukasz Majewski <lukma@denx.de> > > Given that the device requires configuration and doesn't appear to > have any other firmware interface support that's rather a strong > statement... Thanks for the comment :-) My point is that - similar codec - wm8974 don't display such warnings. (this code was not updated/refactored for a quite long time). Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
On Mon, Jun 06, 2022 at 06:17:31PM +0200, Lukasz Majewski wrote: > > On Mon, Jun 06, 2022 at 05:44:39PM +0200, Lukasz Majewski wrote: > > > The lack of platform data in the contemporary Linux > > > shall not be the reason to display warnings to the > > > kernel logs. > > Given that the device requires configuration and doesn't appear to > > have any other firmware interface support that's rather a strong > > statement... > My point is that - similar codec - wm8974 don't display such warnings. > (this code was not updated/refactored for a quite long time). Perhaps those drivers are buggy, or those devices lack this specific configuration that's being adjusted? The changelog should at least address why the driver was warning about configuration being required but it's safe to ignore that.
Hi Mark, > On Mon, Jun 06, 2022 at 06:17:31PM +0200, Lukasz Majewski wrote: > > > On Mon, Jun 06, 2022 at 05:44:39PM +0200, Lukasz Majewski wrote: > > > > > The lack of platform data in the contemporary Linux > > > > shall not be the reason to display warnings to the > > > > kernel logs. > > > > Given that the device requires configuration and doesn't appear to > > > have any other firmware interface support that's rather a strong > > > statement... > > > My point is that - similar codec - wm8974 don't display such > > warnings. (this code was not updated/refactored for a quite long > > time). > > Perhaps those drivers are buggy, or those devices lack this specific > configuration that's being adjusted? The changelog should at least > address why the driver was warning about configuration being required > but it's safe to ignore that. With v4.4 from which I forward port those changes only the PXA 'stargate2' mach is using this codec. In this version there is no reference to 'vroi'. With newest Linux - there is no reference to this codec (even to any DTS file), so we can assume that from at least v4.4 there is no reference to platform data for it. I guess that one can provide the 'vroi' information via DTS nowadays if required. Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
On Tue, Jun 07, 2022 at 02:30:39PM +0200, Lukasz Majewski wrote: > > On Mon, Jun 06, 2022 at 06:17:31PM +0200, Lukasz Majewski wrote: > > > > On Mon, Jun 06, 2022 at 05:44:39PM +0200, Lukasz Majewski wrote: > > > My point is that - similar codec - wm8974 don't display such > > > warnings. (this code was not updated/refactored for a quite long > > > time). > > Perhaps those drivers are buggy, or those devices lack this specific > > configuration that's being adjusted? The changelog should at least > > address why the driver was warning about configuration being required > > but it's safe to ignore that. > With v4.4 from which I forward port those changes only the PXA > 'stargate2' mach is using this codec. > In this version there is no reference to 'vroi'. That's equivalent to setting a value of 0 given the way platform data works. > I guess that one can provide the 'vroi' information via DTS nowadays if > required. Yes, that's what I'd expect.
diff --git a/sound/soc/codecs/wm8940.c b/sound/soc/codecs/wm8940.c index 440d048ef0c0..7cea54720436 100644 --- a/sound/soc/codecs/wm8940.c +++ b/sound/soc/codecs/wm8940.c @@ -709,9 +709,7 @@ static int wm8940_probe(struct snd_soc_component *component) if (ret < 0) return ret; - if (!pdata) - dev_warn(component->dev, "No platform data supplied\n"); - else { + if (pdata) { reg = snd_soc_component_read(component, WM8940_OUTPUTCTL); ret = snd_soc_component_write(component, WM8940_OUTPUTCTL, reg | pdata->vroi); if (ret < 0)
The lack of platform data in the contemporary Linux shall not be the reason to display warnings to the kernel logs. Signed-off-by: Lukasz Majewski <lukma@denx.de> --- sound/soc/codecs/wm8940.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)