diff mbox series

ALSA: hda/realtek - Add HW8326 support

Message ID 20220607084109.29120-1-huangwenhuia@uniontech.com (mailing list archive)
State Superseded
Headers show
Series ALSA: hda/realtek - Add HW8326 support | expand

Commit Message

huangwenhui June 7, 2022, 8:41 a.m. UTC 
Added the support of new Huawei codec HW8326.

Signed-off-by: huangwenhui <huangwenhuia@uniontech.com>
---
 sound/hda/hdac_device.c       |  1 +
 sound/pci/hda/patch_realtek.c | 14 ++++++++++++++
 2 files changed, 15 insertions(+)

Comments

Takashi Iwai June 7, 2022, 9:09 a.m. UTC | #1 
On Tue, 07 Jun 2022 10:41:09 +0200,
huangwenhui wrote:
> 
> Added the support of new Huawei codec HW8326.
> 

It'd be appreciated if you describe about the hardware a bit more.
It looks like a compatible chip with some other Realtek codecs
(ALC256?).

> @@ -11479,6 +11492,7 @@ static const struct hda_device_id snd_hda_id_realtek[] = {
>  	HDA_CODEC_ENTRY(0x10ec0236, "ALC236", patch_alc269),
>  	HDA_CODEC_ENTRY(0x10ec0245, "ALC245", patch_alc269),
>  	HDA_CODEC_ENTRY(0x10ec0255, "ALC255", patch_alc269),
> +	HDA_CODEC_ENTRY(0x19e58326, "HW8326", patch_alc269),
>  	HDA_CODEC_ENTRY(0x10ec0256, "ALC256", patch_alc269),
>  	HDA_CODEC_ENTRY(0x10ec0257, "ALC257", patch_alc269),
>  	HDA_CODEC_ENTRY(0x10ec0260, "ALC260", patch_alc260),

This table is sorted in the codec ID order.  Please put at the
appropriate place (at the last), instead.


thanks,

Takashi
huangwenhui June 7, 2022, 9:32 a.m. UTC | #2 
The codec&nbsp; HW8326 is a compatible chip with ALC256.
It is developed by Huawei via CPLD with Realtek's codec IP.


Thanks.
&nbsp;
------------------&nbsp;Original&nbsp;------------------
From: &nbsp;"Takashi&nbsp;Iwai"<tiwai@suse.de&gt;;
Date: &nbsp;Tue, Jun 7, 2022 05:09 PM
To: &nbsp;"huangwenhui"<huangwenhuia@uniontech.com&gt;; 
Cc: &nbsp;"perex"<perex@perex.cz&gt;; "tiwai"<tiwai@suse.com&gt;; "alsa-devel"<alsa-devel@alsa-project.org&gt;; "kailang"<kailang@realtek.com&gt;; "tanureal"<tanureal@opensource.cirrus.com&gt;; "jeremy.szu"<jeremy.szu@canonical.com&gt;; "linux-kernel"<linux-kernel@vger.kernel.org&gt;; "wse"<wse@tuxedocomputers.com&gt;; "hui.wang"<hui.wang@canonical.com&gt;; "sami"<sami@loone.fi&gt;; "cam"<cam@neo-zeon.de&gt;; 
Subject: &nbsp;Re: [PATCH] ALSA: hda/realtek - Add HW8326 support

&nbsp;

On Tue, 07 Jun 2022 10:41:09 +0200,
huangwenhui wrote:
&gt; 
&gt; Added the support of new Huawei codec HW8326.
&gt; 

It'd be appreciated if you describe about the hardware a bit more.
It looks like a compatible chip with some other Realtek codecs
(ALC256?).

&gt; @@ -11479,6 +11492,7 @@ static const struct hda_device_id snd_hda_id_realtek[] = {
&gt;&nbsp; 	HDA_CODEC_ENTRY(0x10ec0236, "ALC236", patch_alc269),
&gt;&nbsp; 	HDA_CODEC_ENTRY(0x10ec0245, "ALC245", patch_alc269),
&gt;&nbsp; 	HDA_CODEC_ENTRY(0x10ec0255, "ALC255", patch_alc269),
&gt; +	HDA_CODEC_ENTRY(0x19e58326, "HW8326", patch_alc269),
&gt;&nbsp; 	HDA_CODEC_ENTRY(0x10ec0256, "ALC256", patch_alc269),
&gt;&nbsp; 	HDA_CODEC_ENTRY(0x10ec0257, "ALC257", patch_alc269),
&gt;&nbsp; 	HDA_CODEC_ENTRY(0x10ec0260, "ALC260", patch_alc260),

This table is sorted in the codec ID order.&nbsp; Please put at the
appropriate place (at the last), instead.


thanks,

Takashi
diff mbox series

Patch

diff --git a/sound/hda/hdac_device.c b/sound/hda/hdac_device.c
index 3e9e9ac804f6..775474f00141 100644
--- a/sound/hda/hdac_device.c
+++ b/sound/hda/hdac_device.c
@@ -651,6 +651,7 @@  static const struct hda_vendor_id hda_vendor_ids[] = {
 	{ 0x1095, "Silicon Image" },
 	{ 0x10de, "Nvidia" },
 	{ 0x10ec, "Realtek" },
+	{ 0x19e5, "Huawei" },
 	{ 0x1102, "Creative" },
 	{ 0x1106, "VIA" },
 	{ 0x111d, "IDT" },
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index f3ad454b3fbf..0f32c0d17a3f 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -443,6 +443,7 @@  static void alc_fill_eapd_coef(struct hda_codec *codec)
 	case 0x10ec0245:
 	case 0x10ec0255:
 	case 0x10ec0256:
+	case 0x19e58326:
 	case 0x10ec0257:
 	case 0x10ec0282:
 	case 0x10ec0283:
@@ -580,6 +581,7 @@  static void alc_shutup_pins(struct hda_codec *codec)
 	switch (codec->core.vendor_id) {
 	case 0x10ec0236:
 	case 0x10ec0256:
+	case 0x19e58326:
 	case 0x10ec0283:
 	case 0x10ec0286:
 	case 0x10ec0288:
@@ -3247,6 +3249,7 @@  static void alc_disable_headset_jack_key(struct hda_codec *codec)
 	case 0x10ec0230:
 	case 0x10ec0236:
 	case 0x10ec0256:
+	case 0x19e58326:
 		alc_write_coef_idx(codec, 0x48, 0x0);
 		alc_update_coef_idx(codec, 0x49, 0x0045, 0x0);
 		break;
@@ -3275,6 +3278,7 @@  static void alc_enable_headset_jack_key(struct hda_codec *codec)
 	case 0x10ec0230:
 	case 0x10ec0236:
 	case 0x10ec0256:
+	case 0x19e58326:
 		alc_write_coef_idx(codec, 0x48, 0xd011);
 		alc_update_coef_idx(codec, 0x49, 0x007f, 0x0045);
 		break;
@@ -4910,6 +4914,7 @@  static void alc_headset_mode_unplugged(struct hda_codec *codec)
 	case 0x10ec0230:
 	case 0x10ec0236:
 	case 0x10ec0256:
+	case 0x19e58326:
 		alc_process_coef_fw(codec, coef0256);
 		break;
 	case 0x10ec0234:
@@ -5025,6 +5030,7 @@  static void alc_headset_mode_mic_in(struct hda_codec *codec, hda_nid_t hp_pin,
 	case 0x10ec0230:
 	case 0x10ec0236:
 	case 0x10ec0256:
+	case 0x19e58326:
 		alc_write_coef_idx(codec, 0x45, 0xc489);
 		snd_hda_set_pin_ctl_cache(codec, hp_pin, 0);
 		alc_process_coef_fw(codec, coef0256);
@@ -5175,6 +5181,7 @@  static void alc_headset_mode_default(struct hda_codec *codec)
 	case 0x10ec0230:
 	case 0x10ec0236:
 	case 0x10ec0256:
+	case 0x19e58326:
 		alc_write_coef_idx(codec, 0x1b, 0x0e4b);
 		alc_write_coef_idx(codec, 0x45, 0xc089);
 		msleep(50);
@@ -5274,6 +5281,7 @@  static void alc_headset_mode_ctia(struct hda_codec *codec)
 	case 0x10ec0230:
 	case 0x10ec0236:
 	case 0x10ec0256:
+	case 0x19e58326:
 		alc_process_coef_fw(codec, coef0256);
 		break;
 	case 0x10ec0234:
@@ -5388,6 +5396,7 @@  static void alc_headset_mode_omtp(struct hda_codec *codec)
 	case 0x10ec0230:
 	case 0x10ec0236:
 	case 0x10ec0256:
+	case 0x19e58326:
 		alc_process_coef_fw(codec, coef0256);
 		break;
 	case 0x10ec0234:
@@ -5489,6 +5498,7 @@  static void alc_determine_headset_type(struct hda_codec *codec)
 	case 0x10ec0230:
 	case 0x10ec0236:
 	case 0x10ec0256:
+	case 0x19e58326:
 		alc_write_coef_idx(codec, 0x1b, 0x0e4b);
 		alc_write_coef_idx(codec, 0x06, 0x6104);
 		alc_write_coefex_idx(codec, 0x57, 0x3, 0x09a3);
@@ -5783,6 +5793,7 @@  static void alc255_set_default_jack_type(struct hda_codec *codec)
 	case 0x10ec0230:
 	case 0x10ec0236:
 	case 0x10ec0256:
+	case 0x19e58326:
 		alc_process_coef_fw(codec, alc256fw);
 		break;
 	}
@@ -6385,6 +6396,7 @@  static void alc_combo_jack_hp_jd_restart(struct hda_codec *codec)
 	case 0x10ec0236:
 	case 0x10ec0255:
 	case 0x10ec0256:
+	case 0x19e58326:
 		alc_update_coef_idx(codec, 0x1b, 0x8000, 1 << 15); /* Reset HP JD */
 		alc_update_coef_idx(codec, 0x1b, 0x8000, 0 << 15);
 		break;
@@ -10095,6 +10107,7 @@  static int patch_alc269(struct hda_codec *codec)
 	case 0x10ec0230:
 	case 0x10ec0236:
 	case 0x10ec0256:
+	case 0x19e58326:
 		spec->codec_variant = ALC269_TYPE_ALC256;
 		spec->shutup = alc256_shutup;
 		spec->init_hook = alc256_init;
@@ -11479,6 +11492,7 @@  static const struct hda_device_id snd_hda_id_realtek[] = {
 	HDA_CODEC_ENTRY(0x10ec0236, "ALC236", patch_alc269),
 	HDA_CODEC_ENTRY(0x10ec0245, "ALC245", patch_alc269),
 	HDA_CODEC_ENTRY(0x10ec0255, "ALC255", patch_alc269),
+	HDA_CODEC_ENTRY(0x19e58326, "HW8326", patch_alc269),
 	HDA_CODEC_ENTRY(0x10ec0256, "ALC256", patch_alc269),
 	HDA_CODEC_ENTRY(0x10ec0257, "ALC257", patch_alc269),
 	HDA_CODEC_ENTRY(0x10ec0260, "ALC260", patch_alc260),