mbox series

[v5,0/3] target: iscsi: control authentication per ACL

Message ID 20220523095905.26070-1-d.bogdanov@yadro.com (mailing list archive)
Headers show
Series target: iscsi: control authentication per ACL | expand

Message

Dmitry Bogdanov May 23, 2022, 9:59 a.m. UTC
Add acls/{ACL}/attrib/authentication attribute that controls authentication
for the particular ACL. By default, this attribute inherits a value of
authentication attribute of the target port group to keep a backward
compatibility.

authentication attribute has 3 states:
"0" - authentication is turned off for this ACL
"1" - authentication is required for this ACL
"-1" - authentication is inherited from TPG

This patchset is intended for scsi-queue.

v5:
 rebase on latest scsi-staging

v4:
 rebase on latest scsi-queue

v3:
 fix warning: no previous prototype for function 'iscsi_conn_auth_required'

v2:
 show effective value (-1) for inherited mode

Dmitry Bogdanov (3):
  scsi: target: iscsi: Add upcast helpers
  scsi: target: iscsi: extract auth functions
  target: iscsi: control authentication per ACL

 drivers/target/iscsi/iscsi_target_configfs.c  | 116 +++++++-------
 drivers/target/iscsi/iscsi_target_nego.c      | 148 ++++++++++++------
 .../target/iscsi/iscsi_target_nodeattrib.c    |   1 +
 drivers/target/iscsi/iscsi_target_tpg.c       |   3 +-
 include/target/iscsi/iscsi_target_core.h      |  14 ++
 5 files changed, 176 insertions(+), 106 deletions(-)

Comments

Martin K. Petersen June 8, 2022, 1:55 a.m. UTC | #1
Dmitry,

> Add acls/{ACL}/attrib/authentication attribute that controls
> authentication for the particular ACL. By default, this attribute
> inherits a value of authentication attribute of the target port group
> to keep a backward compatibility.

Applied to 5.20/scsi-staging, thanks!
Martin K. Petersen June 10, 2022, 5:45 p.m. UTC | #2
On Mon, 23 May 2022 12:59:02 +0300, Dmitry Bogdanov wrote:

> Add acls/{ACL}/attrib/authentication attribute that controls authentication
> for the particular ACL. By default, this attribute inherits a value of
> authentication attribute of the target port group to keep a backward
> compatibility.
> 
> authentication attribute has 3 states:
> "0" - authentication is turned off for this ACL
> "1" - authentication is required for this ACL
> "-1" - authentication is inherited from TPG
> 
> [...]

Applied to 5.20/scsi-queue, thanks!

[1/3] scsi: target: iscsi: Add upcast helpers
      https://git.kernel.org/mkp/scsi/c/a11b80692be5
[2/3] scsi: target: iscsi: extract auth functions
      https://git.kernel.org/mkp/scsi/c/a75fcb0912a5
[3/3] target: iscsi: control authentication per ACL
      https://git.kernel.org/mkp/scsi/c/a6e0d179764c