diff mbox series

drm/i915/overlay: remove redundant GEM_BUG_ON()

Message ID 20220516081015.1058987-1-jani.nikula@intel.com (mailing list archive)
State New, archived
Headers show
Series drm/i915/overlay: remove redundant GEM_BUG_ON() | expand

Commit Message

Jani Nikula May 16, 2022, 8:10 a.m. UTC 
There's an early return for !engine->kernel_context.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_overlay.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Tvrtko Ursulin June 8, 2022, 8:04 a.m. UTC | #1 
On 16/05/2022 09:10, Jani Nikula wrote:
> There's an early return for !engine->kernel_context.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_overlay.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_overlay.c b/drivers/gpu/drm/i915/display/intel_overlay.c
> index ee46561b5ae8..79ed8bd04a07 100644
> --- a/drivers/gpu/drm/i915/display/intel_overlay.c
> +++ b/drivers/gpu/drm/i915/display/intel_overlay.c
> @@ -1399,8 +1399,6 @@ void intel_overlay_setup(struct drm_i915_private *dev_priv)
>   
>   	overlay->i915 = dev_priv;
>   	overlay->context = engine->kernel_context;
> -	GEM_BUG_ON(!overlay->context);
> -
>   	overlay->color_key = 0x0101fe;
>   	overlay->color_key_enabled = true;
>   	overlay->brightness = -19;

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko
Jani Nikula June 8, 2022, 8:47 a.m. UTC | #2 
On Wed, 08 Jun 2022, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
> On 16/05/2022 09:10, Jani Nikula wrote:
>> There's an early return for !engine->kernel_context.
>> 
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>>   drivers/gpu/drm/i915/display/intel_overlay.c | 2 --
>>   1 file changed, 2 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/display/intel_overlay.c b/drivers/gpu/drm/i915/display/intel_overlay.c
>> index ee46561b5ae8..79ed8bd04a07 100644
>> --- a/drivers/gpu/drm/i915/display/intel_overlay.c
>> +++ b/drivers/gpu/drm/i915/display/intel_overlay.c
>> @@ -1399,8 +1399,6 @@ void intel_overlay_setup(struct drm_i915_private *dev_priv)
>>   
>>   	overlay->i915 = dev_priv;
>>   	overlay->context = engine->kernel_context;
>> -	GEM_BUG_ON(!overlay->context);
>> -
>>   	overlay->color_key = 0x0101fe;
>>   	overlay->color_key_enabled = true;
>>   	overlay->brightness = -19;
>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Thanks, pushed to din.

BR,
Jani.

>
> Regards,
>
> Tvrtko
diff mbox series

Patch

diff --git a/drivers/gpu/drm/i915/display/intel_overlay.c b/drivers/gpu/drm/i915/display/intel_overlay.c
index ee46561b5ae8..79ed8bd04a07 100644
--- a/drivers/gpu/drm/i915/display/intel_overlay.c
+++ b/drivers/gpu/drm/i915/display/intel_overlay.c
@@ -1399,8 +1399,6 @@  void intel_overlay_setup(struct drm_i915_private *dev_priv)
 
 	overlay->i915 = dev_priv;
 	overlay->context = engine->kernel_context;
-	GEM_BUG_ON(!overlay->context);
-
 	overlay->color_key = 0x0101fe;
 	overlay->color_key_enabled = true;
 	overlay->brightness = -19;