| Message ID | 20220601045738.19608-1-lukas.bulwahn@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ed872f92fd0946ba30f2acd05fc57e29cac29cd2 |
| Headers | show |
| Series | MAINTAINERS: adjust MELLANOX ETHERNET INNOVA DRIVERS to TLS support removal | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Wed, Jun 01, 2022 at 06:57:38AM +0200, Lukas Bulwahn wrote: > Commit 40379a0084c2 ("net/mlx5_fpga: Drop INNOVA TLS support") removes all > files in the directory drivers/net/ethernet/mellanox/mlx5/core/accel/, but > misses to adjust its reference in MAINTAINERS. > > Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a > broken reference. > > Remove the file entry to the removed directory in MELLANOX ETHERNET INNOVA > DRIVERS. > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> > --- > Leon, please pick this minor non-urgent clean-up patch on top of the commit > above. Thanks, we will submit it once net-next will be open.
On Wed, 1 Jun 2022 13:18:12 +0300 Leon Romanovsky wrote: > On Wed, Jun 01, 2022 at 06:57:38AM +0200, Lukas Bulwahn wrote: > > Commit 40379a0084c2 ("net/mlx5_fpga: Drop INNOVA TLS support") removes all > > files in the directory drivers/net/ethernet/mellanox/mlx5/core/accel/, but > > misses to adjust its reference in MAINTAINERS. > > > > Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a > > broken reference. > > > > Remove the file entry to the removed directory in MELLANOX ETHERNET INNOVA > > DRIVERS. > > > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> > > --- > > Leon, please pick this minor non-urgent clean-up patch on top of the commit > > above. > > Thanks, we will submit it once net-next will be open. It should go via net FWIW.
On Wed, Jun 01, 2022 at 10:30:39AM -0700, Jakub Kicinski wrote: > On Wed, 1 Jun 2022 13:18:12 +0300 Leon Romanovsky wrote: > > On Wed, Jun 01, 2022 at 06:57:38AM +0200, Lukas Bulwahn wrote: > > > Commit 40379a0084c2 ("net/mlx5_fpga: Drop INNOVA TLS support") removes all > > > files in the directory drivers/net/ethernet/mellanox/mlx5/core/accel/, but > > > misses to adjust its reference in MAINTAINERS. > > > > > > Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a > > > broken reference. > > > > > > Remove the file entry to the removed directory in MELLANOX ETHERNET INNOVA > > > DRIVERS. > > > > > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> > > > --- > > > Leon, please pick this minor non-urgent clean-up patch on top of the commit > > > above. > > > > Thanks, we will submit it once net-next will be open. > > It should go via net FWIW. I'm slightly confused here. According to net policy, the patches that goes there should have Fixes line, but Fixes lines are added for bugs [1]. This forgotten line in MAINTAINERS doesn't cause to any harm to users/developers. So when should I put Fixes line in netdev? [1] https://lore.kernel.org/netdev/20211208070842.0ace6747@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com/ Thanks
On Wed, 1 Jun 2022 21:08:06 +0300 Leon Romanovsky wrote: > On Wed, Jun 01, 2022 at 10:30:39AM -0700, Jakub Kicinski wrote: > > > Thanks, we will submit it once net-next will be open. > > > > It should go via net FWIW. > > I'm slightly confused here. > > According to net policy, the patches that goes there should have Fixes > line, but Fixes lines are added for bugs [1]. > > This forgotten line in MAINTAINERS doesn't cause to any harm to > users/developers. Fair, maybe I worded it too strongly. I should have said something like "FWIW it's okay for MAINTAINERS updates to go via net". Documentation/ patches and MAINTAINERS are special, they can go into net without a Fixes tag so that changes to get_maintainer output and https://www.kernel.org/doc/html/latest/ propagate quickly. > So when should I put Fixes line in netdev? > > [1] https://lore.kernel.org/netdev/20211208070842.0ace6747@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com/
On Wed, Jun 01, 2022 at 12:26:18PM -0700, Jakub Kicinski wrote: > On Wed, 1 Jun 2022 21:08:06 +0300 Leon Romanovsky wrote: > > On Wed, Jun 01, 2022 at 10:30:39AM -0700, Jakub Kicinski wrote: > > > > Thanks, we will submit it once net-next will be open. > > > > > > It should go via net FWIW. > > > > I'm slightly confused here. > > > > According to net policy, the patches that goes there should have Fixes > > line, but Fixes lines are added for bugs [1]. > > > > This forgotten line in MAINTAINERS doesn't cause to any harm to > > users/developers. > > Fair, maybe I worded it too strongly. I should have said something like > "FWIW it's okay for MAINTAINERS updates to go via net". > > Documentation/ patches and MAINTAINERS are special, they can go into > net without a Fixes tag so that changes to get_maintainer output and > https://www.kernel.org/doc/html/latest/ propagate quickly. Awesome, thanks > > > So when should I put Fixes line in netdev? > > > > [1] https://lore.kernel.org/netdev/20211208070842.0ace6747@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com/ >
Hello: This patch was applied to netdev/net.git (master) by Saeed Mahameed <saeedm@nvidia.com>: On Wed, 1 Jun 2022 06:57:38 +0200 you wrote: > Commit 40379a0084c2 ("net/mlx5_fpga: Drop INNOVA TLS support") removes all > files in the directory drivers/net/ethernet/mellanox/mlx5/core/accel/, but > misses to adjust its reference in MAINTAINERS. > > Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a > broken reference. > > [...] Here is the summary with links: - MAINTAINERS: adjust MELLANOX ETHERNET INNOVA DRIVERS to TLS support removal https://git.kernel.org/netdev/net/c/ed872f92fd09 You are awesome, thank you!
On Fri, 10 Jun 2022 05:20:14 +0000 patchwork-bot+netdevbpf@kernel.org wrote: > Hello: > > This patch was applied to netdev/net.git (master) > by Saeed Mahameed <saeedm@nvidia.com>: > > On Wed, 1 Jun 2022 06:57:38 +0200 you wrote: > > Commit 40379a0084c2 ("net/mlx5_fpga: Drop INNOVA TLS support") removes all > > files in the directory drivers/net/ethernet/mellanox/mlx5/core/accel/, but > > misses to adjust its reference in MAINTAINERS. > > > > Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a > > broken reference. > > > > [...] > > Here is the summary with links: > - MAINTAINERS: adjust MELLANOX ETHERNET INNOVA DRIVERS to TLS support removal > https://git.kernel.org/netdev/net/c/ed872f92fd09 What luck. I was trying to see if pw-bot will respond to the PR rather than the series if I mark the series as accepted first but apparently it found this random posting and replied to it instead :S That's a roundabout way of saying that I pulled "mlx5 fixes 2022-06-08", thanks!
diff --git a/MAINTAINERS b/MAINTAINERS index 88fdf39e6bb4..8ccdd7727840 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12695,7 +12695,6 @@ L: netdev@vger.kernel.org S: Supported W: http://www.mellanox.com Q: https://patchwork.kernel.org/project/netdevbpf/list/ -F: drivers/net/ethernet/mellanox/mlx5/core/accel/* F: drivers/net/ethernet/mellanox/mlx5/core/en_accel/* F: drivers/net/ethernet/mellanox/mlx5/core/fpga/* F: include/linux/mlx5/mlx5_ifc_fpga.h
Commit 40379a0084c2 ("net/mlx5_fpga: Drop INNOVA TLS support") removes all files in the directory drivers/net/ethernet/mellanox/mlx5/core/accel/, but misses to adjust its reference in MAINTAINERS. Hence, ./scripts/get_maintainer.pl --self-test=patterns complains about a broken reference. Remove the file entry to the removed directory in MELLANOX ETHERNET INNOVA DRIVERS. Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> --- Leon, please pick this minor non-urgent clean-up patch on top of the commit above. MAINTAINERS | 1 - 1 file changed, 1 deletion(-)