| Message ID | 20220613113713.13681-1-wangyouwan@uniontech.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c6d3bcf3d005ad9c9f8a85a68c88aa7f231d9a60 |
| Headers | show |
| Series | obexd: Fix callback->func =! NULL in the xfer_complete() func | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/checkpatch | success | Checkpatch PASS |
| tedd_an/gitlint | success | Gitlint PASS |
| tedd_an/setupell | success | Setup ELL PASS |
| tedd_an/buildprep | success | Build Prep PASS |
| tedd_an/build | success | Build Configuration PASS |
| tedd_an/makecheck | success | Make Check PASS |
| tedd_an/makecheckvalgrind | success | Make Check PASS |
| tedd_an/makedistcheck | success | Make Distcheck PASS |
| tedd_an/build_extell | success | Build External ELL PASS |
| tedd_an/build_extell_make | success | Build Make with External ELL PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=649838 ---Test result--- Test Summary: CheckPatch PASS 0.78 seconds GitLint PASS 0.51 seconds Prep - Setup ELL PASS 41.52 seconds Build - Prep PASS 0.47 seconds Build - Configure PASS 8.00 seconds Build - Make PASS 1212.26 seconds Make Check PASS 11.20 seconds Make Check w/Valgrind PASS 438.49 seconds Make Distcheck PASS 228.62 seconds Build w/ext ELL - Configure PASS 8.06 seconds Build w/ext ELL - Make PASS 1178.65 seconds Incremental Build with patchesPASS 0.00 seconds --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Mon, 13 Jun 2022 19:37:13 +0800 you wrote: > xfer_complete (obex=0x557d242c8cf0, err=0x557d242ca470, > user_data=0x557d242ca300) at obexd/client/transfer.c:659 > 659 obexd/client/transfer.c: > (gdb) n > 661 in obexd/client/transfer.c > (gdb) n > 663 in obexd/client/transfer.c > (gdb) p callback->func > $1 = (transfer_callback_t) 0x0 > (gdb) n > 668 in obexd/client/transfer.c > (gdb) n > 671 in obexd/client/transfer.c > (gdb) n > 672 in obexd/client/transfer.c > (gdb) n > 676 in obexd/client/transfer.c > (gdb) n > 677 in obexd/client/transfer.c > (gdb) n > 0x0000000000000000 in ?? () > (gdb) s > Cannot find bounds of current function > (gdb) c > Continuing. > > [...] Here is the summary with links: - obexd: Fix callback->func =! NULL in the xfer_complete() func https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c6d3bcf3d005 You are awesome, thank you!
diff --git a/obexd/client/transfer.c b/obexd/client/transfer.c index dccce03b4..a7a85a0c0 100644 --- a/obexd/client/transfer.c +++ b/obexd/client/transfer.c @@ -666,7 +666,10 @@ static void xfer_complete(GObex *obex, GError *err, gpointer user_data) else transfer_set_status(transfer, TRANSFER_STATUS_COMPLETE); - if (callback) + if (callback == NULL) + return; + + if (callback->func) callback->func(transfer, err, callback->data); }