| Message ID | Yqh6bdNYO2XNhPBa@kili (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d52b095b6cb4dca3bdbc144e7098abdbbd45e9bc |
| Headers | show |
| Series | spi: core: Fix error code in spi_register_controller() | expand |
On Tue, 14 Jun 2022 15:09:17 +0300, Dan Carpenter wrote: > Return -ENOMEM if the allocation fails. Don't return success. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: core: Fix error code in spi_register_controller() commit: d52b095b6cb4dca3bdbc144e7098abdbbd45e9bc All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index d94822bf3cec..85c552ba0725 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -3079,6 +3079,7 @@ int spi_register_controller(struct spi_controller *ctlr) ctlr->pcpu_statistics = spi_alloc_pcpu_stats(dev); if (!ctlr->pcpu_statistics) { dev_err(dev, "Error allocating per-cpu statistics\n"); + status = -ENOMEM; goto destroy_queue; }
Return -ENOMEM if the allocation fails. Don't return success. Fixes: 6598b91b5ac3 ("spi: spi.c: Convert statistics to per-cpu u64_stats_t") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/spi/spi.c | 1 + 1 file changed, 1 insertion(+)