| Message ID | 20220614100556.20899-1-guoqing.jiang@linux.dev (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | block: update comment for blkcg_init_queue | expand |
On Tue, Jun 14, 2022 at 06:05:56PM +0800, Guoqing Jiang wrote: > It was called from __alloc_disk_node since commit 1059699f87eb ("block: > move blkcg initialization/destroy into disk allocation/release handler). > Let's change the comment accordingly. Well, the right things is to simply drop this comment. I do have a large series toucing it and removing it, so maybe we can wait until that?
On 6/15/22 2:18 PM, Christoph Hellwig wrote: > On Tue, Jun 14, 2022 at 06:05:56PM +0800, Guoqing Jiang wrote: >> It was called from __alloc_disk_node since commit 1059699f87eb ("block: >> move blkcg initialization/destroy into disk allocation/release handler). >> Let's change the comment accordingly. > Well, the right things is to simply drop this comment. I do have > a large series toucing it and removing it, so maybe we can wait > until that? Sure, I am fine with it. Thanks, Guoqing
diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index 764e740b0c0f..48ea9919e3ce 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -1256,7 +1256,7 @@ static int blkcg_css_online(struct cgroup_subsys_state *css) * blkcg_init_queue - initialize blkcg part of request queue * @q: request_queue to initialize * - * Called from blk_alloc_queue(). Responsible for initializing blkcg + * Called from __alloc_disk_node(). Responsible for initializing blkcg * part of new request_queue @q. * * RETURNS:
It was called from __alloc_disk_node since commit 1059699f87eb ("block: move blkcg initialization/destroy into disk allocation/release handler). Let's change the comment accordingly. Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev> --- block/blk-cgroup.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)