| Message ID | 20220612181934.665-1-i.bornyakov@metrotek.ru (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9794ef5a68430946da2dfe7342be53b50bce9a41 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2,net-next] net: phy: marvell-88x2222: set proper phydev->port | expand |
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Sun, 12 Jun 2022 21:19:34 +0300 you wrote: > phydev->port was not set and always reported as PORT_TP. > Set phydev->port according to inserted SFP module. > > Signed-off-by: Ivan Bornyakov <i.bornyakov@metrotek.ru> > --- > Changelog: > v1 -> v2: set port as PORT_NONE on SFP removal, instead of PORT_OTHER > > [...] Here is the summary with links: - [v2,net-next] net: phy: marvell-88x2222: set proper phydev->port https://git.kernel.org/netdev/net-next/c/9794ef5a6843 You are awesome, thank you!
diff --git a/drivers/net/phy/marvell-88x2222.c b/drivers/net/phy/marvell-88x2222.c index d8b31d4d2a73..f070776ca904 100644 --- a/drivers/net/phy/marvell-88x2222.c +++ b/drivers/net/phy/marvell-88x2222.c @@ -490,6 +490,7 @@ static int mv2222_sfp_insert(void *upstream, const struct sfp_eeprom_id *id) dev = &phydev->mdio.dev; sfp_parse_support(phydev->sfp_bus, id, sfp_supported); + phydev->port = sfp_parse_port(phydev->sfp_bus, id, sfp_supported); sfp_interface = sfp_select_interface(phydev->sfp_bus, sfp_supported); dev_info(dev, "%s SFP module inserted\n", phy_modes(sfp_interface)); @@ -526,6 +527,7 @@ static void mv2222_sfp_remove(void *upstream) priv->line_interface = PHY_INTERFACE_MODE_NA; linkmode_zero(priv->supported); + phydev->port = PORT_NONE; } static void mv2222_sfp_link_up(void *upstream)
phydev->port was not set and always reported as PORT_TP. Set phydev->port according to inserted SFP module. Signed-off-by: Ivan Bornyakov <i.bornyakov@metrotek.ru> --- Changelog: v1 -> v2: set port as PORT_NONE on SFP removal, instead of PORT_OTHER drivers/net/phy/marvell-88x2222.c | 2 ++ 1 file changed, 2 insertions(+)