| Message ID | 20220616073042.13229-2-tinghan.shen@mediatek.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add MT8186 ADSP dt-binding | expand |
On 16/06/2022 00:30, Tinghan Shen wrote: > Rename mbox according to actions instead of 'mbox0' and 'mbox1'. > > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> > --- > .../devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml > index b7e68b0dfa13..ca8d8661f872 100644 > --- a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml > +++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml > @@ -50,13 +50,13 @@ properties: > > mboxes: > items: > - - description: ipc reply between host and audio DSP. > - - description: ipc request between host and audio DSP. > + - description: mailbox for receiving audio DSP requests. > + - description: mailbox for transmitting requests to audio DSP. > > mbox-names: > items: > - - const: mbox0 > - - const: mbox1 > + - const: rx > + - const: tx > Commit msg lacks important piece - do you break any users with this? Do you have any users of this binding? Best regards, Krzysztof
Hi Krzysztof, On Thu, 2022-06-16 at 06:55 -0700, Krzysztof Kozlowski wrote: > On 16/06/2022 00:30, Tinghan Shen wrote: > > Rename mbox according to actions instead of 'mbox0' and 'mbox1'. > > > > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> > > --- > > .../devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml | 10 +++++----- > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml > > b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml > > index b7e68b0dfa13..ca8d8661f872 100644 > > --- a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml > > +++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml > > @@ -50,13 +50,13 @@ properties: > > > > mboxes: > > items: > > - - description: ipc reply between host and audio DSP. > > - - description: ipc request between host and audio DSP. > > + - description: mailbox for receiving audio DSP requests. > > + - description: mailbox for transmitting requests to audio DSP. > > > > mbox-names: > > items: > > - - const: mbox0 > > - - const: mbox1 > > + - const: rx > > + - const: tx > > > > Commit msg lacks important piece - do you break any users with this? Do > you have any users of this binding? > > > Best regards, > Krzysztof The 8195 dsp node, which uses this binding, has not yet been added to the 8195 devicetree. Thanks, TingHan
On 20/06/2022 08:40, Tinghan Shen wrote: > Hi Krzysztof, > > On Thu, 2022-06-16 at 06:55 -0700, Krzysztof Kozlowski wrote: >> On 16/06/2022 00:30, Tinghan Shen wrote: >>> Rename mbox according to actions instead of 'mbox0' and 'mbox1'. >>> >>> Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> >>> --- >>> .../devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml | 10 +++++----- >>> 1 file changed, 5 insertions(+), 5 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml >>> b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml >>> index b7e68b0dfa13..ca8d8661f872 100644 >>> --- a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml >>> +++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml >>> @@ -50,13 +50,13 @@ properties: >>> >>> mboxes: >>> items: >>> - - description: ipc reply between host and audio DSP. >>> - - description: ipc request between host and audio DSP. >>> + - description: mailbox for receiving audio DSP requests. >>> + - description: mailbox for transmitting requests to audio DSP. >>> >>> mbox-names: >>> items: >>> - - const: mbox0 >>> - - const: mbox1 >>> + - const: rx >>> + - const: tx >>> >> >> Commit msg lacks important piece - do you break any users with this? Do >> you have any users of this binding? >> >> >> Best regards, >> Krzysztof > > The 8195 dsp node, which uses this binding, has not yet been added to the 8195 devicetree. Could you mention it in the commit msg? Such one sentence is enough. With commit msg extended: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi Krzysztof, On Mon, 2022-06-20 at 10:51 +0200, Krzysztof Kozlowski wrote: > On 20/06/2022 08:40, Tinghan Shen wrote: > > Hi Krzysztof, > > > > On Thu, 2022-06-16 at 06:55 -0700, Krzysztof Kozlowski wrote: > > > On 16/06/2022 00:30, Tinghan Shen wrote: > > > > Rename mbox according to actions instead of 'mbox0' and 'mbox1'. > > > > > > > > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> > > > > --- > > > > .../devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml | 10 +++++----- > > > > 1 file changed, 5 insertions(+), 5 deletions(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml > > > > b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml > > > > index b7e68b0dfa13..ca8d8661f872 100644 > > > > --- a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml > > > > +++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml > > > > @@ -50,13 +50,13 @@ properties: > > > > > > > > mboxes: > > > > items: > > > > - - description: ipc reply between host and audio DSP. > > > > - - description: ipc request between host and audio DSP. > > > > + - description: mailbox for receiving audio DSP requests. > > > > + - description: mailbox for transmitting requests to audio DSP. > > > > > > > > mbox-names: > > > > items: > > > > - - const: mbox0 > > > > - - const: mbox1 > > > > + - const: rx > > > > + - const: tx > > > > > > > > > > Commit msg lacks important piece - do you break any users with this? Do > > > you have any users of this binding? > > > > > > > > > Best regards, > > > Krzysztof > > > > The 8195 dsp node, which uses this binding, has not yet been added to the 8195 devicetree. > > Could you mention it in the commit msg? Such one sentence is enough. > > With commit msg extended: > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > Best regards, > Krzysztof No problem. I'll udpate commit message at next version. Thanks, TingHan
diff --git a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml index b7e68b0dfa13..ca8d8661f872 100644 --- a/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml +++ b/Documentation/devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml @@ -50,13 +50,13 @@ properties: mboxes: items: - - description: ipc reply between host and audio DSP. - - description: ipc request between host and audio DSP. + - description: mailbox for receiving audio DSP requests. + - description: mailbox for transmitting requests to audio DSP. mbox-names: items: - - const: mbox0 - - const: mbox1 + - const: rx + - const: tx memory-region: items: @@ -100,6 +100,6 @@ examples: memory-region = <&adsp_dma_mem_reserved>, <&adsp_mem_reserved>; power-domains = <&spm 6>; //MT8195_POWER_DOMAIN_ADSP - mbox-names = "mbox0", "mbox1"; + mbox-names = "rx", "tx"; mboxes = <&adsp_mailbox0>, <&adsp_mailbox1>; };
Rename mbox according to actions instead of 'mbox0' and 'mbox1'. Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com> --- .../devicetree/bindings/dsp/mediatek,mt8195-dsp.yaml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)