diff mbox series

[BlueZ,1/3] doc/mgmt-api: Update for Add Extended Advertisement Command

Message ID 20220616195803.99346-1-hj.tedd.an@gmail.com (mailing list archive)
State Accepted
Commit 7378408ed4da2267ea7f5fbaff38de57ea75c950
Headers show
Series [BlueZ,1/3] doc/mgmt-api: Update for Add Extended Advertisement Command | expand

Checks

Context Check Description
tedd_an/pre-ci_am success Success
tedd_an/checkpatch success Checkpatch PASS
tedd_an/gitlint success Gitlint PASS
tedd_an/setupell success Setup ELL PASS
tedd_an/buildprep success Build Prep PASS
tedd_an/build success Build Configuration PASS
tedd_an/makecheck success Make Check PASS
tedd_an/makecheckvalgrind success Make Check PASS
tedd_an/makedistcheck success Make Distcheck PASS
tedd_an/build_extell success Build External ELL PASS
tedd_an/build_extell_make success Build Make with External ELL PASS
tedd_an/incremental_build success Pass

Commit Message

Tedd Ho-Jeong An June 16, 2022, 7:58 p.m. UTC
From: Tedd Ho-Jeong An <tedd.an@intel.com>

This patch aligns the input parameter for Add Extended Advertisement
command with actual data struct and add missing flag descriptions.
---
 doc/mgmt-api.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

bluez.test.bot@gmail.com June 16, 2022, 10:49 p.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=651141

---Test result---

Test Summary:
CheckPatch                    FAIL      3.59 seconds
GitLint                       FAIL      2.34 seconds
Prep - Setup ELL              PASS      51.57 seconds
Build - Prep                  PASS      0.63 seconds
Build - Configure             PASS      10.34 seconds
Build - Make                  PASS      1503.91 seconds
Make Check                    PASS      12.39 seconds
Make Check w/Valgrind         PASS      540.37 seconds
Make Distcheck                PASS      282.70 seconds
Build w/ext ELL - Configure   PASS      10.49 seconds
Build w/ext ELL - Make        PASS      1443.36 seconds
Incremental Build with patchesPASS      4517.59 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
[BlueZ,3/3] tools/btmgmt: Add support Add Ext Adv command
WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#233: FILE: tools/btmgmt.c:5031:
+			/* fall through */

WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#405: FILE: tools/btmgmt.c:5203:
+			/* fall through */

/github/workspace/src/12884720.patch total: 0 errors, 2 warnings, 389 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/12884720.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - FAIL
Desc: Run gitlint with rule in .gitlint
Output:
[BlueZ,2/3] monitor: Update flag information for Extended Advertismement
11: B3 Line contains hard tab characters (\t): "	..."
13: B3 Line contains hard tab characters (\t): "	..."




---
Regards,
Linux Bluetooth
patchwork-bot+bluetooth@kernel.org June 17, 2022, 9:10 p.m. UTC | #2
Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Thu, 16 Jun 2022 12:58:01 -0700 you wrote:
> From: Tedd Ho-Jeong An <tedd.an@intel.com>
> 
> This patch aligns the input parameter for Add Extended Advertisement
> command with actual data struct and add missing flag descriptions.
> ---
>  doc/mgmt-api.txt | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Here is the summary with links:
  - [BlueZ,1/3] doc/mgmt-api: Update for Add Extended Advertisement Command
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=7378408ed4da
  - [BlueZ,2/3] monitor: Update flag information for Extended Advertismement
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=2479a013a202
  - [BlueZ,3/3] tools/btmgmt: Add support Add Ext Adv command
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=3075ff8fffec

You are awesome, thank you!
diff mbox series

Patch

diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt
index a429f0ef3..23ea42228 100644
--- a/doc/mgmt-api.txt
+++ b/doc/mgmt-api.txt
@@ -3593,7 +3593,6 @@  Add Extended Advertising Parameters Command
 	Controller Index:	<controller id>
 	Command Parameters:	Instance (1 Octet)
 				Flags (4 Octets)
-				Params (2 Octets)
 				Duration (2 Octets)
 				Timeout (2 Octets)
 				MinInterval (4 Octets)
@@ -3631,6 +3630,8 @@  Add Extended Advertising Parameters Command
 		7	Secondary Channel with LE 1M
 		8	Secondary Channel with LE 2M
 		9	Secondary Channel with LE Coded
+		10	Indicate tx power can be specified
+		11	Indicate HW supports the advertising offload
 		12	The Duration parameter should be used
 		13	The Timeout parameter should be used
 		14	The Interval parameters should be used