| Message ID | 20220615225116.432283-1-alvin@pqrs.dk (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: dsa: realtek: rtl8365mb: improve handling of PHY modes | expand |
Hello: This series was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Thu, 16 Jun 2022 00:51:10 +0200 you wrote: > From: Alvin Šipraga <alsi@bang-olufsen.dk> > > This series introduces some minor cleanup of the driver and improves the > handling of PHY interface modes to break the assumption that CPU ports > are always over an external interface, and the assumption that user > ports are always using an internal PHY. > > [...] Here is the summary with links: - [net-next,v3,1/5] net: dsa: realtek: rtl8365mb: rename macro RTL8367RB -> RTL8367RB_VB https://git.kernel.org/netdev/net-next/c/5eb1a2384066 - [net-next,v3,2/5] net: dsa: realtek: rtl8365mb: remove port_mask private data member https://git.kernel.org/netdev/net-next/c/b325159d0044 - [net-next,v3,3/5] net: dsa: realtek: rtl8365mb: correct the max number of ports https://git.kernel.org/netdev/net-next/c/ca5ecd4246d4 - [net-next,v3,4/5] net: dsa: realtek: rtl8365mb: remove learn_limit_max private data member https://git.kernel.org/netdev/net-next/c/b3456030f54b - [net-next,v3,5/5] net: dsa: realtek: rtl8365mb: handle PHY interface modes correctly https://git.kernel.org/netdev/net-next/c/a48b6e44a9e7 You are awesome, thank you!
From: Alvin Šipraga <alsi@bang-olufsen.dk> This series introduces some minor cleanup of the driver and improves the handling of PHY interface modes to break the assumption that CPU ports are always over an external interface, and the assumption that user ports are always using an internal PHY. Changes v2 -> v3: - rebased on net-next - no code change - patch 5: reworded the last paragraph based on Russel's feedback; hopefully it is clear now that my intent is just to fix the semantics, and that the new "feature" of treating ports with external interfaces as user ports, or ports with internal PHY as CPU ports, is just a side-effect of this fix - I make no claim as to the utility of such configurations and just note that they are permissible as far as the hardware is concerned - patch 5: added Luiz and Russel's Acked-by Changes v1 -> v2: - patches 1-4: no code change - add Luiz' reviewed-by to some of the patches - patch 5: put the chip_infos into a static array and get rid of the switch in the detect function; also remove the macros for various chip ID/versions and embed them directly into the array - patch 5: use array of size 3 rather than flexible array for extints in the chip_info struct; gcc complained about initialization of flexible array members in a nested context, and anyway, we know that the max number of external interfaces is 3 Alvin Šipraga (5): net: dsa: realtek: rtl8365mb: rename macro RTL8367RB -> RTL8367RB_VB net: dsa: realtek: rtl8365mb: remove port_mask private data member net: dsa: realtek: rtl8365mb: correct the max number of ports net: dsa: realtek: rtl8365mb: remove learn_limit_max private data member net: dsa: realtek: rtl8365mb: handle PHY interface modes correctly drivers/net/dsa/realtek/rtl8365mb.c | 299 ++++++++++++++++------------ 1 file changed, 177 insertions(+), 122 deletions(-)