| Message ID | 20220422084720.959271-4-xji@analogixsemi.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote: > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it. > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature") > Signed-off-by: Xin Ji <xji@analogixsemi.com> > --- > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > index 376da01243a3..71df977e8f53 100644 > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev, > > anx7625_get_swing_setting(dev, pdata); > > - pdata->is_dpi = 1; /* default dpi mode */ > + pdata->is_dpi = 0; /* default dsi mode */ > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0); > if (!pdata->mipi_host_node) { > DRM_DEV_ERROR(dev, "fail to get internal panel.\n"); > return -ENODEV; > } > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL; > + bus_type = 0; > mipi_lanes = MAX_LANES_SUPPORT; > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0); > if (ep0) { > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev, > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes"); > } > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */ > - pdata->is_dpi = 0; > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */ > + pdata->is_dpi = 1; > > pdata->mipi_lanes = mipi_lanes; > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0) Reviewed-by: Robert Foss <robert.foss@linaro.org>
On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote: > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote: > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it. > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature") > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > --- > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > > index 376da01243a3..71df977e8f53 100644 > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev, > > > > anx7625_get_swing_setting(dev, pdata); > > > > - pdata->is_dpi = 1; /* default dpi mode */ > > + pdata->is_dpi = 0; /* default dsi mode */ > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0); > > if (!pdata->mipi_host_node) { > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n"); > > return -ENODEV; > > } > > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL; > > + bus_type = 0; > > mipi_lanes = MAX_LANES_SUPPORT; > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0); > > if (ep0) { > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev, > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes"); > > } > > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */ > > - pdata->is_dpi = 0; > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */ > > + pdata->is_dpi = 1; > > > > pdata->mipi_lanes = mipi_lanes; > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0) > > Reviewed-by: Robert Foss <robert.foss@linaro.org> Acked-by: Robert Foss <robert.foss@linaro.org>
On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote: > > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote: > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote: > > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it. > > > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature") > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > > --- > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++---- > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > index 376da01243a3..71df977e8f53 100644 > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev, > > > > > > anx7625_get_swing_setting(dev, pdata); > > > > > > - pdata->is_dpi = 1; /* default dpi mode */ > > > + pdata->is_dpi = 0; /* default dsi mode */ > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0); > > > if (!pdata->mipi_host_node) { > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n"); > > > return -ENODEV; > > > } > > > > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL; > > > + bus_type = 0; > > > mipi_lanes = MAX_LANES_SUPPORT; > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0); > > > if (ep0) { > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev, > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes"); > > > } > > > > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */ > > > - pdata->is_dpi = 0; > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */ > > > + pdata->is_dpi = 1; > > > > > > pdata->mipi_lanes = mipi_lanes; > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0) > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org> > > Acked-by: Robert Foss <robert.foss@linaro.org> Tested-by: Chen-Yu Tsai <wenst@chromium.org> Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on mainline (next-20220422). Xin, in the future, please send the whole series to all recipients of all patches listed by get_maintainers.pl, not just the recipients of each patch. In the case of this series, they should have been sent to all of the mailing lists (media, devicetree, dri-devel) so that everyone has the same, full view of the patches. ChenYu
On Mon, Apr 25, 2022 at 4:24 PM Chen-Yu Tsai <wenst@chromium.org> wrote: > > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote: > > > > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote: > > > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote: > > > > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI > > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it. > > > > > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature") > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > > > --- > > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++---- > > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > index 376da01243a3..71df977e8f53 100644 > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev, > > > > > > > > anx7625_get_swing_setting(dev, pdata); > > > > > > > > - pdata->is_dpi = 1; /* default dpi mode */ > > > > + pdata->is_dpi = 0; /* default dsi mode */ > > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0); > > > > if (!pdata->mipi_host_node) { > > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n"); > > > > return -ENODEV; > > > > } > > > > > > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL; > > > > + bus_type = 0; > > > > mipi_lanes = MAX_LANES_SUPPORT; > > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0); > > > > if (ep0) { > > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev, > > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes"); > > > > } > > > > > > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */ > > > > - pdata->is_dpi = 0; > > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */ > > > > + pdata->is_dpi = 1; > > > > > > > > pdata->mipi_lanes = mipi_lanes; > > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0) > > > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org> > > > > Acked-by: Robert Foss <robert.foss@linaro.org> > > Tested-by: Chen-Yu Tsai <wenst@chromium.org> > > Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on > mainline (next-20220422). Forgot to mention, this device uses the already supported but broken (by previous DPI patch) DSI interface.
On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote: > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote: > > > > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote: > > > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote: > > > > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI > > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it. > > > > > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature") > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > > > --- > > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++---- > > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > index 376da01243a3..71df977e8f53 100644 > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev, > > > > > > > > anx7625_get_swing_setting(dev, pdata); > > > > > > > > - pdata->is_dpi = 1; /* default dpi mode */ > > > > + pdata->is_dpi = 0; /* default dsi mode */ > > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0); > > > > if (!pdata->mipi_host_node) { > > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n"); > > > > return -ENODEV; > > > > } > > > > > > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL; > > > > + bus_type = 0; > > > > mipi_lanes = MAX_LANES_SUPPORT; > > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0); > > > > if (ep0) { > > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev, > > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes"); > > > > } > > > > > > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */ > > > > - pdata->is_dpi = 0; > > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */ > > > > + pdata->is_dpi = 1; > > > > > > > > pdata->mipi_lanes = mipi_lanes; > > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0) > > > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org> > > > > Acked-by: Robert Foss <robert.foss@linaro.org> > > Tested-by: Chen-Yu Tsai <wenst@chromium.org> > > Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on > mainline (next-20220422). > > Xin, in the future, please send the whole series to all recipients of > all patches listed by get_maintainers.pl, not just the recipients of > each patch. In the case of this series, they should have been sent > to all of the mailing lists (media, devicetree, dri-devel) so that > everyone has the same, full view of the patches. Hi ChenYu, OK, I'll send to all media, devicetree, dri-devel next time. Thanks, Xin > > ChenYu
On Mon, 25 Apr 2022 at 11:14, Xin Ji <xji@analogixsemi.com> wrote: > > On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote: > > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote: > > > > > > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote: > > > > > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote: > > > > > > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI > > > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it. > > > > > > > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature") > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > > > > --- > > > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++---- > > > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > > index 376da01243a3..71df977e8f53 100644 > > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev, > > > > > > > > > > anx7625_get_swing_setting(dev, pdata); > > > > > > > > > > - pdata->is_dpi = 1; /* default dpi mode */ > > > > > + pdata->is_dpi = 0; /* default dsi mode */ > > > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0); > > > > > if (!pdata->mipi_host_node) { > > > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n"); > > > > > return -ENODEV; > > > > > } > > > > > > > > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL; > > > > > + bus_type = 0; > > > > > mipi_lanes = MAX_LANES_SUPPORT; > > > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0); > > > > > if (ep0) { > > > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev, > > > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes"); > > > > > } > > > > > > > > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */ > > > > > - pdata->is_dpi = 0; > > > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */ > > > > > + pdata->is_dpi = 1; > > > > > > > > > > pdata->mipi_lanes = mipi_lanes; > > > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0) > > > > > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org> > > > > > > Acked-by: Robert Foss <robert.foss@linaro.org> > > > > Tested-by: Chen-Yu Tsai <wenst@chromium.org> > > > > Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on > > mainline (next-20220422). > > > > Xin, in the future, please send the whole series to all recipients of > > all patches listed by get_maintainers.pl, not just the recipients of > > each patch. In the case of this series, they should have been sent > > to all of the mailing lists (media, devicetree, dri-devel) so that > > everyone has the same, full view of the patches. > Hi ChenYu, OK, I'll send to all media, devicetree, dri-devel next time. > Thanks, > Xin > > > > ChenYu Applied 3/4 + 4/4 to drm-misc-next.
On Tue, 17 May 2022 at 18:09, Robert Foss <robert.foss@linaro.org> wrote: > > On Mon, 25 Apr 2022 at 11:14, Xin Ji <xji@analogixsemi.com> wrote: > > > > On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote: > > > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote: > > > > > > > > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote: > > > > > > > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote: > > > > > > > > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI > > > > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it. > > > > > > > > > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature") > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > > > > > --- > > > > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++---- > > > > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > > > index 376da01243a3..71df977e8f53 100644 > > > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev, > > > > > > > > > > > > anx7625_get_swing_setting(dev, pdata); > > > > > > > > > > > > - pdata->is_dpi = 1; /* default dpi mode */ > > > > > > + pdata->is_dpi = 0; /* default dsi mode */ > > > > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0); > > > > > > if (!pdata->mipi_host_node) { > > > > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n"); > > > > > > return -ENODEV; > > > > > > } > > > > > > > > > > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL; > > > > > > + bus_type = 0; > > > > > > mipi_lanes = MAX_LANES_SUPPORT; > > > > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0); > > > > > > if (ep0) { > > > > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev, > > > > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes"); > > > > > > } > > > > > > > > > > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */ > > > > > > - pdata->is_dpi = 0; > > > > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */ > > > > > > + pdata->is_dpi = 1; > > > > > > > > > > > > pdata->mipi_lanes = mipi_lanes; > > > > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0) > > > > > > > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org> > > > > > > > > Acked-by: Robert Foss <robert.foss@linaro.org> > > > > > > Tested-by: Chen-Yu Tsai <wenst@chromium.org> > > > > > > Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on > > > mainline (next-20220422). > > > > > > Xin, in the future, please send the whole series to all recipients of > > > all patches listed by get_maintainers.pl, not just the recipients of > > > each patch. In the case of this series, they should have been sent > > > to all of the mailing lists (media, devicetree, dri-devel) so that > > > everyone has the same, full view of the patches. > > Hi ChenYu, OK, I'll send to all media, devicetree, dri-devel next time. > > Thanks, > > Xin > > > > > > ChenYu > > Applied 3/4 + 4/4 to drm-misc-next. This patch doesn't even compile. Can you pls fix this up asap? Also pls compile-test before pushing ... -Daniel
On Sat, 21 May 2022 at 18:07, Daniel Vetter <daniel@ffwll.ch> wrote: > > On Tue, 17 May 2022 at 18:09, Robert Foss <robert.foss@linaro.org> wrote: > > > > On Mon, 25 Apr 2022 at 11:14, Xin Ji <xji@analogixsemi.com> wrote: > > > > > > On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote: > > > > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote: > > > > > > > > > > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote: > > > > > > > > > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote: > > > > > > > > > > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI > > > > > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it. > > > > > > > > > > > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature") > > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > > > > > > --- > > > > > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++---- > > > > > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > > > > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > > > > index 376da01243a3..71df977e8f53 100644 > > > > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev, > > > > > > > > > > > > > > anx7625_get_swing_setting(dev, pdata); > > > > > > > > > > > > > > - pdata->is_dpi = 1; /* default dpi mode */ > > > > > > > + pdata->is_dpi = 0; /* default dsi mode */ > > > > > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0); > > > > > > > if (!pdata->mipi_host_node) { > > > > > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n"); > > > > > > > return -ENODEV; > > > > > > > } > > > > > > > > > > > > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL; > > > > > > > + bus_type = 0; > > > > > > > mipi_lanes = MAX_LANES_SUPPORT; > > > > > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0); > > > > > > > if (ep0) { > > > > > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev, > > > > > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes"); > > > > > > > } > > > > > > > > > > > > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */ > > > > > > > - pdata->is_dpi = 0; > > > > > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */ > > > > > > > + pdata->is_dpi = 1; > > > > > > > > > > > > > > pdata->mipi_lanes = mipi_lanes; > > > > > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0) > > > > > > > > > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org> > > > > > > > > > > Acked-by: Robert Foss <robert.foss@linaro.org> > > > > > > > > Tested-by: Chen-Yu Tsai <wenst@chromium.org> > > > > > > > > Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on > > > > mainline (next-20220422). > > > > > > > > Xin, in the future, please send the whole series to all recipients of > > > > all patches listed by get_maintainers.pl, not just the recipients of > > > > each patch. In the case of this series, they should have been sent > > > > to all of the mailing lists (media, devicetree, dri-devel) so that > > > > everyone has the same, full view of the patches. > > > Hi ChenYu, OK, I'll send to all media, devicetree, dri-devel next time. > > > Thanks, > > > Xin > > > > > > > > ChenYu > > > > Applied 3/4 + 4/4 to drm-misc-next. > > This patch doesn't even compile. Can you pls fix this up asap? Also > pls compile-test before pushing ... Marek says the prerequisite landed through linux-media, and that's why it compilers on linux-next but not in drm-misc-next. Don't do that. Instead: - merge all patches through one branch, with the foreign patches acked for that merge patch - wait until you can backmerge all the dependencies - do a topic branch This probably needs to be reverted here and instead merged through linux-media. Or you wait until -rc1 and then apply it to drm-misc-next. -Daniel
On Sat, May 21, 2022 at 06:28:42PM +0200, Daniel Vetter wrote: > On Sat, 21 May 2022 at 18:07, Daniel Vetter <daniel@ffwll.ch> wrote: > > > > On Tue, 17 May 2022 at 18:09, Robert Foss <robert.foss@linaro.org> wrote: > > > > > > On Mon, 25 Apr 2022 at 11:14, Xin Ji <xji@analogixsemi.com> wrote: > > > > > > > > On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote: > > > > > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote: > > > > > > > > > > > > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote: > > > > > > > > > > > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote: > > > > > > > > > > > > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI > > > > > > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it. > > > > > > > > > > > > > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature") > > > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > > > > > > > --- > > > > > > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++---- > > > > > > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > > > > > > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > > > > > index 376da01243a3..71df977e8f53 100644 > > > > > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > > > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev, > > > > > > > > > > > > > > > > anx7625_get_swing_setting(dev, pdata); > > > > > > > > > > > > > > > > - pdata->is_dpi = 1; /* default dpi mode */ > > > > > > > > + pdata->is_dpi = 0; /* default dsi mode */ > > > > > > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0); > > > > > > > > if (!pdata->mipi_host_node) { > > > > > > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n"); > > > > > > > > return -ENODEV; > > > > > > > > } > > > > > > > > > > > > > > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL; > > > > > > > > + bus_type = 0; > > > > > > > > mipi_lanes = MAX_LANES_SUPPORT; > > > > > > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0); > > > > > > > > if (ep0) { > > > > > > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev, > > > > > > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes"); > > > > > > > > } > > > > > > > > > > > > > > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */ > > > > > > > > - pdata->is_dpi = 0; > > > > > > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */ > > > > > > > > + pdata->is_dpi = 1; > > > > > > > > > > > > > > > > pdata->mipi_lanes = mipi_lanes; > > > > > > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0) > > > > > > > > > > > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org> > > > > > > > > > > > > Acked-by: Robert Foss <robert.foss@linaro.org> > > > > > > > > > > Tested-by: Chen-Yu Tsai <wenst@chromium.org> > > > > > > > > > > Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on > > > > > mainline (next-20220422). > > > > > > > > > > Xin, in the future, please send the whole series to all recipients of > > > > > all patches listed by get_maintainers.pl, not just the recipients of > > > > > each patch. In the case of this series, they should have been sent > > > > > to all of the mailing lists (media, devicetree, dri-devel) so that > > > > > everyone has the same, full view of the patches. > > > > Hi ChenYu, OK, I'll send to all media, devicetree, dri-devel next time. > > > > Thanks, > > > > Xin > > > > > > > > > > ChenYu > > > > > > Applied 3/4 + 4/4 to drm-misc-next. > > > > This patch doesn't even compile. Can you pls fix this up asap? Also > > pls compile-test before pushing ... > > Marek says the prerequisite landed through linux-media, and that's why > it compilers on linux-next but not in drm-misc-next. > > Don't do that. > > Instead: > - merge all patches through one branch, with the foreign patches acked > for that merge patch > - wait until you can backmerge all the dependencies > - do a topic branch > > This probably needs to be reverted here and instead merged through > linux-media. Or you wait until -rc1 and then apply it to > drm-misc-next. > -Daniel Hi Daniel, I use git send-email to upstream patch and automatically generated reviewer list, so patch 1/4 and 2/4 send to linux-media, and these 2 patches already merged in linux-media. Thanks, Xin > -- > Daniel Vetter > Software Engineer, Intel Corporation > https://nam10.safelinks.protection.outlook.com/?url=http%3A%2F%2Fblog.ffwll.ch%2F&data=05%7C01%7Cxji%40analogixsemi.com%7C80ac2fb262a5407ded4208da3b46ff62%7Cb099b0b4f26c4cf59a0fd5be9acab205%7C0%7C0%7C637887473373535347%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=lYWBVSLPiHKN%2BYnyWqgeM5cgH17OjxpXGVQ1kt2bZrU%3D&reserved=0
On Mon, May 23, 2022 at 11:13 AM Xin Ji <xji@analogixsemi.com> wrote: > > On Sat, May 21, 2022 at 06:28:42PM +0200, Daniel Vetter wrote: > > On Sat, 21 May 2022 at 18:07, Daniel Vetter <daniel@ffwll.ch> wrote: > > > > > > On Tue, 17 May 2022 at 18:09, Robert Foss <robert.foss@linaro.org> wrote: > > > > > > > > On Mon, 25 Apr 2022 at 11:14, Xin Ji <xji@analogixsemi.com> wrote: > > > > > > > > > > On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote: > > > > > > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote: > > > > > > > > > > > > > > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote: > > > > > > > > > > > > > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote: > > > > > > > > > > > > > > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI > > > > > > > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it. > > > > > > > > > > > > > > > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature") > > > > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > > > > > > > > --- > > > > > > > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++---- > > > > > > > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > > > > > > > > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > > > > > > index 376da01243a3..71df977e8f53 100644 > > > > > > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > > > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > > > > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev, > > > > > > > > > > > > > > > > > > anx7625_get_swing_setting(dev, pdata); > > > > > > > > > > > > > > > > > > - pdata->is_dpi = 1; /* default dpi mode */ > > > > > > > > > + pdata->is_dpi = 0; /* default dsi mode */ > > > > > > > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0); > > > > > > > > > if (!pdata->mipi_host_node) { > > > > > > > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n"); > > > > > > > > > return -ENODEV; > > > > > > > > > } > > > > > > > > > > > > > > > > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL; > > > > > > > > > + bus_type = 0; > > > > > > > > > mipi_lanes = MAX_LANES_SUPPORT; > > > > > > > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0); > > > > > > > > > if (ep0) { > > > > > > > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev, > > > > > > > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes"); > > > > > > > > > } > > > > > > > > > > > > > > > > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */ > > > > > > > > > - pdata->is_dpi = 0; > > > > > > > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */ > > > > > > > > > + pdata->is_dpi = 1; > > > > > > > > > > > > > > > > > > pdata->mipi_lanes = mipi_lanes; > > > > > > > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0) > > > > > > > > > > > > > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org> > > > > > > > > > > > > > > Acked-by: Robert Foss <robert.foss@linaro.org> > > > > > > > > > > > > Tested-by: Chen-Yu Tsai <wenst@chromium.org> > > > > > > > > > > > > Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on > > > > > > mainline (next-20220422). > > > > > > > > > > > > Xin, in the future, please send the whole series to all recipients of > > > > > > all patches listed by get_maintainers.pl, not just the recipients of > > > > > > each patch. In the case of this series, they should have been sent > > > > > > to all of the mailing lists (media, devicetree, dri-devel) so that > > > > > > everyone has the same, full view of the patches. > > > > > Hi ChenYu, OK, I'll send to all media, devicetree, dri-devel next time. > > > > > Thanks, > > > > > Xin > > > > > > > > > > > > ChenYu > > > > > > > > Applied 3/4 + 4/4 to drm-misc-next. > > > > > > This patch doesn't even compile. Can you pls fix this up asap? Also > > > pls compile-test before pushing ... > > > > Marek says the prerequisite landed through linux-media, and that's why > > it compilers on linux-next but not in drm-misc-next. > > > > Don't do that. > > > > Instead: > > - merge all patches through one branch, with the foreign patches acked > > for that merge patch > > - wait until you can backmerge all the dependencies > > - do a topic branch > > > > This probably needs to be reverted here and instead merged through > > linux-media. Or you wait until -rc1 and then apply it to > > drm-misc-next. > > -Daniel > Hi Daniel, I use git send-email to upstream patch and automatically > generated reviewer list, so patch 1/4 and 2/4 send to linux-media, and > these 2 patches already merged in linux-media. This is one of the reasons why you should always send the "full" series to all recipients. That way people, especially maintainers, are more likely to notice build time cross tree dependencies like this one, and work towards a common resolution. ChenYu
On Mon, 23 May 2022 at 09:18, Chen-Yu Tsai <wenst@chromium.org> wrote: > > On Mon, May 23, 2022 at 11:13 AM Xin Ji <xji@analogixsemi.com> wrote: > > > > On Sat, May 21, 2022 at 06:28:42PM +0200, Daniel Vetter wrote: > > > On Sat, 21 May 2022 at 18:07, Daniel Vetter <daniel@ffwll.ch> wrote: > > > > > > > > On Tue, 17 May 2022 at 18:09, Robert Foss <robert.foss@linaro.org> wrote: > > > > > > > > > > On Mon, 25 Apr 2022 at 11:14, Xin Ji <xji@analogixsemi.com> wrote: > > > > > > > > > > > > On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote: > > > > > > > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote: > > > > > > > > > > > > > > > > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote: > > > > > > > > > > > > > > > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote: > > > > > > > > > > > > > > > > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI > > > > > > > > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it. > > > > > > > > > > > > > > > > > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature") > > > > > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > > > > > > > > > --- > > > > > > > > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++---- > > > > > > > > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > > > > > > > > > > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > > > > > > > index 376da01243a3..71df977e8f53 100644 > > > > > > > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > > > > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > > > > > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev, > > > > > > > > > > > > > > > > > > > > anx7625_get_swing_setting(dev, pdata); > > > > > > > > > > > > > > > > > > > > - pdata->is_dpi = 1; /* default dpi mode */ > > > > > > > > > > + pdata->is_dpi = 0; /* default dsi mode */ > > > > > > > > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0); > > > > > > > > > > if (!pdata->mipi_host_node) { > > > > > > > > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n"); > > > > > > > > > > return -ENODEV; > > > > > > > > > > } > > > > > > > > > > > > > > > > > > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL; > > > > > > > > > > + bus_type = 0; > > > > > > > > > > mipi_lanes = MAX_LANES_SUPPORT; > > > > > > > > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0); > > > > > > > > > > if (ep0) { > > > > > > > > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev, > > > > > > > > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes"); > > > > > > > > > > } > > > > > > > > > > > > > > > > > > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */ > > > > > > > > > > - pdata->is_dpi = 0; > > > > > > > > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */ > > > > > > > > > > + pdata->is_dpi = 1; > > > > > > > > > > > > > > > > > > > > pdata->mipi_lanes = mipi_lanes; > > > > > > > > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0) > > > > > > > > > > > > > > > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org> > > > > > > > > > > > > > > > > Acked-by: Robert Foss <robert.foss@linaro.org> > > > > > > > > > > > > > > Tested-by: Chen-Yu Tsai <wenst@chromium.org> > > > > > > > > > > > > > > Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on > > > > > > > mainline (next-20220422). > > > > > > > > > > > > > > Xin, in the future, please send the whole series to all recipients of > > > > > > > all patches listed by get_maintainers.pl, not just the recipients of > > > > > > > each patch. In the case of this series, they should have been sent > > > > > > > to all of the mailing lists (media, devicetree, dri-devel) so that > > > > > > > everyone has the same, full view of the patches. > > > > > > Hi ChenYu, OK, I'll send to all media, devicetree, dri-devel next time. > > > > > > Thanks, > > > > > > Xin > > > > > > > > > > > > > > ChenYu > > > > > > > > > > Applied 3/4 + 4/4 to drm-misc-next. > > > > > > > > This patch doesn't even compile. Can you pls fix this up asap? Also > > > > pls compile-test before pushing ... > > > > > > Marek says the prerequisite landed through linux-media, and that's why > > > it compilers on linux-next but not in drm-misc-next. > > > > > > Don't do that. > > > > > > Instead: > > > - merge all patches through one branch, with the foreign patches acked > > > for that merge patch > > > - wait until you can backmerge all the dependencies > > > - do a topic branch > > > > > > This probably needs to be reverted here and instead merged through > > > linux-media. Or you wait until -rc1 and then apply it to > > > drm-misc-next. > > > -Daniel > > Hi Daniel, I use git send-email to upstream patch and automatically > > generated reviewer list, so patch 1/4 and 2/4 send to linux-media, and > > these 2 patches already merged in linux-media. > > This is one of the reasons why you should always send the "full" series > to all recipients. That way people, especially maintainers, are more > likely to notice build time cross tree dependencies like this one, and > work towards a common resolution. This mistake is mine, and I think the best solution is to revert 3+4 until rc1. I'll send out the revert patches to the ML right away. Rob.
https://lore.kernel.org/all/20220523084615.13510-1-robert.foss@linaro.org/
Hi, On Mon, May 23, 2022 at 4:37 PM Robert Foss <robert.foss@linaro.org> wrote: > > On Mon, 23 May 2022 at 09:18, Chen-Yu Tsai <wenst@chromium.org> wrote: > > > > On Mon, May 23, 2022 at 11:13 AM Xin Ji <xji@analogixsemi.com> wrote: > > > > > > On Sat, May 21, 2022 at 06:28:42PM +0200, Daniel Vetter wrote: > > > > On Sat, 21 May 2022 at 18:07, Daniel Vetter <daniel@ffwll.ch> wrote: > > > > > > > > > > On Tue, 17 May 2022 at 18:09, Robert Foss <robert.foss@linaro.org> wrote: > > > > > > > > > > > > On Mon, 25 Apr 2022 at 11:14, Xin Ji <xji@analogixsemi.com> wrote: > > > > > > > > > > > > > > On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote: > > > > > > > > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote: > > > > > > > > > > > > > > > > > > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote: > > > > > > > > > > > > > > > > > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote: > > > > > > > > > > > > > > > > > > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI > > > > > > > > > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it. > > > > > > > > > > > > > > > > > > > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature") > > > > > > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > > > > > > > > > > --- > > > > > > > > > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++---- > > > > > > > > > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > > > > > > > > > > > > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > > > > > > > > index 376da01243a3..71df977e8f53 100644 > > > > > > > > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > > > > > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > > > > > > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev, > > > > > > > > > > > > > > > > > > > > > > anx7625_get_swing_setting(dev, pdata); > > > > > > > > > > > > > > > > > > > > > > - pdata->is_dpi = 1; /* default dpi mode */ > > > > > > > > > > > + pdata->is_dpi = 0; /* default dsi mode */ > > > > > > > > > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0); > > > > > > > > > > > if (!pdata->mipi_host_node) { > > > > > > > > > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n"); > > > > > > > > > > > return -ENODEV; > > > > > > > > > > > } > > > > > > > > > > > > > > > > > > > > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL; > > > > > > > > > > > + bus_type = 0; > > > > > > > > > > > mipi_lanes = MAX_LANES_SUPPORT; > > > > > > > > > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0); > > > > > > > > > > > if (ep0) { > > > > > > > > > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev, > > > > > > > > > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes"); > > > > > > > > > > > } > > > > > > > > > > > > > > > > > > > > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */ > > > > > > > > > > > - pdata->is_dpi = 0; > > > > > > > > > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */ > > > > > > > > > > > + pdata->is_dpi = 1; > > > > > > > > > > > > > > > > > > > > > > pdata->mipi_lanes = mipi_lanes; > > > > > > > > > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0) > > > > > > > > > > > > > > > > > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org> > > > > > > > > > > > > > > > > > > Acked-by: Robert Foss <robert.foss@linaro.org> > > > > > > > > > > > > > > > > Tested-by: Chen-Yu Tsai <wenst@chromium.org> > > > > > > > > > > > > > > > > Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on > > > > > > > > mainline (next-20220422). > > > > > > > > > > > > > > > > Xin, in the future, please send the whole series to all recipients of > > > > > > > > all patches listed by get_maintainers.pl, not just the recipients of > > > > > > > > each patch. In the case of this series, they should have been sent > > > > > > > > to all of the mailing lists (media, devicetree, dri-devel) so that > > > > > > > > everyone has the same, full view of the patches. > > > > > > > Hi ChenYu, OK, I'll send to all media, devicetree, dri-devel next time. > > > > > > > Thanks, > > > > > > > Xin > > > > > > > > > > > > > > > > ChenYu > > > > > > > > > > > > Applied 3/4 + 4/4 to drm-misc-next. > > > > > > > > > > This patch doesn't even compile. Can you pls fix this up asap? Also > > > > > pls compile-test before pushing ... > > > > > > > > Marek says the prerequisite landed through linux-media, and that's why > > > > it compilers on linux-next but not in drm-misc-next. > > > > > > > > Don't do that. > > > > > > > > Instead: > > > > - merge all patches through one branch, with the foreign patches acked > > > > for that merge patch > > > > - wait until you can backmerge all the dependencies > > > > - do a topic branch > > > > > > > > This probably needs to be reverted here and instead merged through > > > > linux-media. Or you wait until -rc1 and then apply it to > > > > drm-misc-next. > > > > -Daniel > > > Hi Daniel, I use git send-email to upstream patch and automatically > > > generated reviewer list, so patch 1/4 and 2/4 send to linux-media, and > > > these 2 patches already merged in linux-media. > > > > This is one of the reasons why you should always send the "full" series > > to all recipients. That way people, especially maintainers, are more > > likely to notice build time cross tree dependencies like this one, and > > work towards a common resolution. > > This mistake is mine, and I think the best solution is to revert 3+4 until rc1. I think we can reland the patches now? ChenYu > I'll send out the revert patches to the ML right away. > > > Rob.
On Fri, 17 Jun 2022 at 12:32, Chen-Yu Tsai <wenst@chromium.org> wrote: > > Hi, > > On Mon, May 23, 2022 at 4:37 PM Robert Foss <robert.foss@linaro.org> wrote: > > > > On Mon, 23 May 2022 at 09:18, Chen-Yu Tsai <wenst@chromium.org> wrote: > > > > > > On Mon, May 23, 2022 at 11:13 AM Xin Ji <xji@analogixsemi.com> wrote: > > > > > > > > On Sat, May 21, 2022 at 06:28:42PM +0200, Daniel Vetter wrote: > > > > > On Sat, 21 May 2022 at 18:07, Daniel Vetter <daniel@ffwll.ch> wrote: > > > > > > > > > > > > On Tue, 17 May 2022 at 18:09, Robert Foss <robert.foss@linaro.org> wrote: > > > > > > > > > > > > > > On Mon, 25 Apr 2022 at 11:14, Xin Ji <xji@analogixsemi.com> wrote: > > > > > > > > > > > > > > > > On Mon, Apr 25, 2022 at 04:24:50PM +0800, Chen-Yu Tsai wrote: > > > > > > > > > On Fri, Apr 22, 2022 at 10:13 PM Robert Foss <robert.foss@linaro.org> wrote: > > > > > > > > > > > > > > > > > > > > On Fri, 22 Apr 2022 at 16:01, Robert Foss <robert.foss@linaro.org> wrote: > > > > > > > > > > > > > > > > > > > > > > On Fri, 22 Apr 2022 at 10:49, Xin Ji <xji@analogixsemi.com> wrote: > > > > > > > > > > > > > > > > > > > > > > > > As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI > > > > > > > > > > > > interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it. > > > > > > > > > > > > > > > > > > > > > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature") > > > > > > > > > > > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > > > > > > > > > > > > --- > > > > > > > > > > > > drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++---- > > > > > > > > > > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > > > > > > > > > > > > > > > > > > > > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > > > > > > > > > index 376da01243a3..71df977e8f53 100644 > > > > > > > > > > > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > > > > > > > > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > > > > > > > > > > > > @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev, > > > > > > > > > > > > > > > > > > > > > > > > anx7625_get_swing_setting(dev, pdata); > > > > > > > > > > > > > > > > > > > > > > > > - pdata->is_dpi = 1; /* default dpi mode */ > > > > > > > > > > > > + pdata->is_dpi = 0; /* default dsi mode */ > > > > > > > > > > > > pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0); > > > > > > > > > > > > if (!pdata->mipi_host_node) { > > > > > > > > > > > > DRM_DEV_ERROR(dev, "fail to get internal panel.\n"); > > > > > > > > > > > > return -ENODEV; > > > > > > > > > > > > } > > > > > > > > > > > > > > > > > > > > > > > > - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL; > > > > > > > > > > > > + bus_type = 0; > > > > > > > > > > > > mipi_lanes = MAX_LANES_SUPPORT; > > > > > > > > > > > > ep0 = of_graph_get_endpoint_by_regs(np, 0, 0); > > > > > > > > > > > > if (ep0) { > > > > > > > > > > > > @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev, > > > > > > > > > > > > mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes"); > > > > > > > > > > > > } > > > > > > > > > > > > > > > > > > > > > > > > - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */ > > > > > > > > > > > > - pdata->is_dpi = 0; > > > > > > > > > > > > + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */ > > > > > > > > > > > > + pdata->is_dpi = 1; > > > > > > > > > > > > > > > > > > > > > > > > pdata->mipi_lanes = mipi_lanes; > > > > > > > > > > > > if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0) > > > > > > > > > > > > > > > > > > > > > > Reviewed-by: Robert Foss <robert.foss@linaro.org> > > > > > > > > > > > > > > > > > > > > Acked-by: Robert Foss <robert.foss@linaro.org> > > > > > > > > > > > > > > > > > > Tested-by: Chen-Yu Tsai <wenst@chromium.org> > > > > > > > > > > > > > > > > > > Confirmed this fixes the display on Juniper (Acer Chromebook Spin 311) on > > > > > > > > > mainline (next-20220422). > > > > > > > > > > > > > > > > > > Xin, in the future, please send the whole series to all recipients of > > > > > > > > > all patches listed by get_maintainers.pl, not just the recipients of > > > > > > > > > each patch. In the case of this series, they should have been sent > > > > > > > > > to all of the mailing lists (media, devicetree, dri-devel) so that > > > > > > > > > everyone has the same, full view of the patches. > > > > > > > > Hi ChenYu, OK, I'll send to all media, devicetree, dri-devel next time. > > > > > > > > Thanks, > > > > > > > > Xin > > > > > > > > > > > > > > > > > > ChenYu > > > > > > > > > > > > > > Applied 3/4 + 4/4 to drm-misc-next. > > > > > > > > > > > > This patch doesn't even compile. Can you pls fix this up asap? Also > > > > > > pls compile-test before pushing ... > > > > > > > > > > Marek says the prerequisite landed through linux-media, and that's why > > > > > it compilers on linux-next but not in drm-misc-next. > > > > > > > > > > Don't do that. > > > > > > > > > > Instead: > > > > > - merge all patches through one branch, with the foreign patches acked > > > > > for that merge patch > > > > > - wait until you can backmerge all the dependencies > > > > > - do a topic branch > > > > > > > > > > This probably needs to be reverted here and instead merged through > > > > > linux-media. Or you wait until -rc1 and then apply it to > > > > > drm-misc-next. > > > > > -Daniel > > > > Hi Daniel, I use git send-email to upstream patch and automatically > > > > generated reviewer list, so patch 1/4 and 2/4 send to linux-media, and > > > > these 2 patches already merged in linux-media. > > > > > > This is one of the reasons why you should always send the "full" series > > > to all recipients. That way people, especially maintainers, are more > > > likely to notice build time cross tree dependencies like this one, and > > > work towards a common resolution. > > > > This mistake is mine, and I think the best solution is to revert 3+4 until rc1. > > I think we can reland the patches now? Re-applied 3/4 + 4/4 to drm-misc-next.
diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c index 376da01243a3..71df977e8f53 100644 --- a/drivers/gpu/drm/bridge/analogix/anx7625.c +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c @@ -1623,14 +1623,14 @@ static int anx7625_parse_dt(struct device *dev, anx7625_get_swing_setting(dev, pdata); - pdata->is_dpi = 1; /* default dpi mode */ + pdata->is_dpi = 0; /* default dsi mode */ pdata->mipi_host_node = of_graph_get_remote_node(np, 0, 0); if (!pdata->mipi_host_node) { DRM_DEV_ERROR(dev, "fail to get internal panel.\n"); return -ENODEV; } - bus_type = V4L2_FWNODE_BUS_TYPE_PARALLEL; + bus_type = 0; mipi_lanes = MAX_LANES_SUPPORT; ep0 = of_graph_get_endpoint_by_regs(np, 0, 0); if (ep0) { @@ -1640,8 +1640,8 @@ static int anx7625_parse_dt(struct device *dev, mipi_lanes = of_property_count_u32_elems(ep0, "data-lanes"); } - if (bus_type == V4L2_FWNODE_BUS_TYPE_PARALLEL) /* bus type is Parallel(DSI) */ - pdata->is_dpi = 0; + if (bus_type == V4L2_FWNODE_BUS_TYPE_DPI) /* bus type is DPI */ + pdata->is_dpi = 1; pdata->mipi_lanes = mipi_lanes; if (pdata->mipi_lanes > MAX_LANES_SUPPORT || pdata->mipi_lanes <= 0)
As V4L2_FWNODE_BUS_TYPE_PARALLEL not properly descript for DPI interface, this patch use new defined V4L2_FWNODE_BUS_TYPE_DPI for it. Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature") Signed-off-by: Xin Ji <xji@analogixsemi.com> --- drivers/gpu/drm/bridge/analogix/anx7625.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)