| Message ID | dd6fe7f67e2f8c917aabd6eb0e0deccc660b48c2.1655509425.git.jahau@rocketmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add support for magnetometer Yamaha YAS537 | expand |
On Sat, 18 Jun 2022 02:13:09 +0200 Jakob Hauser <jahau@rocketmail.com> wrote: > The "hard_offsets" are currently unsigned u8 but they should be signed as they > can get negative. They are signed in function yas5xx_meaure_offsets() and in the > Yamaha drivers [1][2]. > > [1] https://github.com/NovaFusion/android_kernel_samsung_golden/blob/cm-12.1/drivers/sensor/compass/yas.h#L156 > [2] https://github.com/msm8916-mainline/android_kernel_qcom_msm8916/blob/GT-I9195I/drivers/iio/magnetometer/yas_mag_drv-yas532.c#L91 > > Fixes: de8860b1ed47 ("iio: magnetometer: Add driver for Yamaha YAS530") > Cc: Linus Walleij <linus.walleij@linaro.org> Trivial but it's nice to clean out CC if you also have a tag from the person. All the automation will generally send emails to anyone who has given a tag so the CC doesn't add anything at this point I try to drop cases of this when applying patches, but if it's done by the submitter it makes my life a little easier! Thanks, Jonathan > Signed-off-by: Jakob Hauser <jahau@rocketmail.com> > Reviewed-by: Linus Walleij <linus.walleij@linaro.org> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > --- > drivers/iio/magnetometer/yamaha-yas530.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/magnetometer/yamaha-yas530.c b/drivers/iio/magnetometer/yamaha-yas530.c > index b2bc637150bf..40192aa46b04 100644 > --- a/drivers/iio/magnetometer/yamaha-yas530.c > +++ b/drivers/iio/magnetometer/yamaha-yas530.c > @@ -132,7 +132,7 @@ struct yas5xx { > unsigned int version; > char name[16]; > struct yas5xx_calibration calibration; > - u8 hard_offsets[3]; > + s8 hard_offsets[3]; > struct iio_mount_matrix orientation; > struct regmap *map; > struct regulator_bulk_data regs[2];
Hi Jonathan, On 18.06.22 16:18, Jonathan Cameron wrote: > > On Sat, 18 Jun 2022 02:13:09 +0200 > Jakob Hauser <jahau@rocketmail.com> wrote: > >> The "hard_offsets" are currently unsigned u8 but they should be signed as they >> can get negative. They are signed in function yas5xx_meaure_offsets() and in the >> Yamaha drivers [1][2]. >> >> [1] https://github.com/NovaFusion/android_kernel_samsung_golden/blob/cm-12.1/drivers/sensor/compass/yas.h#L156 >> [2] https://github.com/msm8916-mainline/android_kernel_qcom_msm8916/blob/GT-I9195I/drivers/iio/magnetometer/yas_mag_drv-yas532.c#L91 >> >> Fixes: de8860b1ed47 ("iio: magnetometer: Add driver for Yamaha YAS530") >> Cc: Linus Walleij <linus.walleij@linaro.org> > > Trivial but it's nice to clean out CC if you also have a tag from the person. > All the automation will generally send emails to anyone who has given a tag > so the CC doesn't add anything at this point > > I try to drop cases of this when applying patches, but if it's done by > the submitter it makes my life a little easier! I didn't know, thanks for explaining. I'll remove the redundant Cc's. Kind regards, Jakob ...
diff --git a/drivers/iio/magnetometer/yamaha-yas530.c b/drivers/iio/magnetometer/yamaha-yas530.c index b2bc637150bf..40192aa46b04 100644 --- a/drivers/iio/magnetometer/yamaha-yas530.c +++ b/drivers/iio/magnetometer/yamaha-yas530.c @@ -132,7 +132,7 @@ struct yas5xx { unsigned int version; char name[16]; struct yas5xx_calibration calibration; - u8 hard_offsets[3]; + s8 hard_offsets[3]; struct iio_mount_matrix orientation; struct regmap *map; struct regulator_bulk_data regs[2];
The "hard_offsets" are currently unsigned u8 but they should be signed as they can get negative. They are signed in function yas5xx_meaure_offsets() and in the Yamaha drivers [1][2]. [1] https://github.com/NovaFusion/android_kernel_samsung_golden/blob/cm-12.1/drivers/sensor/compass/yas.h#L156 [2] https://github.com/msm8916-mainline/android_kernel_qcom_msm8916/blob/GT-I9195I/drivers/iio/magnetometer/yas_mag_drv-yas532.c#L91 Fixes: de8860b1ed47 ("iio: magnetometer: Add driver for Yamaha YAS530") Cc: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Jakob Hauser <jahau@rocketmail.com> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> --- drivers/iio/magnetometer/yamaha-yas530.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)