| Message ID | 20220604155306.422937-1-jic23@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | 3rd set of IIO export namespaces. | expand |
On Sat, 4 Jun 2022 16:53:02 +0100 Jonathan Cameron <jic23@kernel.org> wrote: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Changes since v1: > - Rebase (bit of fuzz in patches 1 and 4) If anyone has time to take a quick look through this lot and sanity check I haven't done anything stupid it would be much appreciated. Disadvantage of being the maintainer is there isn't anyone else you can moan about when no one reviews your patches. Of course I never moan about other maintainers and I'm sure no one ever moans about me :) > > I sent v1 out in Feb and only got review on one patch (which I've since > applied - thanks Nuno). > > Looking for a quick sanity check of these 4 that remain from anyone who > has the time. Whilst this is mechanical stuff, I've made enough dumb > mistakes in such patches over the years that I still like to get a second > set of eyes on them if at all possible! > > Cc: Tomasz Duszynski <tomasz.duszynski@octakon.com> > Cc: Nuno Sá <nuno.sa@analog.com> > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Cc: Siddartha Mohanadoss <smohanad@codeaurora.org> > > Jonathan Cameron (4): > iio: imu: bmi160: Move exported symbols to IIO_BMI160 namespace > iio: pressure: bmp280: Move symbol exports to IIO_BMP280 namespace > iio: chemical: sps30: Move symbol exports into IIO_SPS30 namespace > iio: adc: qcom-vadc: Move symbol exports to IIO_QCOM_VADC namespace > > drivers/iio/adc/qcom-pm8xxx-xoadc.c | 1 + > drivers/iio/adc/qcom-spmi-adc5.c | 1 + > drivers/iio/adc/qcom-spmi-vadc.c | 1 + > drivers/iio/adc/qcom-vadc-common.c | 16 ++++++++-------- > drivers/iio/chemical/sps30.c | 2 +- > drivers/iio/chemical/sps30_i2c.c | 1 + > drivers/iio/chemical/sps30_serial.c | 1 + > drivers/iio/imu/bmi160/bmi160_core.c | 6 +++--- > drivers/iio/imu/bmi160/bmi160_i2c.c | 1 + > drivers/iio/imu/bmi160/bmi160_spi.c | 1 + > drivers/iio/pressure/bmp280-core.c | 2 +- > drivers/iio/pressure/bmp280-i2c.c | 1 + > drivers/iio/pressure/bmp280-regmap.c | 4 ++-- > drivers/iio/pressure/bmp280-spi.c | 1 + > 14 files changed, 24 insertions(+), 15 deletions(-) >
On Sat, Jun 18, 2022 at 02:20:54PM +0100, Jonathan Cameron wrote: > On Sat, 4 Jun 2022 16:53:02 +0100 > Jonathan Cameron <jic23@kernel.org> wrote: > > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > Changes since v1: > > - Rebase (bit of fuzz in patches 1 and 4) > > If anyone has time to take a quick look through this lot and sanity > check I haven't done anything stupid it would be much appreciated. FWIW, 1 through 4 look good to me. Reviewed-By: Joe Simmons-Talbott <joetalbott@gmail.com> Joe > > Disadvantage of being the maintainer is there isn't anyone else you > can moan about when no one reviews your patches. Of course I never > moan about other maintainers and I'm sure no one ever moans > about me :) > > > > > I sent v1 out in Feb and only got review on one patch (which I've since > > applied - thanks Nuno). > > > > Looking for a quick sanity check of these 4 that remain from anyone who > > has the time. Whilst this is mechanical stuff, I've made enough dumb > > mistakes in such patches over the years that I still like to get a second > > set of eyes on them if at all possible! > > > > Cc: Tomasz Duszynski <tomasz.duszynski@octakon.com> > > Cc: Nuno Sá <nuno.sa@analog.com> > > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Cc: Siddartha Mohanadoss <smohanad@codeaurora.org> > > > > Jonathan Cameron (4): > > iio: imu: bmi160: Move exported symbols to IIO_BMI160 namespace > > iio: pressure: bmp280: Move symbol exports to IIO_BMP280 namespace > > iio: chemical: sps30: Move symbol exports into IIO_SPS30 namespace > > iio: adc: qcom-vadc: Move symbol exports to IIO_QCOM_VADC namespace > > > > drivers/iio/adc/qcom-pm8xxx-xoadc.c | 1 + > > drivers/iio/adc/qcom-spmi-adc5.c | 1 + > > drivers/iio/adc/qcom-spmi-vadc.c | 1 + > > drivers/iio/adc/qcom-vadc-common.c | 16 ++++++++-------- > > drivers/iio/chemical/sps30.c | 2 +- > > drivers/iio/chemical/sps30_i2c.c | 1 + > > drivers/iio/chemical/sps30_serial.c | 1 + > > drivers/iio/imu/bmi160/bmi160_core.c | 6 +++--- > > drivers/iio/imu/bmi160/bmi160_i2c.c | 1 + > > drivers/iio/imu/bmi160/bmi160_spi.c | 1 + > > drivers/iio/pressure/bmp280-core.c | 2 +- > > drivers/iio/pressure/bmp280-i2c.c | 1 + > > drivers/iio/pressure/bmp280-regmap.c | 4 ++-- > > drivers/iio/pressure/bmp280-spi.c | 1 + > > 14 files changed, 24 insertions(+), 15 deletions(-) > > >
On Mon, 20 Jun 2022 23:37:22 -0400 Joe Simmons-Talbott <joetalbott@gmail.com> wrote: > On Sat, Jun 18, 2022 at 02:20:54PM +0100, Jonathan Cameron wrote: > > On Sat, 4 Jun 2022 16:53:02 +0100 > > Jonathan Cameron <jic23@kernel.org> wrote: > > > > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > > > Changes since v1: > > > - Rebase (bit of fuzz in patches 1 and 4) > > > > If anyone has time to take a quick look through this lot and sanity > > check I haven't done anything stupid it would be much appreciated. > > FWIW, 1 through 4 look good to me. > > Reviewed-By: Joe Simmons-Talbott <joetalbott@gmail.com> > Thanks! Applied to the togreg branch of iio.git and pushed out as testing to see if 0-day finds anything we missed. Thanks, Jonathan > Joe > > > > Disadvantage of being the maintainer is there isn't anyone else you > > can moan about when no one reviews your patches. Of course I never > > moan about other maintainers and I'm sure no one ever moans > > about me :) > > > > > > > > I sent v1 out in Feb and only got review on one patch (which I've since > > > applied - thanks Nuno). > > > > > > Looking for a quick sanity check of these 4 that remain from anyone who > > > has the time. Whilst this is mechanical stuff, I've made enough dumb > > > mistakes in such patches over the years that I still like to get a second > > > set of eyes on them if at all possible! > > > > > > Cc: Tomasz Duszynski <tomasz.duszynski@octakon.com> > > > Cc: Nuno Sá <nuno.sa@analog.com> > > > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > Cc: Siddartha Mohanadoss <smohanad@codeaurora.org> > > > > > > Jonathan Cameron (4): > > > iio: imu: bmi160: Move exported symbols to IIO_BMI160 namespace > > > iio: pressure: bmp280: Move symbol exports to IIO_BMP280 namespace > > > iio: chemical: sps30: Move symbol exports into IIO_SPS30 namespace > > > iio: adc: qcom-vadc: Move symbol exports to IIO_QCOM_VADC namespace > > > > > > drivers/iio/adc/qcom-pm8xxx-xoadc.c | 1 + > > > drivers/iio/adc/qcom-spmi-adc5.c | 1 + > > > drivers/iio/adc/qcom-spmi-vadc.c | 1 + > > > drivers/iio/adc/qcom-vadc-common.c | 16 ++++++++-------- > > > drivers/iio/chemical/sps30.c | 2 +- > > > drivers/iio/chemical/sps30_i2c.c | 1 + > > > drivers/iio/chemical/sps30_serial.c | 1 + > > > drivers/iio/imu/bmi160/bmi160_core.c | 6 +++--- > > > drivers/iio/imu/bmi160/bmi160_i2c.c | 1 + > > > drivers/iio/imu/bmi160/bmi160_spi.c | 1 + > > > drivers/iio/pressure/bmp280-core.c | 2 +- > > > drivers/iio/pressure/bmp280-i2c.c | 1 + > > > drivers/iio/pressure/bmp280-regmap.c | 4 ++-- > > > drivers/iio/pressure/bmp280-spi.c | 1 + > > > 14 files changed, 24 insertions(+), 15 deletions(-) > > > > >
From: Jonathan Cameron <Jonathan.Cameron@huawei.com> Changes since v1: - Rebase (bit of fuzz in patches 1 and 4) I sent v1 out in Feb and only got review on one patch (which I've since applied - thanks Nuno). Looking for a quick sanity check of these 4 that remain from anyone who has the time. Whilst this is mechanical stuff, I've made enough dumb mistakes in such patches over the years that I still like to get a second set of eyes on them if at all possible! Cc: Tomasz Duszynski <tomasz.duszynski@octakon.com> Cc: Nuno Sá <nuno.sa@analog.com> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: Siddartha Mohanadoss <smohanad@codeaurora.org> Jonathan Cameron (4): iio: imu: bmi160: Move exported symbols to IIO_BMI160 namespace iio: pressure: bmp280: Move symbol exports to IIO_BMP280 namespace iio: chemical: sps30: Move symbol exports into IIO_SPS30 namespace iio: adc: qcom-vadc: Move symbol exports to IIO_QCOM_VADC namespace drivers/iio/adc/qcom-pm8xxx-xoadc.c | 1 + drivers/iio/adc/qcom-spmi-adc5.c | 1 + drivers/iio/adc/qcom-spmi-vadc.c | 1 + drivers/iio/adc/qcom-vadc-common.c | 16 ++++++++-------- drivers/iio/chemical/sps30.c | 2 +- drivers/iio/chemical/sps30_i2c.c | 1 + drivers/iio/chemical/sps30_serial.c | 1 + drivers/iio/imu/bmi160/bmi160_core.c | 6 +++--- drivers/iio/imu/bmi160/bmi160_i2c.c | 1 + drivers/iio/imu/bmi160/bmi160_spi.c | 1 + drivers/iio/pressure/bmp280-core.c | 2 +- drivers/iio/pressure/bmp280-i2c.c | 1 + drivers/iio/pressure/bmp280-regmap.c | 4 ++-- drivers/iio/pressure/bmp280-spi.c | 1 + 14 files changed, 24 insertions(+), 15 deletions(-)