| Message ID | 20220404095609.3932782-1-michael@walle.cc (mailing list archive) |
|---|---|
| Headers | show |
| Series | soc: fsl: guts: cleanups and serial_number support | expand |
Am 2022-04-04 11:56, schrieb Michael Walle: > [Resend because of new development cycle. Shawn, can this series get > through your tree? Sorry you weren't on CC on the former submissions.] > > This series converts the guts driver from a platform driver to just an > core_initcall. The driver itself cannot (or rather should never) be > unloaded because others depends on detecting the current SoC revision > to apply chip errata. Other SoC drivers do it the same way. Overall I > got rid of all the global static variables. > > The last patch finally adds unique id support to the guts driver. DT > binding can be found at: > Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml > > changes since v1: > - call kfree() in error case, thanks Dan > - add missing of_node_put(np), thanks Dan > > Michael Walle (7): > soc: fsl: guts: machine variable might be unset > soc: fsl: guts: remove module_exit() and fsl_guts_remove() > soc: fsl: guts: embed fsl_guts_get_svr() in probe() > soc: fsl: guts: allocate soc_dev_attr on the heap > soc: fsl: guts: use of_root instead of own reference > soc: fsl: guts: drop platform driver > soc: fsl: guts: add serial_number support > > drivers/soc/fsl/guts.c | 219 ++++++++++++++++++++++------------------- > 1 file changed, 118 insertions(+), 101 deletions(-) There goes another kernel release without any comments on this series :( Shawn, can you pick this up and give it some time in linux-next? -michael
On Wed, Jun 22, 2022 at 01:03:33PM +0200, Michael Walle wrote: > Am 2022-04-04 11:56, schrieb Michael Walle: > > [Resend because of new development cycle. Shawn, can this series get > > through your tree? Sorry you weren't on CC on the former submissions.] > > > > This series converts the guts driver from a platform driver to just an > > core_initcall. The driver itself cannot (or rather should never) be > > unloaded because others depends on detecting the current SoC revision > > to apply chip errata. Other SoC drivers do it the same way. Overall I > > got rid of all the global static variables. > > > > The last patch finally adds unique id support to the guts driver. DT > > binding can be found at: > > Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml > > > > changes since v1: > > - call kfree() in error case, thanks Dan > > - add missing of_node_put(np), thanks Dan > > > > Michael Walle (7): > > soc: fsl: guts: machine variable might be unset > > soc: fsl: guts: remove module_exit() and fsl_guts_remove() > > soc: fsl: guts: embed fsl_guts_get_svr() in probe() > > soc: fsl: guts: allocate soc_dev_attr on the heap > > soc: fsl: guts: use of_root instead of own reference > > soc: fsl: guts: drop platform driver > > soc: fsl: guts: add serial_number support > > > > drivers/soc/fsl/guts.c | 219 ++++++++++++++++++++++------------------- > > 1 file changed, 118 insertions(+), 101 deletions(-) > > There goes another kernel release without any comments on this > series :( > > Shawn, can you pick this up and give it some time in linux-next? Okay, I just picked the series up to IMX tree. Leo, let me know if you want to drop it from IMX tree. Shawn
> -----Original Message----- > From: Shawn Guo <shawnguo@kernel.org> > Sent: Monday, June 27, 2022 1:53 AM > To: Michael Walle <michael@walle.cc> > Cc: linuxppc-dev@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org; > linux-kernel@vger.kernel.org; Leo Li <leoyang.li@nxp.com>; Ulf Hansson > <ulf.hansson@linaro.org>; Sudeep Holla <Sudeep.Holla@arm.com>; Arnd > Bergmann <arnd@arndb.de>; Dan Carpenter <dan.carpenter@oracle.com> > Subject: Re: [PATCH RESEND v2 0/7] soc: fsl: guts: cleanups and > serial_number support > > On Wed, Jun 22, 2022 at 01:03:33PM +0200, Michael Walle wrote: > > Am 2022-04-04 11:56, schrieb Michael Walle: > > > [Resend because of new development cycle. Shawn, can this series get > > > through your tree? Sorry you weren't on CC on the former > > > submissions.] > > > > > > This series converts the guts driver from a platform driver to just > > > an core_initcall. The driver itself cannot (or rather should never) > > > be unloaded because others depends on detecting the current SoC > > > revision to apply chip errata. Other SoC drivers do it the same way. > > > Overall I got rid of all the global static variables. > > > > > > The last patch finally adds unique id support to the guts driver. DT > > > binding can be found at: > > > Documentation/devicetree/bindings/nvmem/fsl,layerscape-sfp.yaml > > > > > > changes since v1: > > > - call kfree() in error case, thanks Dan > > > - add missing of_node_put(np), thanks Dan > > > > > > Michael Walle (7): > > > soc: fsl: guts: machine variable might be unset > > > soc: fsl: guts: remove module_exit() and fsl_guts_remove() > > > soc: fsl: guts: embed fsl_guts_get_svr() in probe() > > > soc: fsl: guts: allocate soc_dev_attr on the heap > > > soc: fsl: guts: use of_root instead of own reference > > > soc: fsl: guts: drop platform driver > > > soc: fsl: guts: add serial_number support > > > > > > drivers/soc/fsl/guts.c | 219 > > > ++++++++++++++++++++++------------------- > > > 1 file changed, 118 insertions(+), 101 deletions(-) > > > > There goes another kernel release without any comments on this series > > :( > > > > Shawn, can you pick this up and give it some time in linux-next? > > Okay, I just picked the series up to IMX tree. > > Leo, let me know if you want to drop it from IMX tree. No problem. You can take these through your tree. Thanks. Regards, Leo