| Message ID | 20220622175547.289717-1-kishen.maloor@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | mptcp: support MP_PRIO signals with userspace PMs | expand |
On Wed, 22 Jun 2022, Kishen Maloor wrote: > This patch series updates MPTCP_PM_CMD_SET_FLAGS to allow userspace PMs > to issue MP_PRIO signals for a specified address ID over a chosen > MPTCP connection. It also adds self testing support for this change. > > Kishen Maloor (2): > mptcp: netlink: issue MP_PRIO signals from userspace PMs > selftests: mptcp: userspace PM support for MP_PRIO signals > > net/mptcp/pm_netlink.c | 23 ++++++++++---- > net/mptcp/pm_userspace.c | 30 ++++++++++++++++++ > net/mptcp/protocol.h | 6 +++- > tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 19 ++++++++++-- > .../selftests/net/mptcp/userspace_pm.sh | 31 +++++++++++++++++++ > 5 files changed, 100 insertions(+), 9 deletions(-) > > > base-commit: 68fec8b7f640037e4bf224ca4e924574098f5911 > -- > 2.31.1 Thanks Kishen! The selftest passed on my test system, but I have one comment on that patch. Paolo, do agree this is best sent to the -net branch? This is an important chunk of the userspace PM that we accidentally overlooked, and it seems pretty important to get in to 5.19. -- Mat Martineau Intel
On Wed, 22 Jun 2022, Mat Martineau wrote: > On Wed, 22 Jun 2022, Kishen Maloor wrote: > >> This patch series updates MPTCP_PM_CMD_SET_FLAGS to allow userspace PMs >> to issue MP_PRIO signals for a specified address ID over a chosen >> MPTCP connection. It also adds self testing support for this change. >> >> Kishen Maloor (2): >> mptcp: netlink: issue MP_PRIO signals from userspace PMs >> selftests: mptcp: userspace PM support for MP_PRIO signals >> >> net/mptcp/pm_netlink.c | 23 ++++++++++---- >> net/mptcp/pm_userspace.c | 30 ++++++++++++++++++ >> net/mptcp/protocol.h | 6 +++- >> tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 19 ++++++++++-- >> .../selftests/net/mptcp/userspace_pm.sh | 31 +++++++++++++++++++ >> 5 files changed, 100 insertions(+), 9 deletions(-) >> >> >> base-commit: 68fec8b7f640037e4bf224ca4e924574098f5911 >> -- >> 2.31.1 > > Thanks Kishen! > > The selftest passed on my test system, but I have one comment on that patch. > > Paolo, do agree this is best sent to the -net branch? This is an important > chunk of the userspace PM that we accidentally overlooked, and it seems > pretty important to get in to 5.19. > One other thing: I did gather some pcaps in a manual run, and verified that the MP_PRIO packet is generated for both setting and clearing the backup flag. -- Mat Martineau Intel