Message ID | 20220621154402.482857-1-burzalodowa@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | [1/2] xen/arm: vtimer: Fix MISRA C 2012 Rule 8.4 violation | expand |
On Tue, 21 Jun 2022, Xenia Ragiadakou wrote: > Include vtimer.h so that the declarations of vtimer functions with external > linkage are visible before the function definitions. > > Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> > --- > xen/arch/arm/vtimer.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/xen/arch/arm/vtimer.c b/xen/arch/arm/vtimer.c > index 5bb5970f58..5f26463354 100644 > --- a/xen/arch/arm/vtimer.c > +++ b/xen/arch/arm/vtimer.c > @@ -29,6 +29,7 @@ > #include <asm/time.h> > #include <asm/vgic.h> > #include <asm/vreg.h> > +#include <asm/vtimer.h> > #include <asm/regs.h> > > /* > -- > 2.34.1 >
Hi Xenia, On 22/06/2022 00:44, Stefano Stabellini wrote: > On Tue, 21 Jun 2022, Xenia Ragiadakou wrote: >> Include vtimer.h so that the declarations of vtimer functions with external >> linkage are visible before the function definitions. >> >> Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> > > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org> Like your other series, I wasn't able to find a cover letter so replying here. I have now committed it. But in the future, please create a cover letter. Cheers,
diff --git a/xen/arch/arm/vtimer.c b/xen/arch/arm/vtimer.c index 5bb5970f58..5f26463354 100644 --- a/xen/arch/arm/vtimer.c +++ b/xen/arch/arm/vtimer.c @@ -29,6 +29,7 @@ #include <asm/time.h> #include <asm/vgic.h> #include <asm/vreg.h> +#include <asm/vtimer.h> #include <asm/regs.h> /*
Include vtimer.h so that the declarations of vtimer functions with external linkage are visible before the function definitions. Signed-off-by: Xenia Ragiadakou <burzalodowa@gmail.com> --- xen/arch/arm/vtimer.c | 1 + 1 file changed, 1 insertion(+)