| Message ID | YrRry7K66BzKezl8@kili (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b4cbd7a9339f396a991a9a056c4b57a35a4cbd96 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: lan743x: Use correct variable in lan743x_sgmii_config() | expand |
On Thu, Jun 23, 2022 at 04:34:03PM +0300, Dan Carpenter wrote: > There is a copy and paste bug in lan743x_sgmii_config() so it checks > if (ret < 0) instead of if (mii_ctl < 0). > > Fixes: 46b777ad9a8c ("net: lan743x: Add support to SGMII 1G and 2.5G") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Thu, 23 Jun 2022 16:34:03 +0300 you wrote: > There is a copy and paste bug in lan743x_sgmii_config() so it checks > if (ret < 0) instead of if (mii_ctl < 0). > > Fixes: 46b777ad9a8c ("net: lan743x: Add support to SGMII 1G and 2.5G") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > --- > drivers/net/ethernet/microchip/lan743x_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Here is the summary with links: - [net-next] net: lan743x: Use correct variable in lan743x_sgmii_config() https://git.kernel.org/netdev/net-next/c/b4cbd7a9339f You are awesome, thank you!
diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c index 79ecf296161e..a9a1dea6d731 100644 --- a/drivers/net/ethernet/microchip/lan743x_main.c +++ b/drivers/net/ethernet/microchip/lan743x_main.c @@ -1212,8 +1212,8 @@ static int lan743x_sgmii_config(struct lan743x_adapter *adapter) /* SGMII/1000/2500BASE-X PCS power down */ mii_ctl = lan743x_sgmii_read(adapter, MDIO_MMD_VEND2, MII_BMCR); - if (ret < 0) - return ret; + if (mii_ctl < 0) + return mii_ctl; mii_ctl |= BMCR_PDOWN; ret = lan743x_sgmii_write(adapter, MDIO_MMD_VEND2, MII_BMCR, mii_ctl);
There is a copy and paste bug in lan743x_sgmii_config() so it checks if (ret < 0) instead of if (mii_ctl < 0). Fixes: 46b777ad9a8c ("net: lan743x: Add support to SGMII 1G and 2.5G") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/net/ethernet/microchip/lan743x_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)