diff mbox series

[2/2] drm/panel: simple: add AM-800600P5TMQW-TB8H

Message ID 20220610111511.1421067-2-bst@pengutronix.de (mailing list archive)
State New, archived
Headers show
Series [1/2] dt-bindings: display: simple: add Ampire AM-800600P5TMQW-TB8H panel | expand

Commit Message

Bastian Krause June 10, 2022, 11:15 a.m. UTC 
Add support for the Ampire AM-800600P5TMQW-TB8H 800x600 panel. Data
sheet is currently not publicly available, unfortunately.

Signed-off-by: Bastian Krause <bst@pengutronix.de>
---
 drivers/gpu/drm/panel/panel-simple.c | 33 ++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

Comments

Sam Ravnborg June 24, 2022, 7:54 p.m. UTC | #1 
Hi Bastian,

On Fri, Jun 10, 2022 at 01:15:11PM +0200, Bastian Krause wrote:
> Add support for the Ampire AM-800600P5TMQW-TB8H 800x600 panel. Data
> sheet is currently not publicly available, unfortunately.
> 
> Signed-off-by: Bastian Krause <bst@pengutronix.de>

Applied to drm-misc (drm-misc-next).
When applying I fixed up the compatible to match the binding.
You may need to fix your DT files if they used the old compatible.
The one from the binding had a dash like similar panels, so that is
the one I picked.
See below for the fix-up.

	Sam

> ---
>  drivers/gpu/drm/panel/panel-simple.c | 33 ++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 4a2e580a2f7b7..3a61873dd887c 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -778,6 +778,36 @@ static const struct panel_desc ampire_am800480r3tmqwa1h = {
>  	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
>  };
>  
> +static const struct display_timing ampire_am800600p5tmqw_tb8h_timing = {
> +	.pixelclock = { 34500000, 39600000, 50400000 },
> +	.hactive = { 800, 800, 800 },
> +	.hfront_porch = { 12, 112, 312 },
> +	.hback_porch = { 87, 87, 48 },
> +	.hsync_len = { 1, 1, 40 },
> +	.vactive = { 600, 600, 600 },
> +	.vfront_porch = { 1, 21, 61 },
> +	.vback_porch = { 38, 38, 19 },
> +	.vsync_len = { 1, 1, 20 },
> +	.flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW |
> +		DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE |
> +		DISPLAY_FLAGS_SYNC_POSEDGE,
> +};
> +
> +static const struct panel_desc ampire_am800600p5tmqwtb8h = {
> +	.timings = &ampire_am800600p5tmqw_tb8h_timing,
> +	.num_timings = 1,
> +	.bpc = 6,
> +	.size = {
> +		.width = 162,
> +		.height = 122,
> +	},
> +	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH |
> +		DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE |
> +		DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE,
> +	.connector_type = DRM_MODE_CONNECTOR_DPI,
> +};
> +
>  static const struct display_timing santek_st0700i5y_rbslw_f_timing = {
>  	.pixelclock = { 26400000, 33300000, 46800000 },
>  	.hactive = { 800, 800, 800 },
> @@ -3754,6 +3784,9 @@ static const struct of_device_id platform_of_match[] = {
>  	}, {
>  		.compatible = "ampire,am800480r3tmqwa1h",
>  		.data = &ampire_am800480r3tmqwa1h,
> +	}, {
> +		.compatible = "ampire,am800600p5tmqwtb8h",
was changed to
> +		.compatible = "ampire,am800600p5tmqw-tb8h",
> +		.data = &ampire_am800600p5tmqwtb8h,
>  	}, {
>  		.compatible = "arm,rtsm-display",
>  		.data = &arm_rtsm,
> -- 
> 2.30.2
>
Bastian Krause June 27, 2022, 8:12 a.m. UTC | #2 
Hi Sam,

On 6/24/22 21:54, Sam Ravnborg wrote:
> On Fri, Jun 10, 2022 at 01:15:11PM +0200, Bastian Krause wrote:
>> Add support for the Ampire AM-800600P5TMQW-TB8H 800x600 panel. Data
>> sheet is currently not publicly available, unfortunately.
>>
>> Signed-off-by: Bastian Krause <bst@pengutronix.de>
> 
> Applied to drm-misc (drm-misc-next).
> When applying I fixed up the compatible to match the binding.
> You may need to fix your DT files if they used the old compatible.
> The one from the binding had a dash like similar panels, so that is
> the one I picked.

Thanks! I changed the compatible in the yaml binding to resemble the
other Ampire compabibles, but forgot to change that in the actual code,
of course..

> See below for the fix-up.
> 
> 	Sam
> 
>> ---
>>   drivers/gpu/drm/panel/panel-simple.c | 33 ++++++++++++++++++++++++++++
>>   1 file changed, 33 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
>> index 4a2e580a2f7b7..3a61873dd887c 100644
>> --- a/drivers/gpu/drm/panel/panel-simple.c
>> +++ b/drivers/gpu/drm/panel/panel-simple.c
>> @@ -778,6 +778,36 @@ static const struct panel_desc ampire_am800480r3tmqwa1h = {
>>   	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
>>   };
>>   
>> +static const struct display_timing ampire_am800600p5tmqw_tb8h_timing = {
>> +	.pixelclock = { 34500000, 39600000, 50400000 },
>> +	.hactive = { 800, 800, 800 },
>> +	.hfront_porch = { 12, 112, 312 },
>> +	.hback_porch = { 87, 87, 48 },
>> +	.hsync_len = { 1, 1, 40 },
>> +	.vactive = { 600, 600, 600 },
>> +	.vfront_porch = { 1, 21, 61 },
>> +	.vback_porch = { 38, 38, 19 },
>> +	.vsync_len = { 1, 1, 20 },
>> +	.flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW |
>> +		DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE |
>> +		DISPLAY_FLAGS_SYNC_POSEDGE,
>> +};
>> +
>> +static const struct panel_desc ampire_am800600p5tmqwtb8h = {
>> +	.timings = &ampire_am800600p5tmqw_tb8h_timing,
>> +	.num_timings = 1,
>> +	.bpc = 6,
>> +	.size = {
>> +		.width = 162,
>> +		.height = 122,
>> +	},
>> +	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
>> +	.bus_flags = DRM_BUS_FLAG_DE_HIGH |
>> +		DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE |
>> +		DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE,
>> +	.connector_type = DRM_MODE_CONNECTOR_DPI,
>> +};
>> +
>>   static const struct display_timing santek_st0700i5y_rbslw_f_timing = {
>>   	.pixelclock = { 26400000, 33300000, 46800000 },
>>   	.hactive = { 800, 800, 800 },
>> @@ -3754,6 +3784,9 @@ static const struct of_device_id platform_of_match[] = {
>>   	}, {
>>   		.compatible = "ampire,am800480r3tmqwa1h",
>>   		.data = &ampire_am800480r3tmqwa1h,
>> +	}, {
>> +		.compatible = "ampire,am800600p5tmqwtb8h",
> was changed to
>> +		.compatible = "ampire,am800600p5tmqw-tb8h",
>> +		.data = &ampire_am800600p5tmqwtb8h,

Your fixup is correct.

Regards,
Bastian

>>   	}, {
>>   		.compatible = "arm,rtsm-display",
>>   		.data = &arm_rtsm,
>> -- 
>> 2.30.2
>>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 4a2e580a2f7b7..3a61873dd887c 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -778,6 +778,36 @@  static const struct panel_desc ampire_am800480r3tmqwa1h = {
 	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
 };
 
+static const struct display_timing ampire_am800600p5tmqw_tb8h_timing = {
+	.pixelclock = { 34500000, 39600000, 50400000 },
+	.hactive = { 800, 800, 800 },
+	.hfront_porch = { 12, 112, 312 },
+	.hback_porch = { 87, 87, 48 },
+	.hsync_len = { 1, 1, 40 },
+	.vactive = { 600, 600, 600 },
+	.vfront_porch = { 1, 21, 61 },
+	.vback_porch = { 38, 38, 19 },
+	.vsync_len = { 1, 1, 20 },
+	.flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW |
+		DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE |
+		DISPLAY_FLAGS_SYNC_POSEDGE,
+};
+
+static const struct panel_desc ampire_am800600p5tmqwtb8h = {
+	.timings = &ampire_am800600p5tmqw_tb8h_timing,
+	.num_timings = 1,
+	.bpc = 6,
+	.size = {
+		.width = 162,
+		.height = 122,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB666_1X18,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH |
+		DRM_BUS_FLAG_PIXDATA_SAMPLE_NEGEDGE |
+		DRM_BUS_FLAG_SYNC_SAMPLE_NEGEDGE,
+	.connector_type = DRM_MODE_CONNECTOR_DPI,
+};
+
 static const struct display_timing santek_st0700i5y_rbslw_f_timing = {
 	.pixelclock = { 26400000, 33300000, 46800000 },
 	.hactive = { 800, 800, 800 },
@@ -3754,6 +3784,9 @@  static const struct of_device_id platform_of_match[] = {
 	}, {
 		.compatible = "ampire,am800480r3tmqwa1h",
 		.data = &ampire_am800480r3tmqwa1h,
+	}, {
+		.compatible = "ampire,am800600p5tmqwtb8h",
+		.data = &ampire_am800600p5tmqwtb8h,
 	}, {
 		.compatible = "arm,rtsm-display",
 		.data = &arm_rtsm,